* bug#18086: 24.4.50; NEWS entry for `kill-region' @ 2014-07-23 15:44 Drew Adams 2014-07-23 16:10 ` Andreas Schwab 2014-07-23 16:16 ` Drew Adams 0 siblings, 2 replies; 5+ messages in thread From: Drew Adams @ 2014-07-23 15:44 UTC (permalink / raw) To: 18086 From the beginning, and forever prior to Emacs 24.4, `kill-region' had this signature: (kill-region BEG END). That includes Emacs 24.3. Starting with Emacs 24.4, this is the signature: (kill-region BEG END &optional REGION) 1. This change should be called out in NEWS. 2. Instead, there is this entry in NEWS for Emacs 24.4, under "Incompatible Lisp changes in Emacs 24.4": ** `kill-region' has lost its `yank-handler' optional argument. This is incomprehensible. It never had a `yank-handler' optional argument. In GNU Emacs 24.4.50.1 (i686-pc-mingw32) of 2014-06-28 on ODIEONE Bzr revision: 117431 rgm@gnu.org-20140628015517-eku6hj8mpgcvfnso Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=/c/Devel/emacs/snapshot/trunk --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3' LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1 -Ic:/Devel/emacs/include'' ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#18086: 24.4.50; NEWS entry for `kill-region' 2014-07-23 15:44 bug#18086: 24.4.50; NEWS entry for `kill-region' Drew Adams @ 2014-07-23 16:10 ` Andreas Schwab 2014-07-23 16:56 ` Drew Adams 2014-07-23 16:16 ` Drew Adams 1 sibling, 1 reply; 5+ messages in thread From: Andreas Schwab @ 2014-07-23 16:10 UTC (permalink / raw) To: Drew Adams; +Cc: 18086 Drew Adams <drew.adams@oracle.com> writes: > This is incomprehensible. It never had a `yank-handler' optional > argument. (defun kill-region (beg end &optional yank-handler) Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#18086: 24.4.50; NEWS entry for `kill-region' 2014-07-23 16:10 ` Andreas Schwab @ 2014-07-23 16:56 ` Drew Adams 0 siblings, 0 replies; 5+ messages in thread From: Drew Adams @ 2014-07-23 16:56 UTC (permalink / raw) To: Andreas Schwab; +Cc: 18086 > > This is incomprehensible. It never had a `yank-handler' optional > > argument. > > (defun kill-region (beg end &optional yank-handler) See my previous reply about this. ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#18086: 24.4.50; NEWS entry for `kill-region' 2014-07-23 15:44 bug#18086: 24.4.50; NEWS entry for `kill-region' Drew Adams 2014-07-23 16:10 ` Andreas Schwab @ 2014-07-23 16:16 ` Drew Adams 2014-07-23 22:21 ` Stephen Berman 1 sibling, 1 reply; 5+ messages in thread From: Drew Adams @ 2014-07-23 16:16 UTC (permalink / raw) To: 18086 > From the beginning, and forever prior to Emacs 24.4, `kill-region' had > this signature: (kill-region BEG END). That includes Emacs 24.3. > > Starting with Emacs 24.4, this is the signature: > (kill-region BEG END &optional REGION) > > 1. This change should be called out in NEWS. > > 2. Instead, there is this entry in NEWS for Emacs 24.4, under > "Incompatible Lisp changes in Emacs 24.4": > > ** `kill-region' has lost its `yank-handler' optional argument. > > This is incomprehensible. It never had a `yank-handler' optional > argument. I was apparently wrong about that last statement (and so too about the first statement, that in 24.3 the function accepted only two args). [However, I do not really understand, and have no time to research this now: in Emacs 24.3, emacs -Q, `C-h f kill-region' does NOT show parameter YANK-HANDLER. But in the 24.3 source file simple.el, YANK-HANDLER is present. Perhaps the simple.elc distributed by GNU is older than the addition of YANK-HANDLER to simple.el?] The NEWS entry should state not that the YANK-HANDLER parameter was removed but that it was replaced by the REGION parameter etc. And of course there SHOULD have been a NEWS entry for 24.3, stating that parameter YANK-HANDLER was added. If it is not too late, that should be added now. Without it, mention of YANK-HANDLER in the 24.4 entry makes no sense. ^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#18086: 24.4.50; NEWS entry for `kill-region' 2014-07-23 16:16 ` Drew Adams @ 2014-07-23 22:21 ` Stephen Berman 0 siblings, 0 replies; 5+ messages in thread From: Stephen Berman @ 2014-07-23 22:21 UTC (permalink / raw) To: Drew Adams; +Cc: 18086 On Wed, 23 Jul 2014 09:16:56 -0700 (PDT) Drew Adams <drew.adams@oracle.com> wrote: >> From the beginning, and forever prior to Emacs 24.4, `kill-region' had >> this signature: (kill-region BEG END). That includes Emacs 24.3. >> >> Starting with Emacs 24.4, this is the signature: >> (kill-region BEG END &optional REGION) >> >> 1. This change should be called out in NEWS. >> >> 2. Instead, there is this entry in NEWS for Emacs 24.4, under >> "Incompatible Lisp changes in Emacs 24.4": >> >> ** `kill-region' has lost its `yank-handler' optional argument. >> >> This is incomprehensible. It never had a `yank-handler' optional >> argument. > > I was apparently wrong about that last statement (and so too about > the first statement, that in 24.3 the function accepted only two args). > > [However, I do not really understand, and have no time to research > this now: in Emacs 24.3, emacs -Q, `C-h f kill-region' does NOT > show parameter YANK-HANDLER. But in the 24.3 source file simple.el, > YANK-HANDLER is present. Perhaps the simple.elc distributed by GNU > is older than the addition of YANK-HANDLER to simple.el?] 24.3 was released March 11, 2013, but the yank-handler argument was obsoleted much earlier: 2010-11-18 Stefan Monnier <monnier@iro.umontreal.ca> * simple.el (kill-new, kill-append, kill-region): * comint.el (comint-kill-region): Make the yank-handler argument obsolete. Perhaps that's why the help in 24.3 doesn't show it. > The NEWS entry should state not that the YANK-HANDLER parameter > was removed but that it was replaced by the REGION parameter etc. > > And of course there SHOULD have been a NEWS entry for 24.3, > stating that parameter YANK-HANDLER was added. If it is not too > late, that should be added now. Without it, mention of YANK-HANDLER > in the 24.4 entry makes no sense. It's in NEWS.22: *** The functions `kill-new', `kill-append', and `kill-region' now have an optional argument to specify the `yank-handler' text property to put on the killed text. (However, 22.1 was released June 2, 2007, while the yank-handler parameter was added much earlier: 2003-01-18 Kim F. Storm <storm@cua.dk> * simple.el (kill-new, kill-append, kill-region): New optional parameter yank-handler. This was even before the release of 21.3 on March 24, 2003, though it was probably in feature freeze then. So it could have been added to the NEWS of 21.4, released on Feb 6, 2005; but, if memory serves, that was a security release with no new features.) Steve Berman ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-07-23 22:21 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-07-23 15:44 bug#18086: 24.4.50; NEWS entry for `kill-region' Drew Adams 2014-07-23 16:10 ` Andreas Schwab 2014-07-23 16:56 ` Drew Adams 2014-07-23 16:16 ` Drew Adams 2014-07-23 22:21 ` Stephen Berman
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).