From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#37189: 25.4.1: vc-hg-ignore implementation is missing Date: Sun, 23 Feb 2020 01:58:33 +0200 Message-ID: <3220684c-b1d9-08a3-e34b-cc54e99d4754@yandex.ru> References: <1ba53ae2-42a4-3ab3-d4f2-2ceae565d198@gmx.de> <83h806gp2w.fsf@gnu.org> <8336bmg1o9.fsf@gnu.org> <2354821b-5c1e-f9e3-3a64-4ff978ded33b@gmx.de> <83sgjkdev5.fsf@gnu.org> <3fb73dbc-bf31-233b-4afc-2147c4ffd5b7@gmx.de> <5622487d-a21f-49cf-5420-21f87415af4f@gmx.de> <83wo8ubfbo.fsf@gnu.org> <83zhdpqbas.fsf@gnu.org> <2c8419ae-723d-c7ae-a60e-59d1b1cbc2c1@gmx.de> <83o8u3r6wg.fsf@gnu.org> <6f3ba261-e1f9-cf19-cc22-ec8c24cf3298@gmx.de> <83blq2qzqp.fsf@gnu.org> <83ftfdplo8.fsf@gnu.org> <9929b44f-37da-23c8-16cc-c6ca89602149@yandex.ru> <2f84ddff-3275-6eb1-01ae-ff1d28b6e8da@gmx.de> <777563ca-b2c1-ab01-e1d5-6dc9c8f52415@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="86639"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: 37189@debbugs.gnu.org To: Wolfgang Scherer , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Feb 23 00:59:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j5efx-000MOr-N2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Feb 2020 00:59:13 +0100 Original-Received: from localhost ([::1]:48114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5efw-0002n9-Pb for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Feb 2020 18:59:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56895) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j5efn-0002my-Ab for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 18:59:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j5efm-0007lW-8v for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 18:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j5efm-0007lS-5C for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 18:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1j5efm-0007QQ-3r for bug-gnu-emacs@gnu.org; Sat, 22 Feb 2020 18:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Feb 2020 23:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37189 X-GNU-PR-Package: emacs Original-Received: via spool by 37189-submit@debbugs.gnu.org id=B37189.158241592428519 (code B ref 37189); Sat, 22 Feb 2020 23:59:02 +0000 Original-Received: (at 37189) by debbugs.gnu.org; 22 Feb 2020 23:58:44 +0000 Original-Received: from localhost ([127.0.0.1]:50239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5efU-0007Pu-IF for submit@debbugs.gnu.org; Sat, 22 Feb 2020 18:58:44 -0500 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:40445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1j5efS-0007Pg-8e for 37189@debbugs.gnu.org; Sat, 22 Feb 2020 18:58:43 -0500 Original-Received: by mail-wr1-f48.google.com with SMTP id t3so6117531wru.7 for <37189@debbugs.gnu.org>; Sat, 22 Feb 2020 15:58:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FWqHw3kC+BL86cu2Qeghq9YCpMr6mgN2lRfI1wenowQ=; b=B9HHt8ZnhouRIWThOE+utpcOsX7F6n5aF7NrXpWCv29RwZDQNEvCp0i+OxUroKO7JP PxwuwqxzjaC8xfCYcuHAIxtKoGwElLl8YQFINHHTQc7Q9y9fQazSiinpxKwbE9F5l0+u 2IqGvA0hD9zRg4naKZC5aYTbSLHA2yHLk2+pG5J5+f7lJAjmms0vYhEoRjWGZd03FFGc Enfkvp40jz/V/yRxvQF8L2QeTmqMervD0LlPz9wyykq2pNDtcS6IkmlM2CIkrCrug034 0BLQfMoNCEGp6puElRjRfezfbCM2vpDTEK6/H8h+CzNhK5QJdrZmOkga41zUdFT5Bzn9 Th+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FWqHw3kC+BL86cu2Qeghq9YCpMr6mgN2lRfI1wenowQ=; b=RJlMQBZrthlA7VV0h6eSsaYB9gisJHEKWkemOBpIWcupHmctHGX9JCCv+uEBdepaxv 4ozp9DMkxpL3yayThpw6naj0bk0QOF5WOEVLLEThn6lgy5Av/I8hkyQmk6F6WFcfIzLi jEp7uLwUf5O74dAypg+0IKfpnlJxDzgxtXDzZmQWHYWlohMGjcsRBhDttzxglQoIT0Mb P90hpiPlCm4bb/1wDNbTBQjcrsIRQVdJJaCstDIOfZ5dUQ0bLnHsiWzFAIxitE9qmy5h H+IuXtGhGVVn4yDp9D1J5kNleUA1nPYlyfW0C0RzShfudzpDw+Tj4WwqaX7LzSj+B9Sk f2vg== X-Gm-Message-State: APjAAAWy1jSFoa5c9ACTQSvZmrR0P3v7x2pMcPuJTz4lVWM0HyaDXQq2 4b0ifYqPjBWu40gpH6N1ls57WdA4 X-Google-Smtp-Source: APXvYqzx61tqaOSY0F+UDqN59MKDEtAHrjzkY20ggswGmvg8ud3fu75fLyWRW4kVsT1nKq0cHmUWKQ== X-Received: by 2002:a5d:5347:: with SMTP id t7mr56505270wrv.401.1582415916037; Sat, 22 Feb 2020 15:58:36 -0800 (PST) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id a184sm10889004wmf.29.2020.02.22.15.58.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Feb 2020 15:58:35 -0800 (PST) In-Reply-To: <777563ca-b2c1-ab01-e1d5-6dc9c8f52415@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:176407 Archived-At: On 23.02.2020 0:00, Wolfgang Scherer wrote: >> Escaping/anchoring can be added in the next step of the "series of ad-hoc patches". > I'm not saying to implement it now, I am just describing use cases, which are not limited to Emacs 27. Sure. >>> RCS, SCCS do not have ignore files, so they should error out. SRC has >>> ignore files similar to CVS and SVN. >> >> They will fail anyway because they implement neither 'find-ignore-file' nor the 'ignore' backend actions. > This is in reference to the condition-case around find-ignore-file, which is not necessary. It is OK to error out in that case. Without it, SVN and CVS would fail as well (since they don't implement 'find-ignore-file'). >> I think the patch is compatible with those. At least with the SVN one (vc-cvs-ignore might need a little work). >> >> Have you tried this patch with SVN? Is there a particular scenario where it fails? > No, it should not. CVS is now also patched, so it will no longer fail. Cool. Thank you. I have now pushed the patch to emacs-27. Please let us know if you see any unexpected problems. >>> I apologize for introducing ewoc into vc-dir-mode. Meanwhile I have >>> discovered vc-deduce-fileset, which does all the hard work for >>> preparing a fileset in vc-dir-mode, dired-mode and other >>> modes. vc-deduce-fileset delivers a backend and absolute file names, >>> not relative file names. >> >> Please submit a patch fixing that whenever you have the time. > I don't think it should be done before Emacs 28. It's fine to submit bug reports and patches now already. We can even install them on master. >>> I think introducing relative file names in >>> function APIs is the wrong way to go. However, as a preliminary >>> solution, it does suffice. >> >> I think it's just fine if the function is supposed to receive an *ignore pattern*, and not a simple file name. > > Again, it is probably not the time right now to discuss these matters. > > What will be the time frame for starting Emacs 28 topics? Since the discussion of vc-ignore in Emacs 27 seems finished, we can go on ahead with that right now.