From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Kupfer Newsgroups: gmane.emacs.bugs Subject: bug#60423: 29.0.60; goto-address and shr/textsec don't play nicely together Date: Sun, 27 Oct 2024 12:24:21 -0700 Message-ID: <32125.1730057061@alto.camomileplus.org> References: <175894.1672372745@alto> <831qoh6j0i.fsf@gnu.org> <69964.1728432546@alto.camomileplus.org> <86jzeh4g7x.fsf@gnu.org> <66867.1729115569@alto.camomileplus.org> <86ed41al4q.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19851"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60423@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 27 20:25:54 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t58te-0004zW-JT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 27 Oct 2024 20:25:54 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t58tU-0003PJ-Lf; Sun, 27 Oct 2024 15:25:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t58tK-0003Ox-N9 for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 15:25:35 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t58tD-0006QF-HL for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 15:25:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=Date:MIME-Version:References:In-reply-to:From:To:Subject; bh=ak3D9Gepac/6KagOY5m8A8ntu9Gtxe9JKHvit30nVJE=; b=sNndqGTe/5cQ3N7pArXm7gnGOxRI5jxtiLdcAFhd+Q2QK01nNexvWojPDuIzSsdkf8MjaKqFNjm5C7WrEgh6+6Qeqm4szygpoAtPvUwLjcA18nsiL2ccduDHGj1OwzkC2bBRiN4eXuQTGGCXI+hRUnX+hqLOMLPQcaDOwveLJzI5f6ijLbDkRIz0ETL0dGbGESaNahEhL4TGwSEuzXmHwF3xS1vSN/mfgHzh+xtwBwSKDj3AIVDMIJFBVX6Dy4ijAvZ/PTFQPGWtu9wiT67U2FNbOWZunL2V70lZXsBXcbzLlIKds+2G3Ptd5bA92D0KUzW1GJz0tDyJ20cmgTrx3Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t58tm-0006ao-Ec for bug-gnu-emacs@gnu.org; Sun, 27 Oct 2024 15:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Kupfer Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Oct 2024 19:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60423 X-GNU-PR-Package: emacs Original-Received: via spool by 60423-submit@debbugs.gnu.org id=B60423.173005710624915 (code B ref 60423); Sun, 27 Oct 2024 19:26:02 +0000 Original-Received: (at 60423) by debbugs.gnu.org; 27 Oct 2024 19:25:06 +0000 Original-Received: from localhost ([127.0.0.1]:46397 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t58sr-0006Tn-Oy for submit@debbugs.gnu.org; Sun, 27 Oct 2024 15:25:06 -0400 Original-Received: from shell1.rawbw.com ([198.144.192.42]:24319 ident=root) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t58sp-0006Te-HN for 60423@debbugs.gnu.org; Sun, 27 Oct 2024 15:25:04 -0400 Original-Received: from alto.camomileplus.org (135-180-174-211.dsl.dynamic.sonic.net [135.180.174.211] (may be forged)) (authenticated bits=0) by shell1.rawbw.com (8.15.1/8.15.1) with ESMTPSA id 49RJOLtp059322 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 27 Oct 2024 12:24:26 -0700 (PDT) (envelope-from kupfer@rawbw.com) X-Authentication-Warning: shell1.rawbw.com: Host 135-180-174-211.dsl.dynamic.sonic.net [135.180.174.211] (may be forged) claimed to be alto.camomileplus.org In-reply-to: <86ed41al4q.fsf@gnu.org> Comments: In-reply-to Eli Zaretskii message dated "Sun, 27 Oct 2024 12:35:49 +0200." X-Mailer: MH-E 8.6+git; nmh 1.8-RC2; Emacs 30.0.91 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:294388 Archived-At: Eli Zaretskii wrote: > > From: Mike Kupfer [...] > > Stefan Monnier wrote: [...] > > > Maybe it should check for the presence of `help-echo and (follow-link > > > or keymap)`? And make sure the those properties cover exactly the sa= me > > > chunk of text? > >=20 > > As far as covering the same chunk of text, I'll need to play with this > > some more to see what works. shr-tag-a inserts a warning emoji with a > > help-echo property, which goto-address somehow manages to clobber. That > > warning emoji is not something goto-address would normally be looking > > for. >=20 > Ping! How can we make some progress with this bug report? I did figure out why goto-address is clobbering the help-echo property on the warning emoji. goto-address uses goto-address-url-regexp to identify URLs. shr puts the emoji immediately after the suspicious URL, and apparently the regexp includes the emoji as part of the URL. https://badurl.com=E2=9A=A0=EF=B8=8F I haven't completely reverse-engineered the regexp. I see that it's built from a list of URI schemes and thing-at-point-url-path-regexp. Maybe thing-at-point-url-path-regexp needs to be pickier? But I don't understand how things should work in light of internationalized URLs. I've thought about having goto-address bail out if there are any conflicting properties in the range that it wants to overlay, but I haven't had time to prototype it to see how well that works. I suppose another possibility would be to move the warning emoji: put it in front of the suspicious URL, rather than after the URL. WDYT? mike