unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Kevin Rodgers <ihs_4664@yahoo.com>
Subject: Re: find-grep-dired vs. browse-url-of-dired-file
Date: Fri, 10 Dec 2004 10:59:29 -0700	[thread overview]
Message-ID: <31u6g5F3egsmnU1@individual.net> (raw)
In-Reply-To: <mailman.5025.1102701222.27204.bug-gnu-emacs@gnu.org>

Kevin Rodgers wrote:
 > doesn't begin with a slash.  All that's needed to fix that is for
 > browse-url-of-file to call expand-file-name first:
 >
 > *** emacs-21.3/lisp/net/browse-url.el~    Wed Dec  4 05:38:27 2002
 > --- emacs-21.3/lisp/net/browse-url.el    Fri Dec 10 10:38:04 2004
 > ***************
 > *** 535,541 ****
 >   `browse-url-file-url'.  Pass the URL to a browser using the
 >   `browse-url' function then run `browse-url-of-file-hook'."
 >     (interactive)
 > !   (or file
 >         (setq file (buffer-file-name))
 >         (error "Current buffer has no file"))
 >     (let ((buf (get-file-buffer file)))
 > --- 535,542 ----
 >   `browse-url-file-url'.  Pass the URL to a browser using the
 >   `browse-url' function then run `browse-url-of-file-hook'."
 >     (interactive)
 > !   (or (and file
 > !            (setq file (expand-file-name file)))
 >         (setq file (buffer-file-name))
 >         (error "Current buffer has no file"))
 >     (let ((buf (get-file-buffer file)))

Actually, I think it'd be clearer to write that conditional as:

   (cond (file (setq file (expand-file-name file)))
         ((setq file (buffer-file-name)))
         (t (error "Current buffer has no file")))

-- 
Kevin Rodgers

  parent reply	other threads:[~2004-12-10 17:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.4836.1102632722.27204.bug-gnu-emacs@gnu.org>
2004-12-10 17:43 ` find-grep-dired vs. browse-url-of-dired-file Kevin Rodgers
     [not found] ` <mailman.5025.1102701222.27204.bug-gnu-emacs@gnu.org>
2004-12-10 17:59   ` Kevin Rodgers [this message]
2004-12-09 21:07 Dan Jacobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=31u6g5F3egsmnU1@individual.net \
    --to=ihs_4664@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).