From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#58453: 28.2; project-query-replace-regexp fails because of directories in list Date: Wed, 12 Oct 2022 00:06:09 +0300 Message-ID: <31c821cd-087e-11e2-55a3-15cd8f529e3d@yandex.ru> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19430"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 To: Robert Nikander , 58453@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 11 23:47:53 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiN6O-0004pN-BX for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Oct 2022 23:47:52 +0200 Original-Received: from localhost ([::1]:58572 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiN6N-00047i-EM for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 11 Oct 2022 17:47:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45904) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiMSu-0003ZQ-4q for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 17:07:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55931) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiMSs-0004WI-N2 for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 17:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oiMSs-00057D-H4 for bug-gnu-emacs@gnu.org; Tue, 11 Oct 2022 17:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 11 Oct 2022 21:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58453 X-GNU-PR-Package: emacs Original-Received: via spool by 58453-submit@debbugs.gnu.org id=B58453.166552239219611 (code B ref 58453); Tue, 11 Oct 2022 21:07:02 +0000 Original-Received: (at 58453) by debbugs.gnu.org; 11 Oct 2022 21:06:32 +0000 Original-Received: from localhost ([127.0.0.1]:55008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiMSN-00056E-58 for submit@debbugs.gnu.org; Tue, 11 Oct 2022 17:06:32 -0400 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:37547) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oiMS8-00055m-V8 for 58453@debbugs.gnu.org; Tue, 11 Oct 2022 17:06:29 -0400 Original-Received: by mail-wr1-f48.google.com with SMTP id bv10so19892783wrb.4 for <58453@debbugs.gnu.org>; Tue, 11 Oct 2022 14:06:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=C29dC1fcwZFAN/XNksUvkeAHbwX1lXtIYVxNbSjLjH8=; b=qi3L0pxL8bKgopAuMV0WWu7D16MT3fXbmnQVQFQYP1Bg3pBEUwVH9NoJw60ZiMVJeO I9Bc+JukGaxrpCPRPVPQa3iZB5dj9ZJQMbPE7o7qyTVcATaW5Z4cYCEOvCujHgCbcmbj kZdUnEDa9YsCB9jnLYdcSTpI/KzgifYwIwasEo5s/2kp+UP+3cOpurqP0/A1RI0XpPOI GhQMAalUAUB54SVwU5hk3FbZDRWMHpa1ZlhqFh+TM1QnRGwgaNyqMN9cnbdkd3ydFIs5 Y9UGBOgYhT9LnKHAnmwot6TkmH9FYZB9ca2buEJn5x/mprrJXxyUTrmIiuWO/o6GSn49 iUQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=C29dC1fcwZFAN/XNksUvkeAHbwX1lXtIYVxNbSjLjH8=; b=8HNAMBy6lggQQ2pyApcOQ/jnRjFl79bqpH/xGbuljwmAn7gNy6+wSQN6161LuSVneC oohR+u0z/BkzOeCIfjsNFOtGdNDvIbl0R2pGo8U2VT3XWTK+8pODZL5Viun7sswPYlDS VYad/6lWf6OqyiKPNXwOBDFOhqoGNflQCMRYz18d2m4iDpwxiwPISpGAwN6f+SGU88VQ CqBeoZDQLz0CzUByljas/7WepP3b8wRCSr4EQ/xvWthPA3+VmhmYvknft2gns1vCqCK1 l0nYxdGnhZOA9N3fS4XxMgO6gRtmsIE+qtxBKS075kU9qfTCU+udAfOfFxRWLp6zS+3U r3hg== X-Gm-Message-State: ACrzQf2r6eXPia1S8CLHdGlwBBYNtbyPs5DeQTr+jeCdaiU/YVMmEfPe oOjaocbqewJp3sO4FvYZXmw= X-Google-Smtp-Source: AMsMyM5gmoz+D6h+SeJWOXJGcY2lqP2Vnk7Ee6jaLr50J2NlX5UgDV15Vjlfoq3h7PuAq0S0EmDHuQ== X-Received: by 2002:a05:6000:15cf:b0:230:ba81:cefc with SMTP id y15-20020a05600015cf00b00230ba81cefcmr6872752wry.544.1665522371135; Tue, 11 Oct 2022 14:06:11 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id bs14-20020a056000070e00b0022a297950cesm11882788wrb.23.2022.10.11.14.06.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Oct 2022 14:06:10 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245153 Archived-At: On 11.10.2022 16:58, Robert Nikander via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Hi > > I’ve been getting errors from `project-query-replace-regexp` (it just beeps and gives an error about something being a directory). I’ve tracked it down to `project--vc-list-files`, which gets a list in a variable `files` by calling `git ls-files`. But that returns a few directories on my system, maybe because I’m using git submodules. Later the error occurs with stack trace: > > Debugger entered--Lisp error: (file-error "Read error" "Is a directory” ….) > insert-file-contents(“….”) > fileloop-next-file(t) > fileloop-continue() > project-query-replace-regexp("StyleDict" "StyleMap") > > I’ve fixed the bug for my purposes by adding this line to that `project--vc-list-files` function in `project.el`... > > (setq files (seq-remove 'file-directory-p files)) > > But maybe there’s a better way. Hi! This has been fixed on master a few months ago: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=55382 I've just bumped project.el's version to 0.8.2, you should be able to install it from GNU ELPA tomorrow (or perhaps a bit earlier).