From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#62301: 29.0.60; treesit-parent-while should mention that the return value may include the initial node Date: Tue, 21 Mar 2023 14:52:19 -0700 Message-ID: <31AF139A-2994-41F6-AB2C-2119F340B4CD@gmail.com> References: <8f60f61a-45a0-9413-2bb1-689c24f82f11@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10796"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62301-done@debbugs.gnu.org To: daanturo@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 21 22:53:26 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pejv4-0002c9-I3 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 21 Mar 2023 22:53:26 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pejum-0000cT-3O; Tue, 21 Mar 2023 17:53:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pejug-0000bN-Ny for bug-gnu-emacs@gnu.org; Tue, 21 Mar 2023 17:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pejug-0006Qz-Fm for bug-gnu-emacs@gnu.org; Tue, 21 Mar 2023 17:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pejug-000674-2W for bug-gnu-emacs@gnu.org; Tue, 21 Mar 2023 17:53:02 -0400 In-Reply-To: <8f60f61a-45a0-9413-2bb1-689c24f82f11@gmail.com> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Tue, 21 Mar 2023 21:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62301 X-GNU-PR-Package: emacs Mail-Followup-To: 62301@debbugs.gnu.org, casouri@gmail.com, daanturo@gmail.com Original-Received: via spool by 62301-done@debbugs.gnu.org id=D62301.167943555823458 (code D ref 62301); Tue, 21 Mar 2023 21:53:01 +0000 Original-Received: (at 62301-done) by debbugs.gnu.org; 21 Mar 2023 21:52:38 +0000 Original-Received: from localhost ([127.0.0.1]:32831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pejuI-00066I-6y for submit@debbugs.gnu.org; Tue, 21 Mar 2023 17:52:38 -0400 Original-Received: from mail-pj1-f50.google.com ([209.85.216.50]:36442) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pejuG-000664-IJ for 62301-done@debbugs.gnu.org; Tue, 21 Mar 2023 17:52:36 -0400 Original-Received: by mail-pj1-f50.google.com with SMTP id o6-20020a17090a9f8600b0023f32869993so17843262pjp.1 for <62301-done@debbugs.gnu.org>; Tue, 21 Mar 2023 14:52:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679435550; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=7+yMen/dJzVlLoTCw9W0CGhyEudb+2xpdyVqpY9hj1I=; b=L8XCCp9Axg7M6ZmBLszDuDzZqXD3ZEra2l/j+Ar5W3M3uyI8mpYu2mo0rjvMyTEXWS k6RTA9/YPji8puGU47UGCIKbvFJKT0tr+pnKGRuOC1pi6tJ1k+I7e4fHlYkI1ysnACsK yc/80jZ/1FvlURLCqxrAZ+yltSP+ibU1iUnUFUvAD7HK8YalIxiUSkcnxJR2hDu26J80 jdhCerbL0Jl9DC3qOcjRtshW4UVha1PzIJPa2RqHwZ67VA4jA3PoAiRgk+i5vxVGNvlR t4nOfSwD95B+3jWiPDamFSDbhkIO0gKv1a3LCPKlL15DhsokSEkqdDGsZfuG5oeT4HBg iz4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679435550; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7+yMen/dJzVlLoTCw9W0CGhyEudb+2xpdyVqpY9hj1I=; b=P34YhAt9+Ox07y36Hv9OSt3mjTgffn/KYJ7cHCKCloaJcHgHj4UZ9IDWrHW9CTGtMI Sryk59AVQYc+t5V6d73IUbIkBr2iK6HrJSr3FIQqKWnT8IZNtx/Gt+N/RxBbp8dbS6Iw CpRlyOwsgCwJy8cG4dzxBjPG6ZH5x1Fof2+Nho0LQ7Wg11unvkmK22Pda5TR8qe60Vtl uYPTExUQb8cW8xF6l8iXjxOulVRT6BABciM5IXUtQQi51lDqF+rOzSq7vs9xsBMWTUm9 2uM8BfW4we4sQD8/SLNSEASEgfmuzjzdXa6JdpVBjQSgQ4tjTH+CGPok40HxfibqO5N/ iM2Q== X-Gm-Message-State: AO0yUKUb6gkuMeT5dETZxRmoQBt5ljmgL7+wuc997I8kxhrIjD1ldO80 N3bm2EGH/r0g2BLGPDATazQ= X-Google-Smtp-Source: AK7set96ap7cwcxUWReXvgXcZawz1abxFU1lrp5xeUQ/JPJTZSUQ7otWqxgda6AvdRw0DW/4s+3mWQ== X-Received: by 2002:a17:90b:38c8:b0:23b:4005:26e6 with SMTP id nn8-20020a17090b38c800b0023b400526e6mr1196117pjb.34.1679435550680; Tue, 21 Mar 2023 14:52:30 -0700 (PDT) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id lw13-20020a17090b180d00b0023b3a9fa603sm4358215pjb.55.2023.03.21.14.52.29 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Mar 2023 14:52:30 -0700 (PDT) X-Mailer: Apple Mail (2.3731.400.51.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258370 Archived-At: daanturo writes: > For the current implementation of `treesit-parent-while`, it will return > the initial argument NODE who satisfies PRED while its immediate parent > doesn't. But the docstring, when mentioning return values, only said > about "parent" but not the child itself. > > For example, finding the node closest to the root that covers only > exactly one of its descendant. > > (-let* ((node (treesit-node-at (point)))) > (treesit-parent-while > node > (lambda (nd) > (and (= (treesit-node-start nd) (treesit-node-start node)) > (= (treesit-node-end nd) (treesit-node-end node)))))) > > > I don't think that's a bug as it's useful to include the child > sometimes, as the example above, but I think the docstring should > clarify more. Thanks for the report! I updated the docstring as you suggested. Yuan