From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thomas Koch Newsgroups: gmane.emacs.bugs Subject: bug#61350: Eglot over Tramp freezes with large project Date: Tue, 7 Mar 2023 15:04:16 +0200 (EET) Message-ID: <31964054.380679.1678194256931@office.mailbox.org> References: <87y1ootw2t.fsf@gmail.com> <87a613f0b7.fsf@gmx.de> <87r0udvmzr.fsf@gmx.de> <878rglxrzm.fsf@gmail.com> <87cz5wmjbx.fsf@gmx.de> <87h6v8f7u9.fsf@gmail.com> <87o7pflfcd.fsf@gmx.de> <87wn43e9ht.fsf@gmail.com> <874jr6oont.fsf@gmx.de> <87sfeqd4zi.fsf@gmail.com> <877cw1swjm.fsf@gmx.de> <87k0016dgo.fsf@gmx.de> <1458446553.50372.1677606917251@office.mailbox.org> <87ilfkh89k.fsf@gmail.com> <87y1ofct83.fsf@gmx.de> <87356n8kja.fsf@gmail.com> <877cvvfnp6.fsf@gmx.de> <54377687.213790.1678016749459@office.mailbox.org> <87356jfktc.fsf@gmx.de> <87a60ovi90.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15365"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 61350@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Mar 07 14:05:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZX0D-0003iS-Gr for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Mar 2023 14:05:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZX05-0002Na-5b; Tue, 07 Mar 2023 08:05:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZX03-0002NL-1D for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:05:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZX02-0006wQ-Nn for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZX02-0002nN-D7 for bug-gnu-emacs@gnu.org; Tue, 07 Mar 2023 08:05:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thomas Koch Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Mar 2023 13:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61350 X-GNU-PR-Package: emacs Original-Received: via spool by 61350-submit@debbugs.gnu.org id=B61350.167819426910694 (code B ref 61350); Tue, 07 Mar 2023 13:05:02 +0000 Original-Received: (at 61350) by debbugs.gnu.org; 7 Mar 2023 13:04:29 +0000 Original-Received: from localhost ([127.0.0.1]:44776 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZWzU-0002mP-T9 for submit@debbugs.gnu.org; Tue, 07 Mar 2023 08:04:29 -0500 Original-Received: from mout-p-201.mailbox.org ([80.241.56.171]:40266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZWzS-0002mA-75 for 61350@debbugs.gnu.org; Tue, 07 Mar 2023 08:04:27 -0500 Original-Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4PWFyT6yWJz9sZg; Tue, 7 Mar 2023 14:04:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=koch.ro; s=MBO0001; t=1678194258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BNobBccSNb01f1GxIYIp0lolS/pFmTUsunvOYGReMOU=; b=aTj2BkvYOoRFS9plwVSiBlGQ+UrBv2Fz6mektLXD5CpweQ9SbWGe1qtvrOSWesfyFwyUWm NHOdLY35Mq9fFmNnVh3pJFt3Frzqu1IL4PzRK/f1gOez04zD3c53bu65PpVyz25Qh5XJ7E p4Vje4TSNb8wxCqNUvl5v9lvj1xpxcnmtNEO+JHSIDZRwvkDU5IrSeGP4cG2LAuU9RA+8T p3f5O4mx5shNQi6xoINxPynrjqlS+9e2khd76blDfkCRyPe67V5Y/zOjFiymvwoo4lgVEb 5+dQgop1Tvxf5gKbl6vEFn3ZGtiWNn+AJPnsK25KmMebzTuB7rDiM2hzgfaLAg== In-Reply-To: <87a60ovi90.fsf@gmx.de> X-Priority: 3 Importance: Normal X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257445 Archived-At: Thanks Michael! What is the advantage of this patch over just removing the = JUST-THIS-ONE argument? In both cases tramp is triggering accept-process-ou= tput for processes it does not own. However with your patch there is a potential timing issue: blocking process= output could still arrive between your new loop and tramps call to accept-= process-output with JUST-THIS-ONE. I'd think that there might be room for an essay "JUST-THIS-ONE considered e= vil"? > Michael Albinus hat am 07.03.2023 14:49 EET gesc= hrieben: >=20 > =20 > Michael Albinus writes: >=20 > Hi Thomas & Jo=C3=A3o, >=20 > before going offline just a short status update. >=20 > >> However my conclusion is different. I consider the root-cause to be > >> the use of JUST-THIS-ONE in tramps call to > >> accept-process-output. Please check my comment to bug > >> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D12145 > > > > I've seen this. And yes, we shall fix the problems described there. > > > >> As a practical roadmap you could add an option to Tramp to disable > >> JUST-THIS-ONE and recommend its use. Later the options default could > >> be toggled. Eventually the option can go away. > > > > Might be applicable in the master branch. But first we need much more > > checks that it doesn't break something else. > > > > I'm always uncomfortable to change Tramp such a way that other packages > > could be broken. Letting Tramp accept process output for all existing > > processes doesn't seem to be the right thing to me, although I admit > > that it seems to fix the specific problem we're discussing here. >=20 > Thinking about, I came to a less invasive idea: Just the processes which > possibly use the same socket for the ssh connection should accept their > output in time. This avoids to change the behavior of other processes, > which are not related to a given Tramp connection. And it makes me feel > much better :-) >=20 > The small patch below, on top of Tramp 2.6.0.2, seems to fix the > problem. I've also deactivated (in Emacs 29) Jo=C3=A3o's Tramp fix, and I= 've > applied the recipe given by Thomas 10 times in a row, always starting > with "emacs -Q ...". 10 times success. >=20 > Could you please check how it works in your environment? You'll have > some days until I'll be back. If it also works for you, I will add it to > Tramp 2.6.0.3, and we could close this bug. >=20 > For completeness, tramp-test44-asynchronous-requests now fails in > tramp-tests.el. But this test is already flaky (not passing successfully > every time), so I'll investigate later what's up with this. >=20 > Best regards, Michael.