From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#13521: `sort-lines' on the empty region Date: Sat, 5 Sep 2020 08:46:14 -0700 (PDT) Message-ID: <317a21e9-c922-49f4-897f-1a753e06e13b@default> References: <<<<20130122085354.75ced82538551655e724e0ea@gmail.com>>>> <<<>>> <<<>>> <<<>>> <<<>>> <<<<83mu2objro.fsf@gnu.org>>>> <<<>>> <<<<83imdcbgc5.fsf@gnu.org>>>> <<<>>> <<<<83imcspim8.fsf@gnu.org>>>> <<<3aad96d8-2503-40e8-b684-8ed18a089083@default>>> <<<83a6y4p98g.fsf@gnu.org>>> <<7cfc062e-05b2-43f1-8714-19ebd955b88c@default>> <<837dt8p74z.fsf@gnu.org>> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35904"; mail-complaints-to="usenet@ciao.gmane.io" Cc: xfq.free@gmail.com, rgm@gnu.org, stefan@marxist.se, monnier@iro.umontreal.ca, 13521@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 17:47:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEaPK-0009BU-Bg for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 17:47:14 +0200 Original-Received: from localhost ([::1]:41710 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEaPJ-0004JX-Ad for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 11:47:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEaP7-0004Is-Ug for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60612) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEaP7-0006Ss-IT for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:47:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEaP7-00051e-Hg for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 15:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13521-submit@debbugs.gnu.org id=B13521.159932078719277 (code B ref 13521); Sat, 05 Sep 2020 15:47:01 +0000 Original-Received: (at 13521) by debbugs.gnu.org; 5 Sep 2020 15:46:27 +0000 Original-Received: from localhost ([127.0.0.1]:43925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaOZ-00050q-2e for submit@debbugs.gnu.org; Sat, 05 Sep 2020 11:46:27 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:40252) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaOX-00050d-49 for 13521@debbugs.gnu.org; Sat, 05 Sep 2020 11:46:26 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 085Fibn5122439; Sat, 5 Sep 2020 15:46:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=XMOKqZRaT5uhaeMDurwcM9KMN4raXHPDQHYyDUjH8FU=; b=dfOqZ66q9MeQAXpC1cmPJd84Bhm99l1mIoaVji41t+tb0ofxSL04Oq7DbEZUgsjaF6ND 2fx9VYQpUXsdKOG9nNnWTPFf/GLjaTYdUf1J1dd6o1XEx6XNP+BLzlOU/57rWy5QD8K4 G+5OE38sCUDf/HAsoARd/srLH2hgdgc2RwdMCGZ2YxBlUmHr3wpMBYrZrVMnSeduQOOz EljcxAvxLSqJUSEvQVsnWWQiJKlfdMOPkKQLfzJ8fAWawFRkzFvTeO27Z4m+yWdrphGN 7fG/xsJV2/5/DWxiBiTzRaT1Kly5h2Nsf+vPa9JiIiv5y98TJMM2ZEwphAUVTKbkinRu HA== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 33c2mkhe2k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 05 Sep 2020 15:46:19 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 085FiojH146618; Sat, 5 Sep 2020 15:46:19 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 33c2g0pnww-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 05 Sep 2020 15:46:18 +0000 Original-Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 085FkGMG016547; Sat, 5 Sep 2020 15:46:17 GMT In-Reply-To: <<837dt8p74z.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9735 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 phishscore=0 mlxlogscore=999 spamscore=0 bulkscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009050152 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9735 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 priorityscore=1501 phishscore=0 adultscore=0 bulkscore=0 clxscore=1015 mlxlogscore=999 malwarescore=0 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2009050152 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187272 Archived-At: > > > > I doubt that someone who has `transient-mark-mode' off > > > > would ever want commands such as `flush-lines' and > > > > `sort-lines' to act on the region. And if they did, I > > > > expect they'd just narrow to it. > > > > > > Please don't doubt, and please don't impose unnecessary commands on > > > users who have transient-mark-mode off. > > > > Please don't claim that I imposed any commands on anyone. >=20 > You expected them to narrow the buffer. That takes additional > commands. I do expect that, for `flush-lines', which is what I was thinking of. You correctly pointed out that `sort-lines' is different. > > The region is nearly always present and usually nonempty. > > A user with `transient-mark-mode' off would typically > > (IMHO) be bothered if `flush-lines' started always acting > > on the region (it would be almost always: whenever there's > > a mark in the buffer and the region is nonempty). >=20 > So maybe flush-lines needs a separate solution, or none at all. This > bug is about sort-lines, so flush-lines is a tangent. I didn't introduce `flush-lines' into the thread. But yes, the subject line says `sort-lines', and `flush-lines' is a very different case. > > And I think "the important point here" is that a command > > that behaves differently when the region is active should > > NOT act on the region when `transient-mark-mode' is off. >=20 > That's not really relevant here. We are talking about commands which > by virtue of their 'interactive' spec work on the region. Such > commands shouldn't depend on the region being active. Yes, if this is only about commands like `sort-lines'. Introducing `flush-lines' here was apparently a mistake, which muddied the waters. > > This was not the case for `sort-lines', as you point out. > > It did NOT, and does not, behave differently when the > > region is active from when it is inactive. >=20 > The proposed change would have made it behave differently, which is > why I've pointed that out. Good. Agreed.