From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#36644: Git log search Date: Thu, 25 Jul 2019 15:36:54 +0300 Message-ID: <3126d32c-fbe5-771e-c89f-d3e898e811c8@yandex.ru> References: <874l3p4lks.fsf@mail.linkov.net> <87blxvj5lv.fsf@mail.linkov.net> <23ad9090-ebfc-4307-b41f-30f7c310d978@yandex.ru> <87tvbliw37.fsf@mail.linkov.net> <1251461563472968@myt6-1dca55ddeee8.qloud-c.yandex.net> <87lfwvrpur.fsf@mail.linkov.net> <62a4fa22-d4f5-5cd4-69b7-7ae1c70e68bc@yandex.ru> <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> <83v9vro1fy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="147838"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 Cc: rpluim@gmail.com, 36644@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 25 14:38:08 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hqd0a-000cKG-0S for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jul 2019 14:38:08 +0200 Original-Received: from localhost ([::1]:59682 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqd0Y-0005gN-HV for geb-bug-gnu-emacs@m.gmane.org; Thu, 25 Jul 2019 08:38:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36352) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hqd0V-0005fy-Jp for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 08:38:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hqd0U-0005s4-JK for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 08:38:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57896) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hqd0U-0005ry-Ct for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 08:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hqd0U-0002qf-7s for bug-gnu-emacs@gnu.org; Thu, 25 Jul 2019 08:38:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 Jul 2019 12:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36644 X-GNU-PR-Package: emacs Original-Received: via spool by 36644-submit@debbugs.gnu.org id=B36644.156405822610891 (code B ref 36644); Thu, 25 Jul 2019 12:38:02 +0000 Original-Received: (at 36644) by debbugs.gnu.org; 25 Jul 2019 12:37:06 +0000 Original-Received: from localhost ([127.0.0.1]:38484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqcza-0002pb-HO for submit@debbugs.gnu.org; Thu, 25 Jul 2019 08:37:06 -0400 Original-Received: from mail-wm1-f45.google.com ([209.85.128.45]:37614) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hqczY-0002p6-OK for 36644@debbugs.gnu.org; Thu, 25 Jul 2019 08:37:05 -0400 Original-Received: by mail-wm1-f45.google.com with SMTP id f17so44581134wme.2 for <36644@debbugs.gnu.org>; Thu, 25 Jul 2019 05:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YZ545B+KmQPWHzQn8SCct0CSePoPGT3qAlMSga/x1Is=; b=vO4bNS7TrETmW5nKixQBFEww/64bDADi9jXQTjiVr2QGhUE3aPWI3dMGSPHkjjTBZP gbv81/XfdFCB647ceS8W1lj+qs9BHMEG5K7anQs6SDPdd/itiwAVANtMqPFhxG6gQFYh 11NEeNxqOu11Yqdg4DpqWdlJbgiKOrMYm8s674vamyqonYqtwUOCzikcBhxqXb+l2D+4 CQ7GPthRndwEQJ9FHHwrvvW84iKGZN20kuHI66EiPXg2F7r0mOlATXzSNXQdUmH7+pol aWX6RtpZMxvmnx0sVGtuI6A2HFm1jy9spIHRLPoQ3eqVtU1/5HAeYU4d/4b7fNh1ZQbw UcrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YZ545B+KmQPWHzQn8SCct0CSePoPGT3qAlMSga/x1Is=; b=N+ZoqJ5FdKJ9/ItQda9nM87aP6ys5Xk5EoMokW+4WdjXTqGps4IeP7K1ltAHt7p8EC 0HZdQFAVHY4vzlSfDYEva0stpnMzhXxU4TZFU8cgTcSF1OwrcJA7IAXyBq9NDyElDXga BWIeY3N8kiP1PkNhtllbaiVSkDJb2wjgmerNYZUViJvP6UMV5GBZDbQUZQcZRpgXqAwe 4+w4c+8luKkhZNJi7vLZYunkcOxFsQKh4WxgNd2buKVMoxoUaRp4uiHps6usWc0HKFUX sgWV9kcZxoZAJ86D9wAql8WnGPvy+6B/+YM0HMKtZHXTkND76l7egrcKKr9f4zC5HWfO IBXQ== X-Gm-Message-State: APjAAAViSx0inWDyao7x+L4JsWaiOrV1HI+FeZ43L1Lcpu+wRepdTJAW VArbS3Kl3IQ8XIp0Za+RMa0= X-Google-Smtp-Source: APXvYqzZFjrk5GNqQA2hCznXw2qsa7ospZVfj48IaseRXiEcGfzcl+UjcTDCG7QhrXthkgkI4p7lwA== X-Received: by 2002:a7b:ce95:: with SMTP id q21mr81046024wmj.65.1564058218806; Thu, 25 Jul 2019 05:36:58 -0700 (PDT) Original-Received: from [192.168.0.195] ([109.110.245.170]) by smtp.googlemail.com with ESMTPSA id w14sm38939712wrk.44.2019.07.25.05.36.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 05:36:57 -0700 (PDT) In-Reply-To: <83v9vro1fy.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163698 Archived-At: On 24.07.2019 19:13, Eli Zaretskii wrote: >> Eli, could you weigh in in this discussion? Would you say Robert's >> proposal is acceptable? > > Yes, I think on balance it's acceptable. OK, thank you. > I also see your point: it would be nice to be able to document the > semantics of PATTERN in a backend-independent way. But I think this > is next to impossible in this case, both because of significant > differences in the backend capabilities (e.g., bzr doesn't have the > equivalent of Git's --fixed-strings, AFAICT), and because some backend > allow great flexibility in interpreting PATTERN, under control of > optional switches passed to the backend. The other option is to standardize on basic or extended regexp, and simply give up for backends that can't support that. Git supports all kinds of regexps. 'hg grep' uses Perl-compatible ones (meaning extended regexps are supported, at least). I'm not sure which regular expressions are expected by 'bzr log -match', but if it doesn't support the extended ones, *shrug*. As for the older VCS-es, some probably don't support search at all. And we've lived without such support for decades, so supporting them can't be too important. Anyway, if people disagree, I'm not going to press the issue. > So I think we should treat this as we do in "M-x grep": leave the > semantics of PATTERN backend-dependent, and rely on the user to quote > some characters in it as needed. Admittedly, 'grep' is lower-level > than 'vc-log-search', but at least we have a precedent. The difference is, 'M-x grep' doesn't use different backends. Although I'd be happy to see that capability. > Note that I still think we should use PATTERN, not STRING in the doc > string, because a literal string here is more an exception than a > rule. But we should say that the exact semantics of PATTERN is > backend-dependent, and perhaps describe how a couple of the more > popular backends interpret it. Makes sense.