From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#47300: delete-window to select window with same position Date: Fri, 4 Jun 2021 11:19:29 +0200 Message-ID: <30a62fd1-35f4-c8cf-4239-8ae9ae2d8af2@gmx.at> References: <87a6qw43gg.fsf@mail.linkov.net> <87pmxodrmq.fsf@gnus.org> <7f870f9b-95ad-6b5d-82aa-1bcfe5cc880a@gmx.at> <87fsyk0w92.fsf@mail.linkov.net> <2ec3b911-4fb1-4b13-a5b8-28278a5c43ba@gmx.at> <87h7iyzvh5.fsf@mail.linkov.net> <0c239adb-e9d5-1fe9-4c4c-2da1603002f7@gmx.at> <87mtsmmpey.fsf@mail.linkov.net> <1032ab23-3905-1b3f-917c-60ccd12337b3@gmx.at> <87v9752n4r.fsf@mail.linkov.net> <63612145-5eaa-0766-30cc-f30f7e7e1700@gmx.at> <87k0nefwq6.fsf@mail.linkov.net> <6f37ba16-527b-4537-116c-b215a9f39d1b@gmx.at> <87o8cmwrsf.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28558"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , 47300@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 04 11:23:49 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lp63Q-0007Ii-Gn for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Jun 2021 11:23:48 +0200 Original-Received: from localhost ([::1]:34358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lp63P-0007n5-FT for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 04 Jun 2021 05:23:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40898) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lp5zn-0000yV-17 for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 05:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33803) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lp5zm-0004H3-NG for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 05:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lp5zm-0000ya-H0 for bug-gnu-emacs@gnu.org; Fri, 04 Jun 2021 05:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 04 Jun 2021 09:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 47300-submit@debbugs.gnu.org id=B47300.16227983783708 (code B ref 47300); Fri, 04 Jun 2021 09:20:02 +0000 Original-Received: (at 47300) by debbugs.gnu.org; 4 Jun 2021 09:19:38 +0000 Original-Received: from localhost ([127.0.0.1]:45349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp5zN-0000xj-Q5 for submit@debbugs.gnu.org; Fri, 04 Jun 2021 05:19:37 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:36577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lp5zM-0000xT-CW for 47300@debbugs.gnu.org; Fri, 04 Jun 2021 05:19:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1622798370; bh=FzfcxIwWhaC1EBKJw26ydEQcRwlwsAYkGfROxw6DywM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=SFRpN4Aux8FB5apD8fVXCVBnJm2KVJnW7+L0gp0HgX8xCj5Tz90+glhaaAbJC0l2o Tcg204Z5lNEJ2NqGy5PxYZlh1T9Lk4VifXLKsf6ONt9o36q2yNYKPoSKWbGlNcCuK6 bRvU886azjcsPy4aOrsYzvjSkhoTutGBCfRZbZdY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([213.142.96.52]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4zAy-1lPYsY0WpA-010xUi; Fri, 04 Jun 2021 11:19:30 +0200 In-Reply-To: <87o8cmwrsf.fsf@mail.linkov.net> Content-Language: en-US X-Provags-ID: V03:K1:IH4bxfSjji3sf5YJhDIUyg4m4by23OQEuJJauE/WZoMKIlzH9l7 IeSoyJerKqkr7fmBze0hnyer8GEEbkVz9AVUX0AIx9fZ+iZYHhzbY25OXVxHTlJWxORUVPK wPcPHdG4o3+M6uregAIt35k+Z2t4cvSs0FOVQQIKrg3P3FJV7iw9Z2pd/657H91N5RnEFOB +f8X7584X288akBTGKKpg== X-UI-Out-Filterresults: notjunk:1;V03:K0:8U0viCmwG2k=:WWq5I8UYIYtgtXdPhJfmXG mGShMHWEMIaR/c4Un6kHgY9iIRBGZeJZskwVAM5g70YsrWVbfmQoQQvnYaOoTpX78fOw4o0cJ En4hMTcIk6ceDlX/o3PWYUyS4654orZHGN4Q10Fmp62+bsz1GsW2IsL2CXRF5MIF1R87P8UGT YiVHoy2pt/KRpE4xtSQO8fPqk1w0/m1bnAIbi9jvc7/z6I2PooV6zBzgtqFTgh8YhFtHbMtp+ AQTChIahhLH0E3wHBgFALDCeVt46Ck9EfwTjwQyYWMeoaoDGvAznLYWBF34QTm3siYB2eHifz s2XRrigOCxW5rtU81SzYJXgK5EdGSFb1ankifRK/7Do3RNM+2wJp0N8tfzD7a4Pwv0dYiwpzN FZ5j+T5KjYcP4rRD5yh3+NJIpukWctSH0eewftJ7Tpc0GU0uLrqoSDf0ire+m+W/m8lr/SNOM gNJmpW1hgSmK9iSi7T3SlZ+daVRwz6xjmTyexqkHFvG+kraJQfZi7v3ChpODFoWe4tRFn7Cbi 0mGPoWcTOU4MucXphIFXE3EbopJ5GvHYMAvzhOye8s4kCVDhyXQkK5s+D/R2UDnBxUw44KlWO 2dXJlMU/+SuqRRHwdSV1ZTOgFkY2+gwM3GwIuiIoXIIUOLS9/J4utm/lXLSUf0uyUskgmXUZO n/A4Vy4prVk5fGexIziAiS/GAmIYegHpssraDLXfhpNVL39yseOnEG+VsbVbyn3jHxVY2NMob xceoJtSvs/P9h9biG1E8Ckfa3GHWKw+mTtuzd+vmS+4RSXvDPKv79v+STScLOQK4ojOD1M5y X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:207985 Archived-At: >> I called them just 'mru' and 'pos' now. The option is called >> `selected-window-after-deletion', there might be better names. > > Maybe better with the same name prefix as `delete-window'? > For example, `delete-window-select'? But the current is also fine. It's not about "selecting a window", it's about "setting a frame's selected window". >> +(defun get-mru-window (&optional all-frames dedicated not-selected no-other) >> +non-nil means never return the selected window. Optional >> +argument NO_OTHER non-nil means to never return a window whose > > Typo: NO-OTHER Indeed. >> +(defcustom selected-window-after-deletion 'mru > > Not strictly necessary now, but for future extensions > would it be possible to allow this option > to be customized to a function that selects a window? > >> + :type '(choice (const :tag "Most recently used" mru) >> + (const :tag "At position" pos) >> + nil) In general, just plugging in some existing function would usually fail here and I would like to avoid the illusion that it could work. Also, as you can see with the 'pos' case, some work must be done _before_ calling `delete-window-internal' so the actual work would have to be split among two functions at least. > This 'nil' needs to be replaced with a list like: > > (const :tag "First window" nil) > >> + ;; If we deleted the selected window of WINDOW's frame, choose >> + ;; another one based on `selected-window-after-deletion'. Note >> + ;; that both `window-at-pos' and `get-mru-window' mail fail to > ========= > Typo. But it rhymes! martin