unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Robert Irelan <rirelan@gmail.com>, 53831@debbugs.gnu.org
Subject: bug#53831: 29.0.50; vc-git-registered hangs when examining files in .git directory for submodule
Date: Mon, 21 Feb 2022 03:37:30 +0200	[thread overview]
Message-ID: <3091c5d9-7eb7-722e-9912-f70db60728b2@yandex.ru> (raw)
In-Reply-To: <CAJUyYjqjf5EcGufzSKvwASYTJkK7Uqk6YfqmFc25rjePwvvxiA@mail.gmail.com>

Hi!

On 07.02.2022 00:56, Robert Irelan wrote:
> - Eventually, we attempt a `call-process` with the command line
>    `git --no-pager ls-files -c -z -- .git/modules/.doom.d/COMMIT_EDITMSG`
>    with `default-directory` set to `~`. This command takes around 20
>    seconds to exit with an empty output and exit status 0. I believe at
>    this point the code may continue to loop, since it hangs for longer
>    than that until I hit `C-g` a bunch of times.

Any idea why it hangs? Is that because of the size of the repository, or 
something like that?

I've tried to recreate this problem, but even with large repos 'git 
--no-pager ls-files -c -z -- .git/modules/.doom.d/COMMIT_EDITMSG' 
returns pretty quickly.

Does it take 20 seconds when running from a terminal? What if you try 
that with different files inside '.git'?

 > I propose that `vc-git-registered` return nil if the path contains
`/.git/`, since the contents of `.git` are never part of the Git
repository.

This can work. Though I'd rather understand the problem better first.





      parent reply	other threads:[~2022-02-21  1:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-06 22:56 bug#53831: 29.0.50; vc-git-registered hangs when examining files in .git directory for submodule Robert Irelan
2022-02-06 22:57 ` Robert Irelan
2022-02-21  1:37 ` Dmitry Gutov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3091c5d9-7eb7-722e-9912-f70db60728b2@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=53831@debbugs.gnu.org \
    --cc=rirelan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).