From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#60467: 30.0.50; primitive-undo: Changes to be undone by function different from announced Date: Mon, 26 Jun 2023 15:18:45 +0000 Message-ID: <30832e86470f7dc33387@heytings.org> References: <87o7ri74qv.fsf@localhost> <7ccb0e8131f84ca2ea0f0c0aed11dc197b578a64.camel@laposte.net> <83o7l61lz6.fsf@gnu.org> <2aa76ba11fd0a77ba107@heytings.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3208"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60467@debbugs.gnu.org, =?UTF-8?Q?Fr=C3=A9d=C3=A9ric?= Giquel , Eli Zaretskii , Ihor Radchenko , Alan Mackenzie To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 26 17:19:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDnzv-0000cW-8b for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Jun 2023 17:19:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDnzd-0007FO-N5; Mon, 26 Jun 2023 11:19:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDnzb-000795-0S for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 11:19:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDnza-00074m-NT for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 11:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qDnza-000387-If for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 11:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jun 2023 15:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60467 X-GNU-PR-Package: emacs Original-Received: via spool by 60467-submit@debbugs.gnu.org id=B60467.168779272812010 (code B ref 60467); Mon, 26 Jun 2023 15:19:02 +0000 Original-Received: (at 60467) by debbugs.gnu.org; 26 Jun 2023 15:18:48 +0000 Original-Received: from localhost ([127.0.0.1]:46861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDnzL-00037e-Sc for submit@debbugs.gnu.org; Mon, 26 Jun 2023 11:18:48 -0400 Original-Received: from heytings.org ([95.142.160.155]:59144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDnzK-00037V-Bt for 60467@debbugs.gnu.org; Mon, 26 Jun 2023 11:18:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1687792725; bh=NX95Wh3ncaacM976DCysgeZhk+KUWap1aFxxY8VtMbI=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=TRZKyhnPKDBavvo/F0QMbVB4D9XusjaMmoMAm1eI/vdzgfYQcaODHyN1dFerpTB3L /Xxj4GINqVq3lolx7X4qxk2sHwOn6MSITxyBCpPA/a6qLvH3UzbpJInitfpWuErC1h km4UQyVR1g55cfwgLH6ZkVqOg0XDIQEpLXlGKXtPvFVs8I6JYrUz3Te3vR3r+9LbHF sOS1PB1V2oX1h1ddH9zucN3/L/CfPWC9sQeqWiEZGT6kNCHQjqb4pK/pDcStN2tmy+ 18J698V8YyhCWBMfi3rph//O+XQmG4VK2gUNDtbGyvhkX9LIDSRaOKz9bIprpyTOjZ 1BPjUhAuLqnrQ== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264106 Archived-At: >>> Stefan, can you please look into this? >> >> FYI, that issue is fixed with the >> Fix-combine-change-call-with-timestamps patch. > > Oh, but I don't think this is OK for the `emacs-29` branch, so we still > need a more targetted fix for the `emacs-29` branch. > Well, that bug was already discussed at length six months ago, and the minimal change that was in the end installed (59c3c53efa) introduced a new bug. Should we design another minimal change, at the risk of introducing another bug? ISTM that the safe thing to do is the refactoring that was suggested.