From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#22324: 25.0.50; completion-category-defaults style doesn't override completion-styles (gets prepended instead) Date: Mon, 24 Jan 2022 04:03:17 +0200 Message-ID: <3045ca8b-f5d6-c85e-d170-3fe158fec64e@yandex.ru> References: <868u41rv84.fsf@yandex.ru> <83fuy8p8oq.fsf@gnu.org> <568FA9D0.2040609@yandex.ru> <83egdsp88n.fsf@gnu.org> <568FABFC.3000205@yandex.ru> <87tufr74of.fsf@gnus.org> <87lf0yjwpw.fsf@gnus.org> <87r1aodus0.fsf@gnus.org> <66aa873d-5f5f-9024-efb6-e6110c27ab3a@yandex.ru> <87ilvy4m94.fsf@gnus.org> <87czklnqvs.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33792"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Cc: 22324@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 24 03:04:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nBoiP-0008dX-0r for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 24 Jan 2022 03:04:17 +0100 Original-Received: from localhost ([::1]:39452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nBoiN-0008Ka-Uc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Jan 2022 21:04:15 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nBoiA-0008KL-Cb for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2022 21:04:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48678) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nBoiA-00079a-0V for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2022 21:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nBoi9-0003fg-Rl for bug-gnu-emacs@gnu.org; Sun, 23 Jan 2022 21:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jan 2022 02:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22324 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 22324-submit@debbugs.gnu.org id=B22324.164298980814059 (code B ref 22324); Mon, 24 Jan 2022 02:04:01 +0000 Original-Received: (at 22324) by debbugs.gnu.org; 24 Jan 2022 02:03:28 +0000 Original-Received: from localhost ([127.0.0.1]:41580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBohb-0003eg-PD for submit@debbugs.gnu.org; Sun, 23 Jan 2022 21:03:28 -0500 Original-Received: from mail-ed1-f48.google.com ([209.85.208.48]:42982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nBohZ-0003eV-Ln for 22324@debbugs.gnu.org; Sun, 23 Jan 2022 21:03:26 -0500 Original-Received: by mail-ed1-f48.google.com with SMTP id p12so53820500edq.9 for <22324@debbugs.gnu.org>; Sun, 23 Jan 2022 18:03:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jZGEfbjWUmODTqPUwhr69nV/+nla4vN3xXVqZfNOvBE=; b=lvKa1xURDCREbOks5PuLTkYUyx2uPFuABloJnGHHyKeMspHicGtHvL15FkjLS+U7q2 88qL610cYtvrO7pRt93RDdvhedYlbmEoDGF/L/VEpRPWVhsuga93vkoexSukz+ejyPID qZiYXznbEhWKrl4Oz+mVu6ajrh82CAXZPVSGZ9vThPxEHgxP92ZHzbgWKjnOnWgvpUnr ZatcOoe7IrbU+cQEw2K/T8TScBtgRKRZ19M2uMemaSliO8LSKiOgM02y04mkKeUq1Nlj y2OYGDein/BjZscCn49urJv4rLxCS5nBuUozAA3AMTmeewc8rFnSVsCB61Ftx1u5i6VM vMmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jZGEfbjWUmODTqPUwhr69nV/+nla4vN3xXVqZfNOvBE=; b=uhgaDBMJGmcxwVZgJCYSuJ47T8tEJBrpadHxKq8TPPuh6d4SPFB37UeNZSwjS/p08z /ZqwQsifXojWO4tzL+N2So20dlXjHRRBHzITB/i4nzJX3YNLZ4GHJCFhLkgPcrIBvnfi IWMPBcmOajjxCb7qun2wDkmtmxoU6hBl+SwvdF8cymZPPTDGticLm+MQs7pY29EVQ/ht QdIF6S34DEasOBn+FQ/klSpHteZslbIqMR/nuJ35yXuuaPCH7rRy1wTxUR7SG2vvHB7l e+GDZxvh6j0LV+MsDaKwqM3khE8TNPerhikDQspSQZMqKNd8E0OX397hyMnur3eZEIM2 OzCw== X-Gm-Message-State: AOAM533DwgMT8QqHn9LFSyYnlCwzH2UncBAL19EBiehc9y/cMz6Vj2jP lyCf9HtHW3yTGaQn+2rnn2+CRtrWVIV4bQ== X-Google-Smtp-Source: ABdhPJy/ywTzwYKmDj4G6ITTQfe7Qxb6NnHCR0Xg+I6nsbc2QYFSrHQ1P7MjdMmLvp8y0sx63+zkBw== X-Received: by 2002:a05:6402:50cd:: with SMTP id h13mr13981137edb.177.1642989799624; Sun, 23 Jan 2022 18:03:19 -0800 (PST) Original-Received: from [10.111.160.185] ([185.213.155.232]) by smtp.googlemail.com with ESMTPSA id gu2sm4273414ejb.221.2022.01.23.18.03.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jan 2022 18:03:19 -0800 (PST) In-Reply-To: <87czklnqvs.fsf@gnus.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224984 Archived-At: On 21.01.2022 15:46, Lars Ingebrigtsen wrote: > Lars Ingebrigtsen writes: > >> Dmitry Gutov writes: >> >>> Consider changing the behavior instead, though. >>> >>> Yes, it's been like this for a long time, but I imagine most users >>> won't notice the change. >>> >>> We could experiment on master. >> I'd rather not change something as subtle as this (especially in a >> mechanism that's been around for a while like this as). > Nobody had any further opinions here in a month, so I went ahead and > changed the doc string. If somebody feels strongly that the semantics > should be tweaked, I don't really have a strong opinion either way. Hi Lars, The doc change you have pushed in 62a84eea34c33bd1d4b1 misses the point, which leads me to believe that I have not explained the problem well. The issue is not that an entry in completion-category-overrides doesn't override all properties wholesale, that is falls back to defaults for properties not specified among the overrides. The issue is that when the 'styles' property is looked up (which is 99% of the uses of this variable), the override value is not used as-is. Instead, the default value is appended. So the fix I had in mind looks like: diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el index d58c23af8f..0aee55f33c 100644 --- a/lisp/minibuffer.el +++ b/lisp/minibuffer.el @@ -1043,7 +1043,7 @@ completion--styles (let* ((cat (completion-metadata-get metadata 'category)) (over (completion--category-override cat 'styles))) (if over - (delete-dups (append (cdr over) (copy-sequence completion-styles))) + (cdr over) completion-styles))) (defun completion--nth-completion (n string table pred point metadata)