From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: mail@xuchunyang.me Newsgroups: gmane.emacs.bugs Subject: bug#34065: 26.1; Make edebug-eval-expression support code completion Date: Wed, 20 Feb 2019 12:37:53 +0800 Message-ID: <3031611550637473@sas1-19a94364928d.qloud-c.yandex.net> References: <8736poyt0g.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="245762"; mail-complaints-to="usenet@blaine.gmane.org" To: Federico Tedin , "34065@debbugs.gnu.org" <34065@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 20 05:39:14 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gwJf7-0011oR-HH for geb-bug-gnu-emacs@m.gmane.org; Wed, 20 Feb 2019 05:39:13 +0100 Original-Received: from localhost ([127.0.0.1]:33776 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwJf6-0000Ow-D7 for geb-bug-gnu-emacs@m.gmane.org; Tue, 19 Feb 2019 23:39:12 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:37985) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gwJex-0000Oq-7l for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2019 23:39:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gwJew-00040f-Iy for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2019 23:39:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56272) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gwJew-00040O-CB for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2019 23:39:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gwJev-0003fC-Vi for bug-gnu-emacs@gnu.org; Tue, 19 Feb 2019 23:39:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: mail@xuchunyang.me Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Feb 2019 04:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 34065 X-GNU-PR-Package: emacs Original-Received: via spool by 34065-submit@debbugs.gnu.org id=B34065.155063748614018 (code B ref 34065); Wed, 20 Feb 2019 04:39:01 +0000 Original-Received: (at 34065) by debbugs.gnu.org; 20 Feb 2019 04:38:06 +0000 Original-Received: from localhost ([127.0.0.1]:57038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwJe2-0003e2-DC for submit@debbugs.gnu.org; Tue, 19 Feb 2019 23:38:06 -0500 Original-Received: from forward500j.mail.yandex.net ([5.45.198.250]:59877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gwJdy-0003dV-QM for 34065@debbugs.gnu.org; Tue, 19 Feb 2019 23:38:04 -0500 Original-Received: from mxback14j.mail.yandex.net (mxback14j.mail.yandex.net [IPv6:2a02:6b8:0:1619::90]) by forward500j.mail.yandex.net (Yandex) with ESMTP id 9C6C011C1ADF; Wed, 20 Feb 2019 07:37:54 +0300 (MSK) Original-Received: from localhost (localhost [::1]) by mxback14j.mail.yandex.net (nwsmtp/Yandex) with ESMTP id Lwu43XgwaZ-brdCqMIi; Wed, 20 Feb 2019 07:37:53 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xuchunyang.me; s=mail; t=1550637473; bh=aBg1ETg2OWFFQNESpaRk4aAc8MgTVrJGpXBRUxgXjd0=; h=From:To:In-Reply-To:References:Subject:Date:Message-Id; b=B2dDk0Ms4liWKdqijlWK5ikk+O6Iw2c50yUJ1KfcvRYbJ7FnZYGSXWwfxqyzCqHnc LqLOytW2XEFpsEYixgcsbT+uk/unOwVlGU4ogQm6DmmejKGLuA0PtBZIrCZYXE+Fzl /lQAiXEEmVeBQyBHEodyXEUxLOi7ZhMhqObexPcY= Authentication-Results: mxback14j.mail.yandex.net; dkim=pass header.i=@xuchunyang.me Original-Received: by sas1-19a94364928d.qloud-c.yandex.net with HTTP; Wed, 20 Feb 2019 07:37:53 +0300 In-Reply-To: <8736poyt0g.fsf@gmail.com> X-Mailer: Yamail [ http://yandex.ru ] 5.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155582 Archived-At: 20.01.2019, 10:15, "Federico Tedin" : > Xu Chunyang writes: > >>  When type e (edebug-eval-expression) within Edebug, I notice there is no code completion, unlike >>  M-: (eval-expression). So I wonder if edebug-eval-expression can behave >>  like eval-expression, I guess simply replacing read-from-minibuffer with >>  read--expression should work, though I've not tried. > > I've created a small patch which replaces `read-from-minibuffer' for > `read--expression' in `edebug-eval-expression'. I would appreciate it if > a maintainer could take a quick look. I'm not a maintainer. Your patch looks good to me. Today I notice it's possible to change the interactive form via Advising Functions, so I plan to put the following to my init file until the patch is applied. (define-advice edebug-eval-expression (:before (_expr) better-interactive-form) "Fix the original interactive form." (interactive (list (read--expression "Edebug Eval: "))))