* bug#12863: Annoying bug in revert-buffer [not found] <87d2zkl61y.fsf@Compaq.site.inet> @ 2012-11-11 19:00 ` Glenn Morris 2012-11-11 19:03 ` Glenn Morris 0 siblings, 1 reply; 9+ messages in thread From: Glenn Morris @ 2012-11-11 19:00 UTC (permalink / raw) To: 12863, Cecil Cecil Westerhof wrote: > I use revert-buffer on several log buffers. There is one annoying bug. > Sometimes Emacs sees that the buffer has changed and reloads it. But > when it changes in the same second again, the buffer is not reloaded > and you do not see the changes. First I thought it was a Windows > quirk, but now I have seen the same behaviour on Linux. (I am looking > more at log buffers I suppose.) Are you talking about auto-revert-mode? If so, C-h v auto-revert-interval (default 5 seconds). Otherwise, please tell us which version of Emacs this is. ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12863: Annoying bug in revert-buffer 2012-11-11 19:00 ` bug#12863: Annoying bug in revert-buffer Glenn Morris @ 2012-11-11 19:03 ` Glenn Morris [not found] ` <87625bsx8d.fsf@Compaq.site.inet> 0 siblings, 1 reply; 9+ messages in thread From: Glenn Morris @ 2012-11-11 19:03 UTC (permalink / raw) To: 12863; +Cc: Cecil Glenn Morris wrote: > Are you talking about auto-revert-mode? > If so, C-h v auto-revert-interval (default 5 seconds). Actually that's probably irrelevant. ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <87625bsx8d.fsf@Compaq.site.inet>]
* bug#12863: Annoying bug in revert-buffer [not found] ` <87625bsx8d.fsf@Compaq.site.inet> @ 2012-11-12 1:07 ` Glenn Morris 2012-11-12 1:54 ` Cecil Westerhof ` (2 more replies) 0 siblings, 3 replies; 9+ messages in thread From: Glenn Morris @ 2012-11-12 1:07 UTC (permalink / raw) To: Cecil Westerhof; +Cc: 12863 (Please use reply-to-all) Cecil Westerhof wrote (on Sun, 11 Nov 2012 at 21:25 +0100): > >> Are you talking about auto-revert-mode? > >> If so, C-h v auto-revert-interval (default 5 seconds). > > > > Actually that's probably irrelevant. > > Yes that is where I am talking about. Emacs sees that the file is > changed and reloads it in the buffer. But if in the same second the > file changes again, it is not reloaded. > > Here I am using: > GNU Emacs 23.3.1 (i586-suse-linux-gnu, GTK+ Version 2.24.7) of 2011-10-30 on build34 > > But I have seen the same problem under Windows. At the moment I do not > know which version that was. If needed I can retrieve that one also. > > A solution would be: (also) reloading a second after a change. I'm still unsure if you are talking about auto-revert-mode or an explicit call to revert-buffer. If I read the code correctly, revert-buffer does not care about time-stamps. auto-revert-mode does, and I think in Emacs 24.2 and earlier, file time-stamps were only stored to second precision. So indeed in Emacs 24.2 and earlier, file modifications that happened within a second of reverting would probably be invisible to auto-revert mode. Emacs 24.3 (not yet released) will use much higher resolution time-stamps, so this issue should be fixed there. ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12863: Annoying bug in revert-buffer 2012-11-12 1:07 ` Glenn Morris @ 2012-11-12 1:54 ` Cecil Westerhof 2012-11-12 20:04 ` Glenn Morris 2012-11-12 20:45 ` Andreas Schwab 2012-11-12 21:12 ` Stefan Monnier 2 siblings, 1 reply; 9+ messages in thread From: Cecil Westerhof @ 2012-11-12 1:54 UTC (permalink / raw) To: Glenn Morris Glenn, Op maandag 12 nov 2012 02:07 CET schreef Glenn Morris: > > (Please use reply-to-all) > > Cecil Westerhof wrote (on Sun, 11 Nov 2012 at 21:25 +0100): > >>>> Are you talking about auto-revert-mode? >>>> If so, C-h v auto-revert-interval (default 5 seconds). >>> >>> Actually that's probably irrelevant. >> >> Yes that is where I am talking about. Emacs sees that the file is >> changed and reloads it in the buffer. But if in the same second the >> file changes again, it is not reloaded. >> >> Here I am using: >> GNU Emacs 23.3.1 (i586-suse-linux-gnu, GTK+ Version 2.24.7) of 2011-10-30 on >> build34 >> >> But I have seen the same problem under Windows. At the moment I do not >> know which version that was. If needed I can retrieve that one also. >> >> A solution would be: (also) reloading a second after a change. > > I'm still unsure if you are talking about auto-revert-mode or an > explicit call to revert-buffer. I need to communicate better. :-{ It is auto-revert-mode. When I see that it has gone wrong, I can correct it with revert-buffer. ;-} > If I read the code correctly, > revert-buffer does not care about time-stamps. auto-revert-mode does, > and I think in Emacs 24.2 and earlier, file time-stamps were only > stored to second precision. So indeed in Emacs 24.2 and earlier, file > modifications that happened within a second of reverting would > probably be invisible to auto-revert mode. But if you would revert the buffer (also) in the second after the change, the problem would be solved, > Emacs 24.3 (not yet released) will use much higher resolution > time-stamps, so this issue should be fixed there. Any idea when it will come out? OpenSuse are not very good with maintaining Emacs. My version is 3½ years old and there have been five new releases. Maybe I should install Emacs manually. -- Cecil Westerhof Senior Software Engineer M Cecil@Decebal.nl LinkedIn: http://www.linkedin.com/in/cecilwesterhof O< ascii ribbon campaign - stop html mail - www.asciiribbon.org Please do not send me Microsoft Office/Apple iWork documents. Send OpenDocument instead! http://fsf.org/campaigns/opendocument/ ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12863: Annoying bug in revert-buffer 2012-11-12 1:54 ` Cecil Westerhof @ 2012-11-12 20:04 ` Glenn Morris 2012-11-13 1:40 ` Paul Eggert 0 siblings, 1 reply; 9+ messages in thread From: Glenn Morris @ 2012-11-12 20:04 UTC (permalink / raw) To: Cecil Westerhof; +Cc: 12863, Paul Eggert Actually, maybe this isn't fixed. I'm having a hard time testing it, but I see this comment in verify-visited-file-modtime: /* If both [times] exist, accept them if they are off by one second. */ Cc'ing Paul since he has worked on the time-stamps issue and can probably tell us whether or not it is fixed... ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12863: Annoying bug in revert-buffer 2012-11-12 20:04 ` Glenn Morris @ 2012-11-13 1:40 ` Paul Eggert 2012-11-13 1:50 ` Glenn Morris 0 siblings, 1 reply; 9+ messages in thread From: Paul Eggert @ 2012-11-13 1:40 UTC (permalink / raw) To: Glenn Morris; +Cc: 12863, Cecil Westerhof On 11/12/2012 12:04 PM, Glenn Morris wrote: > I see this comment in verify-visited-file-modtime: > > /* If both [times] exist, accept them if they are off by one second. */ I've had my eye on that code for some time, figuring that it must be bogus but not having the time to prove that it was bogus. Since it's now known to cause problems, I removed it in trunk bzr 110875. Since this is not a recent regression I did not install the change into the emacs-24 branch. ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12863: Annoying bug in revert-buffer 2012-11-13 1:40 ` Paul Eggert @ 2012-11-13 1:50 ` Glenn Morris 0 siblings, 0 replies; 9+ messages in thread From: Glenn Morris @ 2012-11-13 1:50 UTC (permalink / raw) To: 12863-done Version: 24.4 Paul Eggert wrote: > On 11/12/2012 12:04 PM, Glenn Morris wrote: >> I see this comment in verify-visited-file-modtime: >> >> /* If both [times] exist, accept them if they are off by one second. */ > > I've had my eye on that code for some time, figuring that > it must be bogus but not having the time to prove that it > was bogus. Since it's now known to cause problems, I removed it > in trunk bzr 110875. Thanks, I checked using `touch' and verify-visited-file-modtime that it fixes the issue for me. So this will be fixed in the next (probably) release after 24.3, not in 24.3 as I originally said. ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12863: Annoying bug in revert-buffer 2012-11-12 1:07 ` Glenn Morris 2012-11-12 1:54 ` Cecil Westerhof @ 2012-11-12 20:45 ` Andreas Schwab 2012-11-12 21:12 ` Stefan Monnier 2 siblings, 0 replies; 9+ messages in thread From: Andreas Schwab @ 2012-11-12 20:45 UTC (permalink / raw) To: Glenn Morris; +Cc: 12863, Cecil Westerhof Glenn Morris <rgm@gnu.org> writes: > Emacs 24.3 (not yet released) will use much higher resolution > time-stamps, so this issue should be fixed there. Only if the filesystem supports sub-second resolution. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." ^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#12863: Annoying bug in revert-buffer 2012-11-12 1:07 ` Glenn Morris 2012-11-12 1:54 ` Cecil Westerhof 2012-11-12 20:45 ` Andreas Schwab @ 2012-11-12 21:12 ` Stefan Monnier 2 siblings, 0 replies; 9+ messages in thread From: Stefan Monnier @ 2012-11-12 21:12 UTC (permalink / raw) To: Glenn Morris; +Cc: 12863, Cecil Westerhof > Emacs 24.3 (not yet released) will use much higher resolution > time-stamps, so this issue should be fixed there. Maybe we should also pay attention to the file-size. Stefan ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-11-13 1:50 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87d2zkl61y.fsf@Compaq.site.inet>
2012-11-11 19:00 ` bug#12863: Annoying bug in revert-buffer Glenn Morris
2012-11-11 19:03 ` Glenn Morris
[not found] ` <87625bsx8d.fsf@Compaq.site.inet>
2012-11-12 1:07 ` Glenn Morris
2012-11-12 1:54 ` Cecil Westerhof
2012-11-12 20:04 ` Glenn Morris
2012-11-13 1:40 ` Paul Eggert
2012-11-13 1:50 ` Glenn Morris
2012-11-12 20:45 ` Andreas Schwab
2012-11-12 21:12 ` Stefan Monnier
Code repositories for project(s) associated with this public inbox https://git.savannah.gnu.org/cgit/emacs.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).