* bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
@ 2014-02-28 5:08 Leo Liu
2014-02-28 7:17 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Leo Liu @ 2014-02-28 5:08 UTC (permalink / raw)
To: 16902
I often get a dozen vc-diff<N> buffers and was curious what caused this.
So vc-revert is the culprit. It seems better to also kill the
diff-buffer. Objections?
Leo
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
2014-02-28 5:08 bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around? Leo Liu
@ 2014-02-28 7:17 ` Glenn Morris
2014-02-28 12:15 ` Leo Liu
0 siblings, 1 reply; 6+ messages in thread
From: Glenn Morris @ 2014-02-28 7:17 UTC (permalink / raw)
To: Leo Liu; +Cc: 16902
Leo Liu wrote:
> I often get a dozen vc-diff<N> buffers and was curious what caused this.
> So vc-revert is the culprit. It seems better to also kill the
> diff-buffer. Objections?
Well I assume the people who added the feature whereby a new diff buffer
is created each time would object, because they want to keep the diff
buffer around. Eg in case they change their minds after reverting.
See eg http://debbugs.gnu.org/8927 .
Maybe (setq vc-revert-show-diff nil) will work for you?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
2014-02-28 7:17 ` Glenn Morris
@ 2014-02-28 12:15 ` Leo Liu
2014-02-28 19:53 ` Glenn Morris
0 siblings, 1 reply; 6+ messages in thread
From: Leo Liu @ 2014-02-28 12:15 UTC (permalink / raw)
To: 16902
On 2014-02-28 15:17 +0800, Glenn Morris wrote:
> Well I assume the people who added the feature whereby a new diff buffer
> is created each time would object, because they want to keep the diff
> buffer around. Eg in case they change their minds after reverting.
> See eg http://debbugs.gnu.org/8927 .
I have read the whole thread and it seems keeping the revert diff buffer
was unintended change. The complaint was not to override contents in the
old *vc-diff*.
I think it is better to kill that revert diff buffer.
> Maybe (setq vc-revert-show-diff nil) will work for you?
Leo
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
2014-02-28 12:15 ` Leo Liu
@ 2014-02-28 19:53 ` Glenn Morris
2014-02-28 21:04 ` Leo Liu
2021-09-04 9:12 ` Lars Ingebrigtsen
0 siblings, 2 replies; 6+ messages in thread
From: Glenn Morris @ 2014-02-28 19:53 UTC (permalink / raw)
To: Leo Liu; +Cc: 16902
How about extending the option vc-revert-show-diff to allow a new value,
`kill', which means to kill the diff buffer afterwards?
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
2014-02-28 19:53 ` Glenn Morris
@ 2014-02-28 21:04 ` Leo Liu
2021-09-04 9:12 ` Lars Ingebrigtsen
1 sibling, 0 replies; 6+ messages in thread
From: Leo Liu @ 2014-02-28 21:04 UTC (permalink / raw)
To: Glenn Morris; +Cc: 16902
On 2014-03-01 03:53 +0800, Glenn Morris wrote:
> How about extending the option vc-revert-show-diff to allow a new value,
> `kill', which means to kill the diff buffer afterwards?
Sounds like a good idea.
Leo
^ permalink raw reply [flat|nested] 6+ messages in thread
* bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around?
2014-02-28 19:53 ` Glenn Morris
2014-02-28 21:04 ` Leo Liu
@ 2021-09-04 9:12 ` Lars Ingebrigtsen
1 sibling, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-09-04 9:12 UTC (permalink / raw)
To: Glenn Morris; +Cc: 16902, Leo Liu
Glenn Morris <rgm@gnu.org> writes:
> How about extending the option vc-revert-show-diff to allow a new value,
> `kill', which means to kill the diff buffer afterwards?
Now done in Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-09-04 9:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-28 5:08 bug#16902: 24.3.50; why vc-revert keeps its diff-buffer around? Leo Liu
2014-02-28 7:17 ` Glenn Morris
2014-02-28 12:15 ` Leo Liu
2014-02-28 19:53 ` Glenn Morris
2014-02-28 21:04 ` Leo Liu
2021-09-04 9:12 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).