unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: James Thomas <jimjoe@gmx.net>, 71450@debbugs.gnu.org
Subject: bug#71450: [PATCH] Wrong eww-history-position after desktop restore if within history
Date: Sun, 9 Jun 2024 14:20:56 -0700	[thread overview]
Message-ID: <2fd89234-fab9-a0a3-3bc1-f193983e2cd4@gmail.com> (raw)
In-Reply-To: <86h6e21f0e.fsf@outlook.com>

On 6/9/2024 5:23 AM, James Thomas via Bug reports for GNU Emacs, the 
Swiss army knife of text editors wrote:
> This is a patch that I think is simple enough to forgo the extensive
> testing which it hasn't been subjected to.

Thanks for the patch.

> +          :history-position
> +          (cl-position
> +           (elt history eww-history-position)
> +           rval :test #'eww-desktop-history-duplicate))))

Two questions here:

1. Is that the right test function? I'd have expected 'eq', since we 
want to find the position where our history index has moved to, right?

2. Should this part check for 'eww-desktop-remove-duplicates' too? If 
that option is nil, I think we could avoid the 'cl-position' call. Or 
maybe lift the 'eww-desktop-remove-duplicates' call outside of the 
'list' and just construct two totally different lists in the THEN/ELSE 
blocks.





  reply	other threads:[~2024-06-09 21:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-09 12:23 bug#71450: [PATCH] Wrong eww-history-position after desktop restore if within history James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-09 21:20 ` Jim Porter [this message]
2024-06-09 23:33   ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-10 21:36   ` James Thomas via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-16  0:01     ` Jim Porter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fd89234-fab9-a0a3-3bc1-f193983e2cd4@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=71450@debbugs.gnu.org \
    --cc=jimjoe@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).