From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#60953: The :match predicate with large regexp in tree-sitter font-lock seems inefficient Date: Thu, 2 Feb 2023 21:44:09 +0200 Message-ID: <2fbb1175-9ab1-e2df-16a9-2d32f1cc226f@yandex.ru> References: <7624dddc-4600-9a03-ac8b-d3c9e0ab618c@yandex.ru> <83pmb1cbg5.fsf@gnu.org> <2da844d3-ea31-289e-2821-aa174e365ffd@yandex.ru> <6784f9e7-844b-374d-2a1e-8a61cebe0d7e@yandex.ru> <83zga03yne.fsf@gnu.org> <373a575f-c683-1581-c3e6-502e9897fb04@yandex.ru> <83mt603vrc.fsf@gnu.org> <83e58a1b-2e4a-356a-36d8-c756ff105b62@yandex.ru> <83bkmf52va.fsf@gnu.org> <33cad4c1-4af5-37bb-05bc-79a4d9c1a700@yandex.ru> <83wn533lut.fsf@gnu.org> <19892f55-498e-1109-2229-2ddd984849a4@yandex.ru> <83tu073ksp.fsf@gnu.org> <83sffr2xq2.fsf@gnu.org> <30b047a9-dfe3-948a-a123-2e15221c239d@yandex.ru> <83tu05zeqe.fsf@gnu.org> <957c7e3e-830e-0a03-562f-fdddc6bd1c06@yandex.ru> <835yckzic7.fsf@gnu.org> <835yckxi29.fsf@gnu.org> <88a57446-f89e-9b5e-5e8d-3c3b952ced41@yandex.ru> <83pmasvuzs.fsf@gnu.org> <64482032-87e4-f239-82b1-29c68aa22f06@yandex.ru> <83k010vta9.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17869"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: casouri@gmail.com, 60953-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 02 20:45:42 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pNfWf-0004TM-T0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Feb 2023 20:45:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pNfWO-0003BW-3N; Thu, 02 Feb 2023 14:45:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNfW3-00037i-1o for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 14:45:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pNfW2-0004Qi-PD for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 14:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pNfW2-0006uE-BX for bug-gnu-emacs@gnu.org; Thu, 02 Feb 2023 14:45:02 -0500 Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60953 X-GNU-PR-Package: emacs Mail-Followup-To: 60953@debbugs.gnu.org, dgutov@yandex.ru, dgutov@yandex.ru Original-Received: via spool by 60953-done@debbugs.gnu.org id=D60953.167536705926476 (code D ref 60953); Thu, 02 Feb 2023 19:45:02 +0000 Original-Received: (at 60953-done) by debbugs.gnu.org; 2 Feb 2023 19:44:19 +0000 Original-Received: from localhost ([127.0.0.1]:35827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNfVL-0006sx-5T for submit@debbugs.gnu.org; Thu, 02 Feb 2023 14:44:19 -0500 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:41816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNfVJ-0006si-OC for 60953-done@debbugs.gnu.org; Thu, 02 Feb 2023 14:44:18 -0500 Original-Received: by mail-ed1-f49.google.com with SMTP id v10so3149676edi.8 for <60953-done@debbugs.gnu.org>; Thu, 02 Feb 2023 11:44:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Fq5qh8NqQUDslGqwIkNTX3xguLCXYfXHgGHGyFDuE0k=; b=GviHsnf6003/V96FHRFux3XV0Hb1eVdfkDPp/fNgN4S/lTd+X8XT6rBtFDGgNmSosZ f/VE4ztRqL5HJfGPNpjEL5zkMHSVuozO8coXMjhvcufJEqtaopinUMDWuukZVPGCWl3l Cc6EETcZBg5M/xxjXlu1vTzP1084I9WQDicTtz092U4XgfVChB3EGgaL7JvENS1A5j8U 12csqPOiOJFpObBknT5TrAS4wjX6qgZ2IdS4zc/l4GCTIJg1xIAXao8yfya1z/rnIRfT MY+EX1Q3MKdGNObojomMNPcIZwlCrPAytCg7kLSOXKKuWIpedzKykL8GrB75HjZpNhUU uVLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fq5qh8NqQUDslGqwIkNTX3xguLCXYfXHgGHGyFDuE0k=; b=t8yCZAVz1MhWfMWQ/Ze+7rUmd4+yq1vVKYZRnrXOaaqKDjjhBly25+/2zJ5i7JLWpe YEPohitQJhHrtWQlcuYwkBJkGOnwJp+M2cUpvfKGG7Ky2il3pGAuH8YElbFe/3K15NmO SfF8xXHyz6MH677yUI7wl2AM4Za2+VgcbIFXvyguN2gQoBBC3k7GnGfouoTRODDukQGQ 5k7PH+EbVaozfMfNDJdmarjB0nxyI0JY1bNK0WXEx871pboo/UmiyYWE93DUaKw7V5Zz 8FC5nBYNM+Lta742eIEtraPwrMRV9ljb3CZ6jZ7qjHrd1arstqamJRFnMnNmOAFNhYRZ Z8CA== X-Gm-Message-State: AO0yUKVPavOAXkhpFHPwG6rsmDaA3xhzLGD9rXaxRVfI9i+/H7TMgYi6 hfNSCWGFB+31ATisXBQGjNc= X-Google-Smtp-Source: AK7set/TyUkAcammYIKt/4IjAowd0bKWoPj8/K/neFCaTDu4ftcBKqC0xUi4HN64RAvJnJo5OiHu3Q== X-Received: by 2002:a05:6402:254b:b0:4a0:aac4:1030 with SMTP id l11-20020a056402254b00b004a0aac41030mr9563086edb.28.1675367051876; Thu, 02 Feb 2023 11:44:11 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id b12-20020a056402350c00b0049e210884dasm146210edd.15.2023.02.02.11.44.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 11:44:11 -0800 (PST) Content-Language: en-US In-Reply-To: <83k010vta9.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254688 Archived-At: On 02/02/2023 20:03, Eli Zaretskii wrote: >> Date: Thu, 2 Feb 2023 19:53:07 +0200 >> Cc:casouri@gmail.com,60953@debbugs.gnu.org >> From: Dmitry Gutov >> >>> If the search fails, search_buffer returns a non-positive integer, not >>> zero. >> That should work too. As long as it never returns 0 for success. >> >> Which seems to be confirmed by the check >> >> if (np <= 0) >> ... signal error >> >> inside search_command. > Yes, because buffer position can never be zero. All right. Now pushed; thanks, and closing.