From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gregory Heytings Newsgroups: gmane.emacs.bugs Subject: bug#57499: Documentation bug in the docstring of set-face-attribute? Date: Fri, 02 Sep 2022 20:48:06 +0000 Message-ID: <2f302d1c39d400336ae6@heytings.org> References: <534c9018d2adffda3e53@heytings.org> <831qswu0p4.fsf@gnu.org> <534c9018d2f372cd7462@heytings.org> <83tu5ssi35.fsf@gnu.org> <534c9018d222586a161c@heytings.org> <83r10wsgu8.fsf@gnu.org> <534c9018d2952b7a6bd0@heytings.org> <83pmggs89x.fsf@gnu.org> <534c9018d2597d4fd752@heytings.org> <83fshcrzth.fsf@gnu.org> <534c9018d2c911550778@heytings.org> <83czcgry5f.fsf@gnu.org> <534c9018d2f901e88b93@heytings.org> <837d2nshh7.fsf@gnu.org> <834jxrscu7.fsf@gnu.org> <831qsvs51j.fsf@gnu.org> <83sflbqotm.fsf@gnu.org> <83r10vqh29.fsf@gnu.org> <83k06nq7es.fsf@gnu.org> <834jxppy0v.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset=us-ascii Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1646"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57499-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 02 22:49:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oUDbE-0000Dy-7c for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Sep 2022 22:49:12 +0200 Original-Received: from localhost ([::1]:60642 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oUDbD-00087S-1W for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Sep 2022 16:49:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58398) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oUDb5-00087F-0U for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2022 16:49:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oUDb4-0002Hh-Nb for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2022 16:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oUDb4-00069S-6E for bug-gnu-emacs@gnu.org; Fri, 02 Sep 2022 16:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Gregory Heytings Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Sep 2022 20:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57499 X-GNU-PR-Package: emacs Original-Received: via spool by 57499-done@debbugs.gnu.org id=D57499.166215169123551 (code D ref 57499); Fri, 02 Sep 2022 20:49:02 +0000 Original-Received: (at 57499-done) by debbugs.gnu.org; 2 Sep 2022 20:48:11 +0000 Original-Received: from localhost ([127.0.0.1]:40485 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUDaE-00067k-UP for submit@debbugs.gnu.org; Fri, 02 Sep 2022 16:48:11 -0400 Original-Received: from heytings.org ([95.142.160.155]:52200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oUDaC-00067J-Mc for 57499-done@debbugs.gnu.org; Fri, 02 Sep 2022 16:48:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heytings.org; s=20220101; t=1662151687; bh=2YDBUsVOgTr9bn+lFkN1TCevJV2T+/eMgG6yWOCASYU=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:From; b=ARY2KmpgF7Ax6j/y5fHI5sfidvB2+QtJdWKGXUtvFeAdxc+of0c8SSsygVoNJsvLO AX97FEfNj3jHL/ZW2u+gPZ2vcunkjdPtJB/zYvCfWrLBkUjWsuXs8LGITnbpxCMkP3 uJ9nuuuY2oEnxFsgf5CucB7jU9FHA2Lva08ddIfYeJFUhyz6TVrq4IhC9cAC/yTb2t Z54pdCpbEDPdqoIRCA1bhhlFsrB0eEYpf7gf4HFNCzb3ZEIRo3Op1UwNIwkJCiZIbk 1my9PI2Q9GXYevgZXMivu49iJDa/0Pk9VF4XSJKhxk8iX1340+0G7A6jwcAqV55y2D mB7sFn7Rz4Q+Q== In-Reply-To: <834jxppy0v.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241355 Archived-At: >> Should this go to master or to emacs-28? > > To master, please. > Thanks, now done. A last suggestion: I think the docstring of set-face-attribute would be even clearer with call this function with FRAME set to t or nil, and the ATTRIBUTE's value set to `unspecified'. or with call this function with FRAME set to t (or nil), and the ATTRIBUTE's value set to `unspecified'. Just as a reminder that nil "implies" t.