From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61051: treesit-install-language-grammar can provide the default repository URL Date: Wed, 25 Jan 2023 16:00:48 +0200 Message-ID: <2ede0353-6699-1196-df9e-2e4317e9ef36@yandex.ru> References: <08ecae1f-f937-f0c9-3272-d60f7632be99@yandex.ru> <83y1pqg5lh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28804"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 61051@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 25 15:02:48 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pKgMQ-0007F2-Sc for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 25 Jan 2023 15:02:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKgLo-0004Yf-9k; Wed, 25 Jan 2023 09:02:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKgLj-0004YC-Cw for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 09:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKgLi-0002ye-U4 for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 09:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pKgLi-0000a7-EY for bug-gnu-emacs@gnu.org; Wed, 25 Jan 2023 09:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 14:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61051 X-GNU-PR-Package: emacs Original-Received: via spool by 61051-submit@debbugs.gnu.org id=B61051.16746552622133 (code B ref 61051); Wed, 25 Jan 2023 14:02:02 +0000 Original-Received: (at 61051) by debbugs.gnu.org; 25 Jan 2023 14:01:02 +0000 Original-Received: from localhost ([127.0.0.1]:58660 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKgKj-0000YG-L3 for submit@debbugs.gnu.org; Wed, 25 Jan 2023 09:01:01 -0500 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:36536) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKgKg-0000Xk-0V for 61051@debbugs.gnu.org; Wed, 25 Jan 2023 09:01:00 -0500 Original-Received: by mail-wr1-f48.google.com with SMTP id b7so17162982wrt.3 for <61051@debbugs.gnu.org>; Wed, 25 Jan 2023 06:00:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=cfB6I2vv9rWHVEPgK7ZUT6GtVwJ6f5y3aIAz6rUyn+A=; b=oK9w0oY1f5a1kCT9NpPxqKRPTpiBgDYyvTGMrdHZ4ApkNtqvEU+uCgnSIbNAFsKZTs yFDMWiNE53YkO2yYD8GZy8S8HEg/xhcSONvSyPSBS4WXhVi8cJ+EXZBNuVczK/khYmRh iQyBjUEKKRoBLSFJBju0rkCamYXPT812+CoBQBYeVYclc8Oc5GKQWn9sNIoTZBCDy9tB hQdEsrl62CrT5tFfopvM2JBK6A0mxlUju50uUh02BAsNwmdjckI2uLfiOx+/1BfPHJQS f+DFaljzLtEbkvV16cIVn2ocjYSU6ROP8Vm0vAeW/ORf3IB4mmkQhZIbvQedVNcnX7uH lFQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cfB6I2vv9rWHVEPgK7ZUT6GtVwJ6f5y3aIAz6rUyn+A=; b=CONakHmg4fxr67KzCKZU6gGr+JIjdrN4Kku+NQPdkDswvU0PETMML10t1Kcv9UYLH3 IRKmCYGVDDMHKweTi+MqbFnbcv2ZQLmQsK8ADr27WDWdovdwoXpKMP1xIggduAwOfz+D OqkZmYN5Iz6R0HlAeypICCALGuSVVQL69J6bIbjt7dYMyEoCAQQ8PCG9g2OyCP+Ia+MD CBGoQrz+bQYaViNQ9V8e43T0J1V2EX+jQxrM/aHFQo/ibK59lpPdSL6twXvLVUuYIbKH POceNLrlBhG37vF69mrcgyPpk5DmkRnBdNps3moU/zb4e1bpNjueNRDZVDyPiRZKvtvg /67A== X-Gm-Message-State: AFqh2krvkQvDZhni4J4NTPjrwrFlYqurLD+kFvVRh3GLka7jmD302qo2 viXAyIZwMPLXV0qx9RLkrvw= X-Google-Smtp-Source: AMrXdXu1q0Bkbnnk8rlaWDddorTRs9+ehKtGQ3CX+cTegQSEtSPevMirG8hRARIGw2CqcHY+Lfoizw== X-Received: by 2002:a5d:6581:0:b0:2bb:dad4:9525 with SMTP id q1-20020a5d6581000000b002bbdad49525mr26557961wru.10.1674655251574; Wed, 25 Jan 2023 06:00:51 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id q6-20020adfcd86000000b002bded7da2b8sm4567191wrj.102.2023.01.25.06.00.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 06:00:50 -0800 (PST) Content-Language: en-US In-Reply-To: <83y1pqg5lh.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254134 Archived-At: On 25/01/2023 14:29, Eli Zaretskii wrote: >> Date: Wed, 25 Jan 2023 05:23:37 +0200 >> From: Dmitry Gutov >> >> The formathttps://github.com/tree-sitter/tree-sitter-%s will work for a >> lot of languages, and the user won't even have to search for the address. >> >> The patch can look like this: >> >> diff --git a/lisp/treesit.el b/lisp/treesit.el >> index 660039cc7cc..c1b98d085e8 100644 >> --- a/lisp/treesit.el >> +++ b/lisp/treesit.el >> @@ -2708,7 +2708,8 @@ treesit--install-language-grammar-build-recipe >> (list >> lang >> (read-string >> - "Enter the URL of the Git repository of the language grammar: ") >> + "Enter the URL of the Git repository of the language grammar: " >> + (format"https://github.com/tree-sitter/tree-sitter-%s" lang)) >> (empty-string-to-nil >> (read-string >> "Enter the tag or branch (default: default branch): ")) > Sounds good, but wouldn't we confuse users in those cases where the > Tree-sitter site doesn't have a grammar? Would it be perhaps feasible > to probe first that a Git repository at the URL exists? Sure, how about this: diff --git a/lisp/treesit.el b/lisp/treesit.el index 660039cc7cc..4c9bdfc0bd4 100644 --- a/lisp/treesit.el +++ b/lisp/treesit.el @@ -2707,8 +2707,10 @@ treesit--install-language-grammar-build-recipe (if (equal string "") nil string))) (list lang - (read-string - "Enter the URL of the Git repository of the language grammar: ") + (let ((repo-default (format "https://github.com/tree-sitter/tree-sitter-%s" lang))) + (read-string + "Enter the URL of the Git repository of the language grammar: " + (and (treesit--check-repo-url repo-default) repo-default))) (empty-string-to-nil (read-string "Enter the tag or branch (default: default branch): ")) @@ -2722,6 +2724,16 @@ treesit--install-language-grammar-build-recipe (read-string "Enter the C++ compiler to use (default: auto-detect): ")))))) +(defun treesit--check-repo-url (url) + (defvar url-request-method) + (let ((url-request-method "HEAD")) + (let ((buffer (condition-case nil (url-retrieve-synchronously url t t) + (file-error nil)))) + (and buffer + (eql + (buffer-local-value 'url-http-response-status buffer) + 200))))) + ;;;###autoload (defun treesit-install-language-grammar (lang) "Build and install the tree-sitter language grammar library for LANG.