From: Van Ly <van.ly@sdf.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 52918@debbugs.gnu.org
Subject: bug#52918: 29.0.50; to make use of ucd/Unihan_Readings.txt for kDefinition entry
Date: Sun, 23 Jan 2022 11:22:03 +0000 (UTC) [thread overview]
Message-ID: <2ebddb2d-9f32-9a5f-5971-7e1c58fceba5@SDF.ORG> (raw)
In-Reply-To: <83v8ybkn4u.fsf@gnu.org>
On Sun, 23 Jan 2022, Eli Zaretskii wrote:
>>>
>>> Patches welcome.
>>>
>>
>> See patch attached.
>>
>> Two of the three implementation steps suggested are done.
>
> Thanks.
>
> You don't seem to have copyright assignment on file, and without that
> we cannot accept such large contributions. Would you like to start
> your legal paperwork now? If so, I will send you the form and the
> instructions.
>
I sent an email to assign@gnu.org in the 24hr before this patch was
submitted. I was hoping this patch would fall below the 15 line
limit and not need the formality of the legal paperwork. The minor
mode contribution would climb above the limit, which was why I sent
the request to assign copyright. Best case is a 2 week wait.
That generated uni-unihan-readings.el will need a line as follows:
diff --git a/admin/unidata/Unihan_Readings.awk
b/admin/unidata/Unihan_Readings.awk
index cf319449e59..f01c75b88f9 100644
--- a/admin/unidata/Unihan_Readings.awk
+++ b/admin/unidata/Unihan_Readings.awk
@@ -1,5 +1,6 @@
BEGIN {
FS=" "
+ printf(";; -*-no-byte-compile: t; -*-\n")
printf("(defvar readings-table\n\
(make-char-table 'readings-table nil)\n\
\"Char table of definitions for East Asian characters.\")\n")
--
vl
next prev parent reply other threads:[~2022-01-23 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-31 17:55 bug#52918: 29.0.50; to make use of ucd/Unihan_Readings.txt for kDefinition entry Van Ly
2022-01-03 13:54 ` Eli Zaretskii
2022-01-04 15:13 ` Van Ly
2022-01-17 18:25 ` Van Ly
2022-01-18 11:30 ` Van Ly
[not found] ` <Pine.NEB.4.64.2201230208400.10119@faeroes.freeshell.org>
2022-01-23 6:00 ` Eli Zaretskii
2022-01-23 11:22 ` Van Ly [this message]
2022-01-23 11:40 ` Eli Zaretskii
2023-07-25 15:44 ` Eli Zaretskii
2023-07-25 18:18 ` Van Ly via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ebddb2d-9f32-9a5f-5971-7e1c58fceba5@SDF.ORG \
--to=van.ly@sdf.org \
--cc=52918@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).