From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations Date: Tue, 16 May 2023 08:19:52 +0200 Message-ID: <2eb987c6-0aec-55df-db4e-ef95557ab809@daniel-mendler.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22319"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , Stefan Monnier , 61283@debbugs.gnu.org To: Liu Hui Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 16 08:21:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pyo3n-0005Z3-Gi for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 May 2023 08:21:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pyo3V-0006If-8Y; Tue, 16 May 2023 02:21:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyo3S-0006G7-NY for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 02:21:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pyo3S-0002FB-En for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 02:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pyo3R-000698-PP for bug-gnu-emacs@gnu.org; Tue, 16 May 2023 02:21:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2023 06:21:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61283 X-GNU-PR-Package: emacs Original-Received: via spool by 61283-submit@debbugs.gnu.org id=B61283.168421800523511 (code B ref 61283); Tue, 16 May 2023 06:21:01 +0000 Original-Received: (at 61283) by debbugs.gnu.org; 16 May 2023 06:20:05 +0000 Original-Received: from localhost ([127.0.0.1]:45031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyo2X-000679-1h for submit@debbugs.gnu.org; Tue, 16 May 2023 02:20:05 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:34483 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyo2S-00066O-O1 for 61283@debbugs.gnu.org; Tue, 16 May 2023 02:20:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=XKQaOk9tidB9CXviOBCdX1V6OWwRfmF3hicEvfz2kDw=; b=hbxnKetVLoyz8G9At8+puwiABs +P3DWEDO4MJgwFB3Xzh1N02lFZpTldEz95jV9X2JwyXVjT9Ql4a6/ybig3GSGYhUPqOT6zO4iPczV mybd3keadx/HhLJzN4X9Txeo0faHw/SptcZfxbdrVF0vQNIR4rkfiSA6D9wGdV2WomvQ=; Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261773 Archived-At: On 5/16/23 03:49, Liu Hui wrote: > I agree that completion-table-with-quoting is responsible. > pcomplete-annotation and pcomplete-help text properties can be > successfully shown by the completion UI (corfu/company) by applying > the following patch: > > It just re-adds text properties to completions produced by > `completion-table-with-quoting', but I'm not sure it is the proper > fix. What do you think? I wonder when the regression was introduced. Maybe this could help to pin down the problem and give a hint at the proper fix. I cc'ed Stefan, since he can judge better if the proposed fix is good. I would at least add a comment, explaining why the properties are copied. Eli, are you okay with adding a fix for this problem to emacs-29? The pcomplete help functionality is new functionality introduced in Emacs 29, but it never worked properly, it seems. Daniel