From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Max Nikulin Newsgroups: gmane.emacs.bugs Subject: bug#62762: 'make' often errors with "Org version mismatch" after pulling a new version of the code Date: Wed, 10 May 2023 21:52:46 +0700 Message-ID: <2e6ea8c1-19fb-298a-1336-27b09925d8a0@gmail.com> References: <17b74a48-94e1-9106-cc79-d31972313910@gutov.dev> <87wn2ilwed.fsf@localhost> <83zg7ealrd.fsf@gnu.org> <87pm8a8dx4.fsf@localhost> <87pm7vt0mx.fsf@localhost> <87cz3k8i27.fsf@localhost> <87sfcfdldt.fsf@localhost> <87bkj1g10g.fsf@localhost> <1c5d0ff0-5bae-1123-d2f7-64d9013fbc0f@gmail.com> <6070e598-7dee-1b7a-7f97-26a90618cb7a@gmail.com> <5603ba14-8120-cf38-05ba-4435c1bece3f@gmail.com> <03d0e4f4-3855-fa3e-d502-bee77ea53b74@gmail.com> <875y93kujy.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23022"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: 62762@debbugs.gnu.org, bzg@gnu.org, dmitry@gutov.dev, Stefan Monnier , Alan Mackenzie , Eli Zaretskii To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 10 16:53:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pwlBq-0005lw-4K for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 May 2023 16:53:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pwlBf-0001LQ-Nm; Wed, 10 May 2023 10:53:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pwlBe-0001Kv-4o for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 10:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pwlBd-0006c0-Tj for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 10:53:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pwlBd-0000AN-Oo for bug-gnu-emacs@gnu.org; Wed, 10 May 2023 10:53:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Max Nikulin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 May 2023 14:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62762 X-GNU-PR-Package: emacs Original-Received: via spool by 62762-submit@debbugs.gnu.org id=B62762.1683730379629 (code B ref 62762); Wed, 10 May 2023 14:53:01 +0000 Original-Received: (at 62762) by debbugs.gnu.org; 10 May 2023 14:52:59 +0000 Original-Received: from localhost ([127.0.0.1]:48635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwlBa-0000A5-Mo for submit@debbugs.gnu.org; Wed, 10 May 2023 10:52:58 -0400 Original-Received: from mail-lf1-f51.google.com ([209.85.167.51]:55297) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pwlBX-00009p-9c for 62762@debbugs.gnu.org; Wed, 10 May 2023 10:52:57 -0400 Original-Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-4f1fe1208a4so5311048e87.2 for <62762@debbugs.gnu.org>; Wed, 10 May 2023 07:52:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1683730369; x=1686322369; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=U9Ej4FxPtnBJTLkyqoMH+A929Fygr8QKOUKY6EezfqQ=; b=q4y+X9ehseyHJjd6XSFcMuZ/nVWS7MI8sd9WkX+Rh7CsGt41IdZraKfeT3DbBvy+U6 vE1/Wz3zkqf0PGhB9ZWDijE4s5IaUBgCC+4BqxnU6CL3X0VnmwbNApN7iVYGealcCg8c PecW2RiUliEzBq+XsYFr0JAC1aALzq0KemHsHPbnqtDMmBCi6M/xzO9ps5TIUv4ukfwL ja89q6JXM8WJM//JOA0ICcJOm3eB3/XXEiBeI7G6v5mhmR4t5BPoMA+2zTjtOrjh7jnF lcSHIZENGbC217YcLWuygabMry1mcdF1HpCHkyG18EUGuuWO8UiqsvaN5SR7rwwGotvb bv4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683730369; x=1686322369; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U9Ej4FxPtnBJTLkyqoMH+A929Fygr8QKOUKY6EezfqQ=; b=H5rIBSk5ryTYN7qGMVjR7oHEGvhDEErtNDgO0wlOkOq0av6KprWKR8ReUzxYexN+cG iQhcpdWYuljL+taDZaJhZ/s4K6udVPJQ6Y1+n3Lvz+/2Qk0p1b708CnbZdBR583O8dB4 s/QuRyPBgy6tad3FKDJgWC6wqJOygrR8bCFwxp6ICgej0C6QErbpWo7c44hM6MIc1KHw /O4NaC1tmWS2X2l7Fw9H4BLKC4rZ3eyzmjn1SnqoeigWaxfNtCCoZKw0uFpoSeNv616n PLgacnHkImvNSDMO6LtGacLy7c6qJFKU7K+VANS3U44F2o2xFs4dw+xayibwMb/59rtE VbvA== X-Gm-Message-State: AC+VfDzvY272kSLSeP+GfEEEdbNzfGgJhyJ5l5xVJ+tgSv1nW0cqeds+ ZtILG9brJ6quejzjZp/KBTc= X-Google-Smtp-Source: ACHHUZ4ZNBfxV67bLmcVdsEtJlQDJZGpBFeIW6EhCFQ1rPUPqO+AGXXKvFDGJbLTCQFFuFSGQypb6A== X-Received: by 2002:ac2:5deb:0:b0:4f1:1de7:1aac with SMTP id z11-20020ac25deb000000b004f11de71aacmr2146251lfq.20.1683730368857; Wed, 10 May 2023 07:52:48 -0700 (PDT) Original-Received: from [192.168.0.101] (nat-0-0.nsk.sibset.net. [5.44.169.188]) by smtp.googlemail.com with ESMTPSA id c2-20020a197602000000b004d023090504sm756395lff.84.2023.05.10.07.52.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 May 2023 07:52:48 -0700 (PDT) Content-Language: en-US In-Reply-To: <875y93kujy.fsf@localhost> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261506 Archived-At: On 08/05/2023 17:05, Ihor Radchenko wrote: > Max Nikulin writes: >> (defun tst-assert-load-dir () >> (let ((dir (tst-get-load-dir)) >> (url "https://orgmode.org/worg/org-faq.html#mixed-install")) >> (unless (equal tst-load-dir dir) >> (error "Path shadowing detected, see <%s>. %s vs %s" >> url dir tst-load-dir)))) > > I think we can try to do the following: > > 1. Use the load-dir test, warn, and try to re-load > 2. Use org-assert-version, but downgrade error to simple warning Ihor, final decision is up to you. I think, `org-reload' may be recommended in a warning message. I am unsure if `org-reload' called from the assertion while an Org component is loaded may not cause a more severe issue. My special concern is reloading when new Org is being compiled: is it safe or reloading should be suppressed completely? I believe, during creation of .elc files, assert macro should signal an error since a warning is not enough to prevent loading mixed compilation result to next Emacs session. I do not like that currently during compiling with old Org loaded, `org-assert-version' causes just a warning. Users have difficulties with clean recompiling. While loading, non-fatal error may be a better option when versions do not differ too much. I like that you are not going to throw version check away completely.