From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#32230: 27.0.50; GCC 7 warning due to -Wformat-overflow Date: Fri, 20 Jul 2018 18:02:07 -0400 Message-ID: <2d9037f1-e52f-f3ca-7c53-e203ea6ae520@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1532124069 22838 195.159.176.226 (20 Jul 2018 22:01:09 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 20 Jul 2018 22:01:09 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: Paul Eggert To: 32230@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 21 00:01:05 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgdSS-0005p9-HE for geb-bug-gnu-emacs@m.gmane.org; Sat, 21 Jul 2018 00:01:04 +0200 Original-Received: from localhost ([::1]:49960 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgdUZ-0005M9-8A for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Jul 2018 18:03:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgdUP-0005Lv-IA for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:03:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgdUM-0000Fm-Fw for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:03:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45026) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fgdUM-0000Fe-Bc for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fgdUL-0000e7-MN; Fri, 20 Jul 2018 18:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: eggert@cs.ucla.edu, bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Jul 2018 22:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32230 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Paul Eggert Original-Received: via spool by submit@debbugs.gnu.org id=B.15321241432433 (code B ref -1); Fri, 20 Jul 2018 22:03:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 20 Jul 2018 22:02:23 +0000 Original-Received: from localhost ([127.0.0.1]:50043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgdTi-0000dB-O1 for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fgdTg-0000cv-E0 for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgdTa-0008JR-Ft for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:15 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:41514) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fgdTa-0008JL-Bs for submit@debbugs.gnu.org; Fri, 20 Jul 2018 18:02:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgdTZ-0005F2-Cd for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:02:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fgdTW-0008HX-Ar for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:02:13 -0400 Original-Received: from limerock02.mail.cornell.edu ([128.84.13.242]:52661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fgdTW-0008HJ-5V for bug-gnu-emacs@gnu.org; Fri, 20 Jul 2018 18:02:10 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w6KM28Rr002530 for ; Fri, 20 Jul 2018 18:02:09 -0400 Original-Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w6KM27vB017201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Fri, 20 Jul 2018 18:02:08 -0400 Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-MIME-Autoconverted: from 8bit to quoted-printable by limerock02.mail.cornell.edu id w6KM28Rr002530 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148753 Archived-At: The Cygwin-w32 build has turned up another GCC 7 warning: ../../master/src/w32term.c: In function =E2=80=98x_draw_glyph_string=E2=80= =99: ../../master/src/w32term.c:1477:27: warning: =E2=80=98__builtin___sprintf= _chk=E2=80=99=20 may write a terminating nul past the end of the destination=20 [-Wformat-overflow=3D] sprintf ((char *) buf, "%0*X", ^ ../../master/src/w32term.c:1477:4: note: =E2=80=98__builtin___sprintf_chk= =E2=80=99=20 output between 5 and 8 bytes into a destination of size 7 sprintf ((char *) buf, "%0*X", ^ The method that Paul used in bug#32189 could be used here too, but I'm not sure it's worth the trouble. My inclination is to just increase the buffer size from 7 to 8. Ken