* bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash'
@ 2018-11-10 19:12 Drew Adams
2018-11-10 20:18 ` Eli Zaretskii
0 siblings, 1 reply; 2+ messages in thread
From: Drew Adams @ 2018-11-10 19:12 UTC (permalink / raw)
To: 33335
Both of these doc strings seem to say that if function
`system-move-file-to-trash' is defined then it is used, regardless of
the value of option `trash-directory'.
A cursory look at the code defining `move-file-to-trash' suggests
otherwise. And that would seem to make sense, giving users a way
to customize the directory in all cases.
Are the doc strings wrong, or am I misreading the code?
(cond (trash-directory
;; If `trash-directory' is non-nil, move the file there.
...)
;; If `system-move-file-to-trash' is defined, use it.
((fboundp 'system-move-file-to-trash)
(system-move-file-to-trash filename))
...)
In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
of 2018-05-30
Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea
Windowing system distributor `Microsoft Corp.', version 10.0.16299
Configured using:
`configure --without-dbus --host=x86_64-w64-mingw32
--without-compress-install 'CFLAGS=-O2 -static -g3''
^ permalink raw reply [flat|nested] 2+ messages in thread* bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash'
2018-11-10 19:12 bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash' Drew Adams
@ 2018-11-10 20:18 ` Eli Zaretskii
0 siblings, 0 replies; 2+ messages in thread
From: Eli Zaretskii @ 2018-11-10 20:18 UTC (permalink / raw)
To: Drew Adams; +Cc: 33335-done
> Date: Sat, 10 Nov 2018 11:12:40 -0800 (PST)
> From: Drew Adams <drew.adams@oracle.com>
>
> Both of these doc strings seem to say that if function
> `system-move-file-to-trash' is defined then it is used, regardless of
> the value of option `trash-directory'.
>
> A cursory look at the code defining `move-file-to-trash' suggests
> otherwise. And that would seem to make sense, giving users a way
> to customize the directory in all cases.
>
> Are the doc strings wrong, or am I misreading the code?
It's a (subtle) bug, which I just fixed.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-10 20:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-10 19:12 bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash' Drew Adams
2018-11-10 20:18 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).