unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: 33335@debbugs.gnu.org
Subject: bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash'
Date: Sat, 10 Nov 2018 11:12:40 -0800 (PST)	[thread overview]
Message-ID: <2d3e93b9-5fd4-418f-afe5-b14df2476fe6@default> (raw)

Both of these doc strings seem to say that if function
`system-move-file-to-trash' is defined then it is used, regardless of
the value of option `trash-directory'.

A cursory look at the code defining `move-file-to-trash' suggests
otherwise.  And that would seem to make sense, giving users a way
to customize the directory in all cases.

Are the doc strings wrong, or am I misreading the code?

(cond (trash-directory
       ;; If `trash-directory' is non-nil, move the file there.
       ...)
      ;; If `system-move-file-to-trash' is defined, use it.
      ((fboundp 'system-move-file-to-trash)
       (system-move-file-to-trash filename))
      ...)


In GNU Emacs 26.1 (build 1, x86_64-w64-mingw32)
 of 2018-05-30
Repository revision: 07f8f9bc5a51f5aa94eb099f3e15fbe0c20ea1ea
Windowing system distributor `Microsoft Corp.', version 10.0.16299
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''





             reply	other threads:[~2018-11-10 19:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-10 19:12 Drew Adams [this message]
2018-11-10 20:18 ` bug#33335: 26; Doc strings of `trash-directory' and `move-file-to-trash' Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d3e93b9-5fd4-418f-afe5-b14df2476fe6@default \
    --to=drew.adams@oracle.com \
    --cc=33335@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).