From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#45620: 28.0.50; Child frames should have their own border width and colour Date: Tue, 5 Jan 2021 16:33:05 +0100 Message-ID: <2d182c2b-36a1-4dba-431a-2945cc54d2f0@gmx.at> References: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5260"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45620@debbugs.gnu.org, tumashu@163.com To: Alexander Miller Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 05 16:34:15 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kwoLe-0001FI-Ve for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jan 2021 16:34:14 +0100 Original-Received: from localhost ([::1]:59612 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kwoLe-0005J8-0j for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jan 2021 10:34:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33014) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kwoLS-0005Hm-JV for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2021 10:34:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59140) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kwoLS-0005lR-CA for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2021 10:34:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kwoLS-0000Lu-9h for bug-gnu-emacs@gnu.org; Tue, 05 Jan 2021 10:34:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jan 2021 15:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45620 X-GNU-PR-Package: emacs Original-Received: via spool by 45620-submit@debbugs.gnu.org id=B45620.16098608031310 (code B ref 45620); Tue, 05 Jan 2021 15:34:02 +0000 Original-Received: (at 45620) by debbugs.gnu.org; 5 Jan 2021 15:33:23 +0000 Original-Received: from localhost ([127.0.0.1]:42453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwoKp-0000L4-EV for submit@debbugs.gnu.org; Tue, 05 Jan 2021 10:33:23 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:37727) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kwoKo-0000Kq-C4 for 45620@debbugs.gnu.org; Tue, 05 Jan 2021 10:33:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1609860786; bh=yoJhMiVxaqMjSZVFhQ9fV/wApLG9e12HMj3E7cxYRGM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=ZppFXxW/vc9oL01PEVcRFWHL+ZBS4tm4YvE0AiuAAam3PTkxRbJ5BCd09wNAijBAw qI4yLurPpM9AY7bFuwxFLH4stFshdpXwTlzULR+KzE5WY+VJqkujISOjUhl5C66S2W ZPG2H1OKJa6exCiz4mT+SMSPdvOBa82aqp1MoTBc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.231]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mof9P-1kCoOJ2ovp-00p4dK; Tue, 05 Jan 2021 16:33:06 +0100 In-Reply-To: <2c70983d-947c-c8ce-731c-ab804642ded2@web.de> Content-Language: en-US X-Provags-ID: V03:K1:5aqltkapmNh0T6Drq0VQS9gRUj2/eL2sNKS/vOPqPSq/SBha0+o PdfYG5FDlnGz+IvnseM7x8ybQ2nzq7eGpChYtk1aSXUTfpmjbQbnMwIeoq0Wp4j3Ib861Wm YYKJwTy02eXdLrBwaFycACznTH2LpLKXEsm/8TBWCBzjN84QrQD816+2QNn0duzl95qEKad E0cljIfOq43UFqfD8e7Zw== X-UI-Out-Filterresults: notjunk:1;V03:K0:pkJLkkm0Fr0=:Ay/Qhs6qpVol9LQzADSVaE segk7qSAf6QAYfICjukbk1ed66CTmL9BZle92vDRCG2/KZrT+FreatRnVv8uReELMct99CeQ/ iTWSuwJVmkSaL/ZpXB2ok8P7FyNIxNF2xfhM5n4O0qx/cQCrBw6E8mCjSAP8X03IZMZK45roQ 1eyeHPmbiAanLC+eYtYnFKB1dqI8e1HlhZtXc95T2px5jpE58SGecK710ARO7S5uBdQm8DDo8 oWLEBSZrx2HmB+n1V144GGlCWLqu9NKW7b44biCCYsER2aC3g3XHHLe9DOVAdZb4Aa8p3QD+r 0O5Ve2V9FXixj4tiFh6erQJ1s+AcGjAumbRA3EWexB1X2+6cuyuUyL2mj15CnmGYfhooDXNc0 aKqAL1aKdG+oaL83exMV1xPBzZp0gqU6smiPmuoyxVA4AvtAE4xtiXEramdistPrEPB9e3T2F 58bA2lQ6Uk9udF73B1u9sV/R9WgBS2aMySImCTKlrWot3lPi8nwXxn6MA/N5W9skVTNEzYKn1 z/QNuvp/b0wsFb5foJsN9ELedlB200Q8s1tDQO7RTVh8G5fCa2D2rvDPPYiEBhKwbelFhKlzV yar3/ELw1JLW84CANL5LrxEp/8idDr5WpeDvLCxkpZHrJur+HNtehGwMjSN8g2o7Hg2r1E6R0 xHbeUwRBFO8i4AvaTrRE+CnnuS2mo6FsOYH7ML3IDXiZJDxYL24kuFTpjnxPd3NQnDhjZM9fu 7fMUjIkToMGIYS0hOVDBKOtmlKzQU0xVckNjhd1u0GD0OiP/AusoeqmZ/TzvW63w3mV+s0zN X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197382 Archived-At: > To be honest I've don't really like C as a language, and learning it > would not do anything professionally for me either. So I'm jumping into > this strictly for the sake of improving Emacs. Then please jump into this as often as you want. > x, ns and w32 all used the same code, so I changed them all to look like > this now. OK. I think a main reason that we usually do not factor out code in these is that only one of them gets compiled in anyway - so we just save an extra call. > >> - Currently the actual width of the border is still controlled by the > >> `internal-border-width` parameter for both frame types. Should I try to > >> do something about that as well? If yes, what's my entry point? > > > > Add a 'child-frame-border-width' parameter. But in this case I would > > propose to proceed as follows: > > > > - If for a frame the 'child-frame-border-width' was explicitly set, use > > it. > > > > - If it was not set, use the 'internal-border-width' parameter. > > That's done now too, at least for X. I'll attach patches of my first > working drafts for both changes. Let me know if I'm on the right path so > far. You're already at the end of it. Please document the changes in the Elisp manual and announce them as (probably incompatible) changes in NEWS. > >> - I think I'll need to sign the FSF copyright assignment, unless the > >> limit is higher than the 15 lines I am remembering. > > > > I think so too. > > > > Ok, what do I do? Eli, can you send Arthur the forms please? Thanks, martin