unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#21601: 25.0.50; (elisp) `Common Keywords', :group
@ 2015-10-01 17:53 Drew Adams
  2016-04-30 22:21 ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2015-10-01 17:53 UTC (permalink / raw)
  To: 21601

Mention here, in the part about :group, and not just in node `Variable
Definitions', that if :group is not specified then the defcustom
inherits the group from the last :group of a preceding defcustom in the
same file.

Someone looking for info about :group will look here.  This is
specifically about :group.



In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
 of 2015-09-23
Bzr revision: 325200ac1dcf5bed6918ea827d8a48d89487e083
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --host=i686-pc-mingw32 --enable-checking=yes,glyphs'





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#21601: 25.0.50; (elisp) `Common Keywords', :group
  2015-10-01 17:53 bug#21601: 25.0.50; (elisp) `Common Keywords', :group Drew Adams
@ 2016-04-30 22:21 ` Lars Ingebrigtsen
  2016-05-01  1:15   ` Drew Adams
  0 siblings, 1 reply; 4+ messages in thread
From: Lars Ingebrigtsen @ 2016-04-30 22:21 UTC (permalink / raw)
  To: Drew Adams; +Cc: 21601

Drew Adams <drew.adams@oracle.com> writes:

> Mention here, in the part about :group, and not just in node `Variable
> Definitions', that if :group is not specified then the defcustom
> inherits the group from the last :group of a preceding defcustom in the
> same file.

I did now know that.  But is that something we want to encourage?  

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#21601: 25.0.50; (elisp) `Common Keywords', :group
  2016-04-30 22:21 ` Lars Ingebrigtsen
@ 2016-05-01  1:15   ` Drew Adams
  2016-05-02 22:03     ` Lars Ingebrigtsen
  0 siblings, 1 reply; 4+ messages in thread
From: Drew Adams @ 2016-05-01  1:15 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: 21601

> > Mention here, in the part about :group, and not just in node `Variable
> > Definitions', that if :group is not specified then the defcustom
> > inherits the group from the last :group of a preceding defcustom in the
> > same file.
> 
> I did now know that.  But is that something we want to encourage?

It's not something that I think should be encouraged.
But it is something that Stefan encourages.  And he
actively removes :group declarations that are not
strictly necessary.

As long as that is the practice, so that many defcustoms
and deffaces do not have :group (and that is increasingly
the case, for distributed Emacs code, at least), we should
document the behavior (IMHO).





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#21601: 25.0.50; (elisp) `Common Keywords', :group
  2016-05-01  1:15   ` Drew Adams
@ 2016-05-02 22:03     ` Lars Ingebrigtsen
  0 siblings, 0 replies; 4+ messages in thread
From: Lars Ingebrigtsen @ 2016-05-02 22:03 UTC (permalink / raw)
  To: Drew Adams; +Cc: 21601

Drew Adams <drew.adams@oracle.com> writes:

>> > Mention here, in the part about :group, and not just in node `Variable
>> > Definitions', that if :group is not specified then the defcustom
>> > inherits the group from the last :group of a preceding defcustom in the
>> > same file.
>> 
>> I did now know that.  But is that something we want to encourage?
>
> It's not something that I think should be encouraged.
> But it is something that Stefan encourages.  And he
> actively removes :group declarations that are not
> strictly necessary.
>
> As long as that is the practice, so that many defcustoms
> and deffaces do not have :group (and that is increasingly
> the case, for distributed Emacs code, at least), we should
> document the behavior (IMHO).

I agree.  I've now mentioned this in the emacs-25 manual.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-05-02 22:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-01 17:53 bug#21601: 25.0.50; (elisp) `Common Keywords', :group Drew Adams
2016-04-30 22:21 ` Lars Ingebrigtsen
2016-05-01  1:15   ` Drew Adams
2016-05-02 22:03     ` Lars Ingebrigtsen

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).