From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#51426: 29.0.50; [PATCH] Should 'comint-term-environment' be connection-aware? Date: Wed, 27 Oct 2021 17:45:53 -0700 Message-ID: <2c3dffbc-9af0-f318-15bc-cce91a106898@gmail.com> References: <69264ece-bb7f-4db1-f461-dacd33db2402@gmail.com> <87cznqev5g.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------272430E9BFBF6E422D1F2B94" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11040"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51426@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 28 02:47:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mftZX-0002jK-Dg for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 28 Oct 2021 02:47:11 +0200 Original-Received: from localhost ([::1]:47466 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mftZV-0005vl-U0 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 27 Oct 2021 20:47:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41796) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mftZO-0005vL-LH for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 20:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39337) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mftZO-0004zh-BJ for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 20:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mftZN-0000jh-Ta for bug-gnu-emacs@gnu.org; Wed, 27 Oct 2021 20:47:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 28 Oct 2021 00:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51426 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51426-submit@debbugs.gnu.org id=B51426.16353819642731 (code B ref 51426); Thu, 28 Oct 2021 00:47:01 +0000 Original-Received: (at 51426) by debbugs.gnu.org; 28 Oct 2021 00:46:04 +0000 Original-Received: from localhost ([127.0.0.1]:50880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mftYS-0000hy-D7 for submit@debbugs.gnu.org; Wed, 27 Oct 2021 20:46:04 -0400 Original-Received: from mail-pl1-f170.google.com ([209.85.214.170]:34814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mftYO-0000hD-Jo for 51426@debbugs.gnu.org; Wed, 27 Oct 2021 20:46:03 -0400 Original-Received: by mail-pl1-f170.google.com with SMTP id r5so3246553pls.1 for <51426@debbugs.gnu.org>; Wed, 27 Oct 2021 17:46:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-language; bh=69e5CyR8ltnDSA/hqEA06LvpHoVJSDBazwH5WCpdiuw=; b=jlDQsB1V1cdB8mHCRIVrGr/yv7ViKFTgbd3edI8VGtPCsPc6JzAXyg4V0LNtogFr2h C27e1yq9vQ698p0+8Yz4MMK0EWakv2oWtv8OMiQ6rMWSi7JgqZBNupe1ztL0DACF5vdg OwsGgEnb7RIiT/GBrPYumFrrUGQH0NCLM/0hB19qPn57b4HHoA0A49UPiw+i1yaZv5Nu yEgYjsYYhG5vPF3ueZmZ6uoOfHKmaCAqqZ4asVRd45+H4l9UHEFdLHtxzbB9NlfDwmst RTh/29aWoGSGoXJggVmQAAXGSx/Mvdr2pdckbPA/NagNq5qD8Kh1qBx4kcsHpHidEEg2 T+aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :mime-version:in-reply-to:content-language; bh=69e5CyR8ltnDSA/hqEA06LvpHoVJSDBazwH5WCpdiuw=; b=2r6SdXJtMOlYObMrAy+UGzfgtJpRbLdVNBgLG8P7edG8Aww9OFreiG7r3wj56PbFk2 cCWTOcW06oHUig3o1JJJZLAfGh2bw8DGgrQKdQLuLd/h2L+ikJt48/FnPM4Q4DEwoiVo jM8PEcMDKhFV4QsDaFIpuVQovuQEErJvDeeTZ/xmdesEAxot4tKQgRL5iSYUhWLzj/N3 wAoKrJAm54ndgJVYrfCYLtR4OEZJYyPE4WLdUflqj7DnQkSD4VCXK9Yytwbn5IifbzC7 8cu8mUBvRtwfTsGwqmbR0Y2+XYTe78OTyibvf9AUvSnjQUFBInYk1/qFgBRQjaSlwPu3 +V0g== X-Gm-Message-State: AOAM531L/ugbb/mdKXFHwONMwc6KNU91mXM2LaKLI/mM3aLNznq2Wn18 PC94ue7loP2Fy+vK+4iuhDWpGqQ8ysY= X-Google-Smtp-Source: ABdhPJzW2U5Rd0yw45svQXAyT9JUoH3QjBEsSrXTTG+ZeLgRtROUNOT0DWIRN4zO4yq63tv+xUnUhg== X-Received: by 2002:a17:902:8549:b0:141:6804:5fb7 with SMTP id d9-20020a170902854900b0014168045fb7mr997243plo.39.1635381954724; Wed, 27 Oct 2021 17:45:54 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id k14sm845351pga.65.2021.10.27.17.45.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Oct 2021 17:45:53 -0700 (PDT) In-Reply-To: <87cznqev5g.fsf@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218480 Archived-At: This is a multi-part message in MIME format. --------------272430E9BFBF6E422D1F2B94 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 10/27/2021 1:20 AM, Michael Albinus wrote: > Looks good to me. However, this technique must be documented > anywhere. Likely in the Emacs manual, node "Shell Options" > (file doc/emacs/misc.texi). Thanks. I've expanded the section about `comint-terminfo-terminal' in the manual to include information about how `system-uses-terminfo' works as well as mentioning that these variables can be declared as connection-local. > Yes, it should be said in etc/NEWS. I added a new entry too. >> + (with-connection-local-variables >> + (if (and (boundp 'system-uses-terminfo) system-uses-terminfo) > > According to git log, the variable system-uses-terminfo exists since [1994.] > I guess it is save to get rid of "(and (boundp 'system-uses-terminfo)". Removed this. Thanks for taking a look. - Jim --------------272430E9BFBF6E422D1F2B94 Content-Type: text/plain; charset=UTF-8; name="0001-Support-setting-comint-terminal-connection-locally.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Support-setting-comint-terminal-connection-locally.patc"; filename*1="h" RnJvbSAwMGNiOTkyOWY2ZThkOTc1MzFjN2E5OTU2YjQ1MTYxOWY0ZmY2NDJiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFdlZCwgMjcgT2N0IDIwMjEgMTQ6NDE6NTQgLTA3MDAKU3ViamVjdDogW1BB VENIXSBTdXBwb3J0IHNldHRpbmcgY29taW50IHRlcm1pbmFsIGNvbm5lY3Rpb24tbG9jYWxs eQoKKiBsaXNwL2NvbWludC5lbCAoY29taW50LXRlcm0tZW52aXJvbm1lbnQpOiBNYWtlIGl0 IGNvbm5lY3Rpb24tYXdhcmUuCiogZG9jL2VtYWNzL21pc2MudGV4aSAoU2hlbGwgT3B0aW9u cyk6IERvY3VtZW50IHRoZSBhYm92ZSBjaGFuZ2UsIGFuZApleHBsYWluIGhvdyB0aGlzIGlu dGVyYWN0cyB3aXRoICdzeXN0ZW0tdXNlcy10ZXJtaW5mbycuCiogZXRjL05FV1M6IEFubm91 bmNlIHRoZSBhYm92ZSBjaGFuZ2UuCi0tLQogZG9jL2VtYWNzL21pc2MudGV4aSB8IDEyICsr KysrKysrKy0tLQogZXRjL05FV1MgICAgICAgICAgICB8ICA4ICsrKysrKysrCiBsaXNwL2Nv bWludC5lbCAgICAgIHwgMTMgKysrKysrKy0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCAyNCBp bnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9t aXNjLnRleGkgYi9kb2MvZW1hY3MvbWlzYy50ZXhpCmluZGV4IDUxMjNhNzE2ZGMuLjNmOGZi YTIxNTUgMTAwNjQ0Ci0tLSBhL2RvYy9lbWFjcy9taXNjLnRleGkKKysrIGIvZG9jL2VtYWNz L21pc2MudGV4aQpAQCAtMTQ5NywxNCArMTQ5NywyMCBAQCBTaGVsbCBPcHRpb25zCiB1bmRl cmx5aW5nIHNoZWxsLCBvZiBjb3Vyc2UuCiAKIEB2aW5kZXggY29taW50LXRlcm1pbmZvLXRl cm1pbmFsCitAdmluZGV4IHN5c3RlbS11c2VzLXRlcm1pbmZvCiBAdmluZGV4IFRFUk1Acnss IGVudmlyb25tZW50IHZhcmlhYmxlLCBpbiBzdWItc2hlbGx9CiBDb21pbnQgbW9kZSBzZXRz IHRoZSBAZW52e1RFUk19IGVudmlyb25tZW50IHZhcmlhYmxlIHRvIGEgc2FmZSBkZWZhdWx0 CiB2YWx1ZSwgYnV0IHRoaXMgdmFsdWUgZGlzYWJsZXMgc29tZSB1c2VmdWwgZmVhdHVyZXMu ICBGb3IgZXhhbXBsZSwKIGNvbG9yIGlzIGRpc2FibGVkIGluIGFwcGxpY2F0aW9ucyB0aGF0 IHVzZSBAZW52e1RFUk19IHRvIGRldGVybWluZSBpZgogY29sb3IgaXMgc3VwcG9ydGVkLiAg VGhlcmVmb3JlLCBFbWFjcyBwcm92aWRlcyBhbiBvcHRpb24KLUBjb2Rle2NvbWludC10ZXJt aW5mby10ZXJtaW5hbH0sIHdoaWNoIHlvdSBjYW4gc2V0IHRvIGEgdGVybWluYWwgdGhhdAot aXMgcHJlc2VudCBpbiB5b3VyIHN5c3RlbSdzIHRlcm1pbmZvIGRhdGFiYXNlLCBpbiBvcmRl ciB0byB0YWtlCi1hZHZhbnRhZ2Ugb2YgYWR2YW5jZWQgZmVhdHVyZXMgb2YgdGhhdCB0ZXJt aW5hbC4KK0Bjb2Rle2NvbWludC10ZXJtaW5mby10ZXJtaW5hbH0gdG8gbGV0IHlvdSBjaG9v c2UgYSB0ZXJtaW5hbCB3aXRoIG1vcmUKK2FkdmFuY2VkIGZlYXR1cmVzLCBhcyBkZWZpbmVk IGluIHlvdXIgc3lzdGVtJ3MgdGVybWluZm8gZGF0YWJhc2UuCitXaGVuIEBjb2Rle3N5c3Rl bS11c2VzLXRlcm1pbmZvfSBpcyBub24tbmlsLCBFbWFjcyB3aWxsIHVzZSB0aGlzCitvcHRp b24gYXMgdGhlIHZhbHVlIGZvciBAZW52e1RFUk19LgorCitCb3RoIEBjb2Rle2NvbWludC10 ZXJtaW5mby10ZXJtaW5hbH0gYW5kIEBjb2Rle3N5c3RlbS11c2VzLXRlcm1pbmZvfQorY2Fu IGJlIGRlY2xhcmVkIGFzIGNvbm5lY3Rpb24tbG9jYWwgdG8gYWRqdXN0IHRoZXNlIG9wdGlv bnMgdG8gbWF0Y2gKK3doYXQgYSByZW1vdGUgc3lzdGVtIGV4cGVjdHMgKEBweHJlZntDb25u ZWN0aW9uIFZhcmlhYmxlc30pLgogCiBAbm9kZSBUZXJtaW5hbCBlbXVsYXRvcgogQHN1YnNl Y3Rpb24gRW1hY3MgVGVybWluYWwgRW11bGF0b3IKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIv ZXRjL05FV1MKaW5kZXggYzFiOGFkYzUxMS4uMmE4YTNmMDhlNyAxMDA2NDQKLS0tIGEvZXRj L05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTE4Myw2ICsxODMsMTQgQEAgVG8gaW1wcm92ZSBz ZWN1cml0eSwgaWYgYW4gc3FsIHByb2R1Y3QgaGFzICc6cGFzc3dvcmQtaW4tY29taW50JyBz ZXQKIHRvIHQsIGEgcGFzc3dvcmQgc3VwcGxpZWQgdmlhIHRoZSBtaW5pYnVmZmVyIHdpbGwg YmUgc2VudCBpbi1wcm9jZXNzLAogYXMgb3Bwb3NlZCB0byB2aWEgdGhlIGNvbW1hbmQtbGlu ZS4KIAorKiogQ29taW50CisKKysrKworKioqICdjb21pbnQtdGVybS1lbnZpcm9ubWVudCcg aXMgbm93IGF3YXJlIG9mIGNvbm5lY3Rpb24tbG9jYWwgdmFyaWFibGVzLgorVGhlIG9wdGlv biAnY29taW50LXRlcm1pbmZvLXRlcm1pbmFsJyBhbmQgdmFyaWFibGUKKydzeXN0ZW0tdXNl cy10ZXJtaW5mbycgY2FuIG5vdyBiZSBzZXQgYXMgY29ubmVjdGlvbi1sb2NhbCB2YXJpYWJs ZXMgdG8KK2NoYW5nZSB0aGUgdGVybWluYWwgdXNlZCBvbiBhIHJlbW90ZSBob3N0LgorCiAM CiAqIE5ldyBNb2RlcyBhbmQgUGFja2FnZXMgaW4gRW1hY3MgMjkuMQogCmRpZmYgLS1naXQg YS9saXNwL2NvbWludC5lbCBiL2xpc3AvY29taW50LmVsCmluZGV4IGU5MjViM2E0YjYuLmMx MTRiZGY3NTggMTAwNjQ0Ci0tLSBhL2xpc3AvY29taW50LmVsCisrKyBiL2xpc3AvY29taW50 LmVsCkBAIC04ODksMTIgKzg4OSwxMyBAQCBjb21pbnQtdGVybS1lbnZpcm9ubWVudAogICA7 OyBhbmQgdGhlcmUgaXMgbm8gd2F5IGZvciB1cyB0byBkZWZpbmUgaXQgaGVyZS4KICAgOzsg U29tZSBwcm9ncmFtcyB0aGF0IHVzZSB0ZXJtaW5mbyBnZXQgdmVyeSBjb25mdXNlZAogICA7 OyBpZiBURVJNIGlzIG5vdCBhIHZhbGlkIHRlcm1pbmFsIHR5cGUuCi0gIChpZiAoYW5kIChi b3VuZHAgJ3N5c3RlbS11c2VzLXRlcm1pbmZvKSBzeXN0ZW0tdXNlcy10ZXJtaW5mbykKLSAg ICAgIChsaXN0IChmb3JtYXQgIlRFUk09JXMiIGNvbWludC10ZXJtaW5mby10ZXJtaW5hbCkK LSAgICAgICAgICAgICJURVJNQ0FQPSIKLSAgICAgICAgICAgIChmb3JtYXQgIkNPTFVNTlM9 JWQiICh3aW5kb3ctd2lkdGgpKSkKLSAgICAobGlzdCAiVEVSTT1lbWFjcyIKLSAgICAgICAg ICAoZm9ybWF0ICJURVJNQ0FQPWVtYWNzOmNvIyVkOnRjPXVua25vd246IiAod2luZG93LXdp ZHRoKSkpKSkKKyAgKHdpdGgtY29ubmVjdGlvbi1sb2NhbC12YXJpYWJsZXMKKyAgIChpZiBz eXN0ZW0tdXNlcy10ZXJtaW5mbworICAgICAgIChsaXN0IChmb3JtYXQgIlRFUk09JXMiIGNv bWludC10ZXJtaW5mby10ZXJtaW5hbCkKKyAgICAgICAgICAgICAiVEVSTUNBUD0iCisgICAg ICAgICAgICAgKGZvcm1hdCAiQ09MVU1OUz0lZCIgKHdpbmRvdy13aWR0aCkpKQorICAgICAo bGlzdCAiVEVSTT1lbWFjcyIKKyAgICAgICAgICAgKGZvcm1hdCAiVEVSTUNBUD1lbWFjczpj byMlZDp0Yz11bmtub3duOiIgKHdpbmRvdy13aWR0aCkpKSkpKQogCiAoZGVmdW4gY29taW50 LW5vbmJsYW5rLXAgKHN0cikKICAgIlJldHVybiBub24tbmlsIGlmIFNUUiBjb250YWlucyBu b24td2hpdGVzcGFjZSBzeW50YXguIgotLSAKMi4yNS4xCgo= --------------272430E9BFBF6E422D1F2B94--