From: Mauro Aranda <maurooaranda@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stephen Berman <stephen.berman@gmx.net>, 64347@debbugs.gnu.org
Subject: bug#64347: 30.0.50; Some customize faces shown as edited with -Q
Date: Fri, 30 Jun 2023 08:33:39 -0300 [thread overview]
Message-ID: <2b6de9de-f33f-0547-eaa0-1f9d24f70115@gmail.com> (raw)
In-Reply-To: <83cz1etpdm.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Stephen Berman <stephen.berman@gmx.net>
>> Date: Thu, 29 Jun 2023 12:15:00 +0200
>>
>> 0. emacs -Q
>> 1. M-x customize-face RET RET
>> 2. Toggle all face entries in the buffer *Customize Faces* (e.g. by
>> creating this keyboard macro: C-s C-q C-j S RET C-f and then
>> executing it 164 times) and search for the string "EDITED" in the
>> buffer.
>> => The following faces show the State "EDITED, shown value does not
>> take effect until you set or save it.":
>> confusingly-reordered
>> custom-button
>> custom-button-mouse
>> custom-button-pressed
>> mode-line
>> mode-line-highlight
>> mode-line-inactive
>> tab-bar-tab
>> tool-bar
>> All other faces show the State "STANDARD".
>> 3. Clicking the State button of these faces and selecting either "Undo
>> Edits" or "Revert This Session's Customization" does not change the
>> State shown.
>> 4. Clicking the State button of, e.g., mode-line and selecting "Set for
>> Current Session" changes the State shown to "SET for current session
>> only." I see no difference in the appearance of the mode line before
>> and after this State change.
>> 5. Clicking the State button of mode-line again and selecting "Revert
>> This Session's Customization" changes the State shown back to
>> "EDITED, shown value does not take effect until you set or save it.",
>> and again the appearance of the mode-line is unchanged.
>
> This is a regression between Emacs 27.2 and Emacs 28.1. Bisecting
> will be welcome.
I tried to bisect but I'm finding build errors on older commits:
CC sysdep.o
sysdep.c:1784:22: error: variably modified ‘sigsegv_stack’ at file scope
1784 | static unsigned char sigsegv_stack[SIGSTKSZ];
So I did some debugging. I noted that all the faces posted by Stephen
(except confusingly-reordered) have a Horizontal Width widget. So
something like this is enough to get Custom confused:
(defface test
'((t :box (:line-width 2 :style released-button)))
"...")
M-x customize-face RET test
Shows the EDITED State.
So that points to Custom fiddling with the real value, i.e., what
face-attribute would return, but not with the "customized value", the
value that holds the Widget.
Looking at the changes in custom-face-attributes, I see this commit:
commit 34ae2d0c220c945443e94a43d043a4a63c444bf4
Author: Alexandre Adolphe <alexandre.adolphe@gmail.com>
Date: Sat Aug 10 22:57:24 2019 +0200
Allow negative line width for :box face attribute
And I noticed that it modified the real-value filter, but not the
customized-value filter. So I suspect that might be the problem.
Maybe someone that is able to build Emacs for that and previous commits
can confirm.
In the meantime, I'll read the documentation on :line-width, since I'm
pretty sure a changed in the customized value filter is required.
(And I don't know what's wrong with the confusingly-reordered face yet)
next prev parent reply other threads:[~2023-06-30 11:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-29 10:15 bug#64347: 30.0.50; Some customize faces shown as edited with -Q Stephen Berman
2023-06-29 12:38 ` Eli Zaretskii
2023-06-30 11:33 ` Mauro Aranda [this message]
2023-06-30 12:43 ` Drew Adams
2023-06-30 14:05 ` Mauro Aranda
2023-07-08 7:49 ` Eli Zaretskii
2023-07-08 21:32 ` Mauro Aranda
2023-07-09 5:43 ` Eli Zaretskii
2023-07-09 11:44 ` Mauro Aranda
2023-07-09 12:13 ` Eli Zaretskii
2023-07-09 23:12 ` Mauro Aranda
2023-07-10 12:47 ` Eli Zaretskii
2023-07-10 13:45 ` Mauro Aranda
2023-07-15 20:01 ` Mauro Aranda
2023-07-20 15:45 ` Eli Zaretskii
2023-07-15 20:11 ` Mauro Aranda
2023-07-20 15:49 ` Eli Zaretskii
2023-07-20 18:56 ` Mauro Aranda
2023-07-20 19:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b6de9de-f33f-0547-eaa0-1f9d24f70115@gmail.com \
--to=maurooaranda@gmail.com \
--cc=64347@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).