From: Paul Eggert <eggert@cs.ucla.edu>
To: Paul Pogonyshev <pogonyshev@gmail.com>
Cc: 38191-done@debbugs.gnu.org
Subject: bug#38191: incorrect text properties in result of `format' with multibyte(?) characters
Date: Thu, 14 Nov 2019 14:46:49 -0800 [thread overview]
Message-ID: <2b3973a1-49fc-a6a6-2ce2-4328490e6d9d@cs.ucla.edu> (raw)
In-Reply-To: <CAG7Bpaqb8dypYo3uxvqdz-t1J1itCcAfvczTFJbKRp56jbs_5w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 69 bytes --]
Thanks for reporting that. I installed the attached patch to fix it.
[-- Attachment #2: 0001-Fix-byte-counting-error-in-format.patch --]
[-- Type: text/x-patch, Size: 2619 bytes --]
From 63aafe766e7d81aa7b2e75bddf2ce3eca4611ae5 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 14 Nov 2019 14:42:39 -0800
Subject: [PATCH] =?UTF-8?q?Fix=20byte-counting=20error=20in=20=E2=80=98for?=
=?UTF-8?q?mat=E2=80=99?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Problem reported by Paul Pogonyshev (Bug#38191).
* src/editfns.c (styled_format): When checking for adjacent
%-sequences, use byte position rather than character position.
* test/src/editfns-tests.el (format-properties): Test for fix.
---
src/editfns.c | 6 +++---
test/src/editfns-tests.el | 4 ++++
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/editfns.c b/src/editfns.c
index 1b33f39711..8fc866d391 100644
--- a/src/editfns.c
+++ b/src/editfns.c
@@ -3143,7 +3143,7 @@ styled_format (ptrdiff_t nargs, Lisp_Object *args, bool message)
/* The start and end bytepos in the output string. */
ptrdiff_t start, end;
- /* The start of the spec in the format string. */
+ /* The start bytepos of the spec in the format string. */
ptrdiff_t fbeg;
/* Whether the argument is a string with intervals. */
@@ -3954,7 +3954,7 @@ styled_format (ptrdiff_t nargs, Lisp_Object *args, bool message)
{
position++;
if (fieldn < nspec
- && position > info[fieldn].fbeg
+ && bytepos >= info[fieldn].fbeg
&& translated == info[fieldn].start)
{
translated += info[fieldn].end - info[fieldn].start;
@@ -3976,7 +3976,7 @@ styled_format (ptrdiff_t nargs, Lisp_Object *args, bool message)
{
position++;
if (fieldn < nspec
- && position > info[fieldn].fbeg
+ && bytepos >= info[fieldn].fbeg
&& translated == info[fieldn].start)
{
translated += info[fieldn].end - info[fieldn].start;
diff --git a/test/src/editfns-tests.el b/test/src/editfns-tests.el
index a1060808f6..238fb409f0 100644
--- a/test/src/editfns-tests.el
+++ b/test/src/editfns-tests.el
@@ -90,6 +90,10 @@ format-properties
(propertize "45" 'face 'italic)))
#("012345 "
0 2 (face bold) 2 4 (face underline) 4 10 (face italic))))
+ ;; Bug #38191
+ (should (ert-equal-including-properties
+ (format (propertize "‘foo’ %s bar" 'face 'bold) "xxx")
+ #("‘foo’ xxx bar" 0 13 (face bold))))
;; Bug #32404
(should (ert-equal-including-properties
(format (concat (propertize "%s" 'face 'bold)
--
2.23.0
prev parent reply other threads:[~2019-11-14 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 0:31 bug#38191: incorrect text properties in result of `format' with multibyte(?) characters Paul Pogonyshev
2019-11-14 5:30 ` Lars Ingebrigtsen
2019-11-14 22:46 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b3973a1-49fc-a6a6-2ce2-4328490e6d9d@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=38191-done@debbugs.gnu.org \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).