From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#22105: 25.1.50; REGRESSION - `modify-frame-parameters' Date: Mon, 7 Dec 2015 09:00:43 -0800 (PST) Message-ID: <2b37d302-b956-48e6-98d0-fc116af6e684@default> References: <29534178-ce2c-4d5d-b663-75e1fddcb043@default> <566560E2.4010204@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1449507711 12287 80.91.229.3 (7 Dec 2015 17:01:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Dec 2015 17:01:51 +0000 (UTC) To: martin rudalics , 22105@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 07 18:01:38 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a5zAO-0007FC-MS for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Dec 2015 18:01:36 +0100 Original-Received: from localhost ([::1]:55599 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5zAN-0001hX-Kd for geb-bug-gnu-emacs@m.gmane.org; Mon, 07 Dec 2015 12:01:35 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33591) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5z9u-00012K-FP for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 12:01:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a5z9q-0005BL-T0 for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 12:01:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:52220) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a5z9q-0005B5-Qg for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 12:01:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a5z9q-0001gK-DB for bug-gnu-emacs@gnu.org; Mon, 07 Dec 2015 12:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Dec 2015 17:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22105 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22105-submit@debbugs.gnu.org id=B22105.14495076515618 (code B ref 22105); Mon, 07 Dec 2015 17:01:02 +0000 Original-Received: (at 22105) by debbugs.gnu.org; 7 Dec 2015 17:00:51 +0000 Original-Received: from localhost ([127.0.0.1]:41928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5z9e-0001Rp-Jd for submit@debbugs.gnu.org; Mon, 07 Dec 2015 12:00:51 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:19652) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a5z9c-0001Oh-BL for 22105@debbugs.gnu.org; Mon, 07 Dec 2015 12:00:49 -0500 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tB7H0jTs005330 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Dec 2015 17:00:46 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id tB7H0joQ003996 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 7 Dec 2015 17:00:45 GMT Original-Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id tB7H0jVU008645; Mon, 7 Dec 2015 17:00:45 GMT In-Reply-To: <566560E2.4010204@gmx.at> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109714 Archived-At: > I suppose the behavior is indeed caused by adding and removing the menu > bar. At least when doing C-z repeatedly with the "(debug)" commented > out I see here both small and normal font frames continuously increase > in size. >=20 > You could try with > (setq frame-inhibit-implied-resize '(menu-bar-lines tool-bar-lines)) > which inherently means to not resize the outer frame when adding or > removing the menu bar. It seems to cure the problem I described above. Thanks for the quick reply. Yes, that does seem to take care of this problem, but I will take a closer look when I get a chance. In any case, other woes introduced on 2015-10-20 are not fixed by setting that option - I'll have to find some time to track those down. But this is a user option. Even if changing the value is a "fix" for this, I'm not sure how I should approach this wrt a library that lets users thumbify frames and decide which frame parameter values they want to impose on the thumbnail frames. I guess I could change the option value on the fly, if `menu-bar-lines' is changed to or from 0). But that seems ugly and awkward. I see that the default value of this option gives you the same behavior as you get in Emacs 24.5 (or earlier). E.g., toggling menu-bar-mode changes the height, but toggling tool-bar-mode does not change the height. But that compatibility does not apply to my thumbification. That still seems like a bug. My code restores a set of frame parameters, but that behavior is broken, it seems, because that particular call to `modify-frame-parameters' has _no effect_. It's not just that the frame height is changed by the height of a menu-bar or not, depending on the option value. The height is not changed _at all_ by that call, if I don't tweak the option, and it should be changed a _lot_ (assuming you resized the unthumbified frame to reduce the height a lot). The `height' parameter that is being restored is apparently ignored. My guess is that all of the parameters are being ignored - that particular call to `modify-frame-parameters' appears to be a no-op. That doesn't seem to follow what the option should do, regardless of the option value. And if you step through the debugger then it _has_ its intended effect - the `modify-frame-parameters' call is not ignored - it restores all of the parameters passed to it (including `height'). So I cannot think that this bug is fixed (or not a bug), but I don't really understand all that is involved, and I will play some more with that user option - when I get a chance. I hope that you will investigate, following my recipe, why that `modify-frame-parameters' call now has no effect unless you step through the debugger. But I can at least confirm that the problem does indeed seem to be brought on by the code that implements that option. Thanks for looking into this, Martin.