From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67246: 30.0.50; elixir-ts-mode uses faces inconsistently Date: Mon, 5 Feb 2024 19:42:34 +0200 Message-ID: <2af6bb1e-8b14-4023-85a6-45dfba8be724@gutov.dev> References: <87y1ewgnn7.fsf@gmail.com> <9ae8eb33-fd8b-f8d6-dd7f-79f8d4464a51@gutov.dev> <87a5r2p4pq.fsf@gmail.com> <87bkbfkr1h.fsf@gmail.com> <22ea1559-f44e-933d-e60a-9caa62b376a8@gutov.dev> <878r69vow6.fsf@gmail.com> <95509dbc-7c71-4996-84f5-d37976e2661f@gutov.dev> <0d483c86-7e70-433c-8cea-15ac9238983c@gutov.dev> <627331b9-5759-43b1-a319-712c11ead2f6@gmail.com> <557bf51e-be4c-46c5-b2c5-8d06d28b7943@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34953"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: Andrey Listopadov , 67246@debbugs.gnu.org To: Wilhelm Kirschbaum , Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 05 18:44:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rX310-0008qR-HW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Feb 2024 18:44:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rX30c-0007hF-9x; Mon, 05 Feb 2024 12:43:54 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rX30Y-0007gy-7l for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2024 12:43:51 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rX30Y-0000la-0C for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2024 12:43:50 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rX30k-0000dL-8z for bug-gnu-emacs@gnu.org; Mon, 05 Feb 2024 12:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Feb 2024 17:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67246 X-GNU-PR-Package: emacs Original-Received: via spool by 67246-submit@debbugs.gnu.org id=B67246.17071549822355 (code B ref 67246); Mon, 05 Feb 2024 17:44:02 +0000 Original-Received: (at 67246) by debbugs.gnu.org; 5 Feb 2024 17:43:02 +0000 Original-Received: from localhost ([127.0.0.1]:52248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rX2zl-0000bj-JM for submit@debbugs.gnu.org; Mon, 05 Feb 2024 12:43:02 -0500 Original-Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:51983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rX2zg-0000bD-GF for 67246@debbugs.gnu.org; Mon, 05 Feb 2024 12:43:00 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 70DF53200AE7; Mon, 5 Feb 2024 12:42:37 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 05 Feb 2024 12:42:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1707154956; x=1707241356; bh=/g4mBOWZz2xf8ubkRz+rW/7YSz7BOSRWU8snm6e+YkA=; b= VJ2qlab9J4R+bufn1rLLyqpmuGZNJoiiGwZl26roABD6NF5i2ZWacChfVnIP5+jz IT9o5ZazCrXfWQIGdHTtOAoK/TtJXB4N4nE49MGQ9oM77YlC+dsfJsw2nKjEzXiA rRpICEKnMPlduweM14PqhqDoLjzuq5ntIQR74exktThIkyf0TPQCbKPF1Zo2MC1P nxj2YFhhx6r8JY7vMyGpujVTJXHoqzGxrvJmKH45jdOMQcjADXPX+guXrc2NF/GY iTt+ZOorjgBoATCDid/5mIRbeZbzTNoNHayZ+tJoxdkF5lGu/K2uI0vms606DRd+ W5LmMicafEQEdP5IWKFwVg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1707154956; x= 1707241356; bh=/g4mBOWZz2xf8ubkRz+rW/7YSz7BOSRWU8snm6e+YkA=; b=q 6jSwsYM+L2l66jOPBCc21y3a8JqJMSl+W9NsC+h06yFLoZruyHQMxGf/0AQqFF2E Gh/DiO5j7aVNkCe1aIJaSzEftz3JbB6KvI5yg8wfjwXKsRHJkz7P66rx0EmONiGL EF3po1TjkUix/sRHzYCdD+3AqoqGVr9lmJPs2KnglZWlouVCOajfF8y2Y9twY9c9 4o/Xo4pvFZFKmE7/Q4Ud3j4PCTxbN61U0MjBrLGhNI/ioWKTzHJXbOZ/3oY+DrVa hxLwAa12DNBkd/LEEXvBysJcJxFElxR89lrqQUBkjHbk4k1rRt28ZsSZe/gdN8Ut ZWsfuqO7YPPfKka18N01g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrfedvuddguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepgeelfeetkefghfdvhfdtgeevveevteetgeetveegtedthefhudekteehffeu keeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 5 Feb 2024 12:42:35 -0500 (EST) Content-Language: en-US In-Reply-To: <557bf51e-be4c-46c5-b2c5-8d06d28b7943@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279460 Archived-At: On 05/02/2024 19:34, Wilhelm Kirschbaum wrote: > > Adding this as the first item to :feature 'elixir-definition fixes the > function-call/name issue: > > @@ -360,13 +360,19 @@ elixir-ts--indent-rules >  (defvar elixir-ts--font-lock-settings >    (treesit-font-lock-rules >     :language 'elixir > -   :feature 'elixir-function-name > +   :feature 'elixir-definition >     `((call target: (identifier) @target-identifier > +           (arguments > +            (call target: (identifier) @font-lock-function-name-face > +                  (arguments))) > +           (:match ,elixir-ts--definition-keywords-re @target-identifier)) > +     (call target: (identifier) @target-identifier >             (arguments (identifier) @font-lock-function-name-face) > > I will be working in Elixir this week and will set different fonts for > to test it during the week, but don't think it should hold up installing > the suggested patch so long. Thanks! Could you give an example of problematic highlighting, though? So I can keep it mind when installing both changes.