From: Platon Pronko <platon7pronko@gmail.com>
To: martin rudalics <rudalics@gmx.at>, 48413@debbugs.gnu.org
Subject: bug#48413: 28.0.50; emacs does not repaint the window after switching workspaces in Xmonad
Date: Fri, 14 May 2021 18:28:29 +0300 [thread overview]
Message-ID: <2acc2d8e-3574-56e9-7b2f-8b9d131fdb3d@gmail.com> (raw)
In-Reply-To: <2b24c14c-02d9-29f2-571b-ef791a20cc2d@gmx.at>
> Can you please try the attached patch and tell me whether it improves or
> breaks things.
Yes, it fixes things - frame is repainted correctly now.
My attempt was similar, but I included more code alongside SET_FRAME_VISIBLE (same as in Expose handler):
+ block_input ();
+ SET_FRAME_VISIBLE (f, 1);
+ if (FRAME_X_DOUBLE_BUFFERED_P (f))
+ font_drop_xrender_surfaces (f);
+ f->output_data.x->has_been_visible = true;
+ SET_FRAME_GARBAGED (f);
+ unblock_input ();
I'm not very familiar with Emacs frame internals - we don't need all these here?
> Relying on these for setting visibility will fail for anyone who doesn't
> send us an Expose event.
I agree, feels a little fragile.
Best regards,
Platon Pronko
next prev parent reply other threads:[~2021-05-14 15:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 8:32 bug#48413: 28.0.50; emacs does not repaint the window after switching workspaces in Xmonad Platon Pronko
2021-05-14 9:50 ` martin rudalics
2021-05-14 15:13 ` martin rudalics
2021-05-14 15:28 ` Platon Pronko [this message]
2021-05-14 15:56 ` martin rudalics
2021-05-14 16:07 ` Platon Pronko
2021-05-15 7:55 ` martin rudalics
2021-05-15 8:01 ` Platon Pronko
2021-05-15 8:16 ` martin rudalics
2021-05-15 8:28 ` Platon Pronko
2021-09-29 12:07 ` Stefan Kangas
2021-09-29 14:10 ` Platon Pronko
2021-09-29 14:29 ` Stefan Kangas
2021-09-30 16:16 ` martin rudalics
2021-05-14 16:03 ` Basil L. Contovounesios
2021-05-15 7:55 ` martin rudalics
2021-05-14 10:08 ` Basil L. Contovounesios
2021-05-14 11:05 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2acc2d8e-3574-56e9-7b2f-8b9d131fdb3d@gmail.com \
--to=platon7pronko@gmail.com \
--cc=48413@debbugs.gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).