From: Paul Eggert <eggert@cs.ucla.edu>
To: Ken Brown <kbrown@cornell.edu>, Eli Zaretskii <eliz@gnu.org>
Cc: p.stephani2@gmail.com, 32189-done@debbugs.gnu.org
Subject: bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2
Date: Fri, 20 Jul 2018 14:03:30 -0700 [thread overview]
Message-ID: <2ac38220-8f25-1898-6350-03d199bbdbf6@cs.ucla.edu> (raw)
In-Reply-To: <ed2db628-3f59-e8fb-5611-70cdc45e3097@cornell.edu>
On 07/20/2018 12:34 PM, Ken Brown wrote:
> Would it make sense to move its definition to eval.c, where
> vformat_string is defined, and declare it as external in lisp.h?
Sure, if it's needed. In practice, I've found Fformat and
Fformat_message to be more useful at the C level (among other things
they handle more formats), and suggest using them if they're applicable.
But if they're not, we can use format_string elsewhere -- though it
would be helpful to note its limitations compared to Fformat_string, in
a comment perhaps (you can see some of its limitations in the long
comment at the start of doprnt.c, which the format_string comment could
refer to).
prev parent reply other threads:[~2018-07-20 21:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 19:26 bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2 Ken Brown
2018-07-18 15:09 ` Eli Zaretskii
2018-07-18 19:42 ` Ken Brown
2018-07-19 2:38 ` Eli Zaretskii
2018-07-19 6:10 ` Philipp Stephani
2018-07-19 12:49 ` Ken Brown
2018-07-19 13:25 ` Eli Zaretskii
2018-07-19 6:21 ` Philipp Stephani
2018-07-19 13:29 ` Eli Zaretskii
2018-07-19 13:56 ` Ken Brown
2018-07-19 14:17 ` Eli Zaretskii
2018-07-19 23:19 ` Paul Eggert
2018-07-20 6:56 ` Eli Zaretskii
2018-07-20 13:49 ` Ken Brown
2018-07-20 14:17 ` Eli Zaretskii
2018-07-20 14:27 ` Ken Brown
2018-07-20 14:37 ` Paul Eggert
2018-07-20 14:51 ` Eli Zaretskii
2018-07-20 19:34 ` Ken Brown
2018-07-20 21:03 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ac38220-8f25-1898-6350-03d199bbdbf6@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=32189-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=kbrown@cornell.edu \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).