From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#67809: [PATCH] Add font-locking for assignments in typescript-ts-mode Date: Wed, 13 Dec 2023 20:31:06 +0200 Message-ID: <2aa7f05f-7cfa-9a1a-4a75-88c8df53c221@gutov.dev> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39963"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: Noah Peart , 67809@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 13 19:32:00 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rDU1W-000ACN-Tl for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 13 Dec 2023 19:31:59 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rDU1L-000678-Ik; Wed, 13 Dec 2023 13:31:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rDU1K-00066W-Jt for bug-gnu-emacs@gnu.org; Wed, 13 Dec 2023 13:31:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rDU1K-00058l-BT for bug-gnu-emacs@gnu.org; Wed, 13 Dec 2023 13:31:46 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rDU1a-0006Yd-DD for bug-gnu-emacs@gnu.org; Wed, 13 Dec 2023 13:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Dec 2023 18:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67809 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67809-submit@debbugs.gnu.org id=B67809.170249229225167 (code B ref 67809); Wed, 13 Dec 2023 18:32:02 +0000 Original-Received: (at 67809) by debbugs.gnu.org; 13 Dec 2023 18:31:32 +0000 Original-Received: from localhost ([127.0.0.1]:59667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDU16-0006Xr-5W for submit@debbugs.gnu.org; Wed, 13 Dec 2023 13:31:32 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57509) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rDU14-0006Xe-Is for 67809@debbugs.gnu.org; Wed, 13 Dec 2023 13:31:31 -0500 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4F5105C03CB; Wed, 13 Dec 2023 13:31:09 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 13 Dec 2023 13:31:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1702492269; x=1702578669; bh=rQn4yD4YkBHWYXUDVM3oD7HVwAg8cIawznzNOQ0wnvE=; b= PH3dCTOzJcrWzushHsIVK5dpGQbPynkdFT7slV/U5lA3WueHjpAOqdr2EKk4gvDh 7Q44pSVUyZGawSD5fUFZ648V/noXBXX9eUM4VcU+dP8DLZ0YGB3JiSoKomkki6N2 n0sGgzWhtVdHzyU8kSofqagj/ioVBiwZQO7nO21rLZ7JH8O0ZxuUjNdeIewej4fB EzxnarA1rKSUGXtKGNYmyOgLPdS/NTQZYtzI8ga3GKpcVIySAoNP74i4o0dEsXBn ijcSll9PU8A5WWpqeAixTefk+2FDzxvM+U+g8eH/MAzjOMqEF0HH4a8sFRZQ0QZp +4WmIfDw6GXtAPEnisGuYA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1702492269; x= 1702578669; bh=rQn4yD4YkBHWYXUDVM3oD7HVwAg8cIawznzNOQ0wnvE=; b=C Ojc4uxD4tXBm0UyD4Xe9z21NC+5MB3SIwwIJf0ZgvwiicDfIyrVWhButgz+7M8UT a8vxRTwSqJUg2DYD4PCoT5Euydplw4qz0zOd5DHqKpVcMDjsprAU9X3kg6LP1Qll wiKM7UPjyMtBZImR8wPvlu6+o2PEueyyoimFketSO6/TYGJn9JyAaHX/5nL3Ii9n 88JPwz+0WhaoqpFmehXnyh6EPlHMW98IhqdH8Z/Bxhf9/m75e8LbUtkWBD7yyiZY EknfmVN0ntEu//LCL0LRi/CakOi/4lpkInNdcmNnLH0FgvieK+UfzoYQCr2qS9aH 6/wd3YutFym6bFPna6SBQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudeljedgheefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthekredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeefjeekvedvfeelfedufeevgeetvdevkeelvddtueetteefudefgfduieekffei leenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 13 Dec 2023 13:31:07 -0500 (EST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276152 Archived-At: Hi! On 13/12/2023 10:33, Noah Peart wrote: >     arr[obj.x * obj.x] = 1; >     //^ font-lock-variable-name-face >     //    ^ font-lock-variable-use-face >     //      ^ font-lock-property-use-face >     obj.x.y = 0; >     //^ font-lock-variable-name-face >     //  ^ font-lock-property-name-face >     //    ^ font-lock-property-name-face >     ++mat[x][arr[0]]; >     // ^ font-lock-variable-name-face >     //        ^ font-lock-variable-use-face I think in all of these cases font-lock-variable-name-face should not be used, since arr, and obj, and mat, are all introduced (declared) at a different place. font-lock-variable-use-face is more appropriate.