From: Dmitry Gutov <dmitry@gutov.dev>
To: Noah Peart <noah.v.peart@gmail.com>, 67809@debbugs.gnu.org
Subject: bug#67809: [PATCH] Add font-locking for assignments in typescript-ts-mode
Date: Wed, 13 Dec 2023 20:31:06 +0200 [thread overview]
Message-ID: <2aa7f05f-7cfa-9a1a-4a75-88c8df53c221@gutov.dev> (raw)
In-Reply-To: <CAPVBTSeaui3Ek_LPzf=xAVY81yCswBkZukfL0Wz=k8q2Y2Bfbg@mail.gmail.com>
Hi!
On 13/12/2023 10:33, Noah Peart wrote:
> arr[obj.x * obj.x] = 1;
> //^ font-lock-variable-name-face
> // ^ font-lock-variable-use-face
> // ^ font-lock-property-use-face
> obj.x.y = 0;
> //^ font-lock-variable-name-face
> // ^ font-lock-property-name-face
> // ^ font-lock-property-name-face
> ++mat[x][arr[0]];
> // ^ font-lock-variable-name-face
> // ^ font-lock-variable-use-face
I think in all of these cases font-lock-variable-name-face should not be
used, since arr, and obj, and mat, are all introduced (declared) at a
different place.
font-lock-variable-use-face is more appropriate.
next prev parent reply other threads:[~2023-12-13 18:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 8:33 bug#67809: [PATCH] Add font-locking for assignments in typescript-ts-mode Noah Peart
2023-12-13 18:31 ` Dmitry Gutov [this message]
2023-12-13 19:26 ` Noah Peart
2023-12-13 20:45 ` Dmitry Gutov
2023-12-23 8:45 ` Eli Zaretskii
2023-12-23 10:39 ` Noah Peart
2023-12-23 11:21 ` Eli Zaretskii
2023-12-23 20:57 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2aa7f05f-7cfa-9a1a-4a75-88c8df53c221@gutov.dev \
--to=dmitry@gutov.dev \
--cc=67809@debbugs.gnu.org \
--cc=noah.v.peart@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).