From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#61066: [PATCH] Add inlay hint support to eglot Date: Sat, 28 Jan 2023 03:58:53 +0200 Message-ID: <2a80546d-551e-7989-b3c7-33fe1538a861@yandex.ru> References: <83a625g66p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39174"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Cc: 61066@debbugs.gnu.org To: Eli Zaretskii , Dimitri Belopopsky , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 28 03:00:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLaVs-000A0f-6Z for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 28 Jan 2023 03:00:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLaVh-0005Ct-6d; Fri, 27 Jan 2023 21:00:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLaVf-0005CW-44 for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 21:00:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLaVe-0000RS-Q4 for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 21:00:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLaVe-0006xY-6y for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 21:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2023 02:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61066 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61066-submit@debbugs.gnu.org id=B61066.167487114526647 (code B ref 61066); Sat, 28 Jan 2023 02:00:02 +0000 Original-Received: (at 61066) by debbugs.gnu.org; 28 Jan 2023 01:59:05 +0000 Original-Received: from localhost ([127.0.0.1]:39203 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLaUj-0006vi-EY for submit@debbugs.gnu.org; Fri, 27 Jan 2023 20:59:05 -0500 Original-Received: from mail-wm1-f52.google.com ([209.85.128.52]:54948) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLaUg-0006vE-JF for 61066@debbugs.gnu.org; Fri, 27 Jan 2023 20:59:05 -0500 Original-Received: by mail-wm1-f52.google.com with SMTP id m15so4649860wms.4 for <61066@debbugs.gnu.org>; Fri, 27 Jan 2023 17:59:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=NRzPBKRNywJ0MdiSwGdkQgdo5w+hEinMjXGjwlS7HEg=; b=U5ctEiTaLRHzcHKavllPyQdLTU60KUIEe59ALS/h34GhMsQXhyk73p9Ze7xoLCKOCd ukeUlsSiGJgn6lrDJNSkTXJm6LLzhOimbEFF/MFUPlNRxuD2BKat1kBx6nVMe6IH2jDL 1llPfrZSwOJmCLvTj4m5ORHuQnw7NcGGyFHCpgdPrQ7G+FXGdyrlFJtog2WNmnCnCZrg ZGeXOfrjALcADqgcbHIu8491a1xQOIHGZiJxfaEjRJQYWCK7cVByGra/mQnXGBISH0XY TW4fZ/WorvQE9GBXFu5GaexuDxY5xp9y9crssMVu+H4WtTViZCtYmQuna2bNZ66dF338 4uow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NRzPBKRNywJ0MdiSwGdkQgdo5w+hEinMjXGjwlS7HEg=; b=BZwEmf7mUk+yotYl7MU8eN65M17LpsWDyLvvh+4EsBuKgc83hLCJBtQcwqLBTBfnSF 8mQnznZbTE/82Eki76X34HJ1V9kR8SBm2ciOVk7NEnp8UMqniJvrwmdQMbG297I6++zP IH1yVpME12dlAQxknf6ZezCxIRd/DIQvxPsziNooBaIJxrd8M6TEzuRk3KMVNdC4wQo+ wyegFYRQbtw3+biy7HTp3iieVJXXRg1bwTe8V16ILYj6RIfzvaUQCVmN3g9PC90yi5Kg L1OkWYC5UuZvp/wHq3uOtesJ6KArSRU0bylrx83e3MDXtdIWj6GJE1841W29BxKUFJJW 3pbQ== X-Gm-Message-State: AO0yUKUNSZBbH/TCqENdZUaxu+/Xg600chb3dwQfwYAIDMmnD77A2O1K OEZWtdFA+qIAomjL56eT6qY= X-Google-Smtp-Source: AK7set8P2tYRtbMN0x7UZW4eCNU5gQZqePSH1B9nk1pJi5yLtxUNg5UmrwPGUiaqVPj10rfwrkxLAg== X-Received: by 2002:a05:600c:22d4:b0:3dc:47f4:a022 with SMTP id 20-20020a05600c22d400b003dc47f4a022mr632818wmg.25.1674871136584; Fri, 27 Jan 2023 17:58:56 -0800 (PST) Original-Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id f24-20020a05600c491800b003dc0cb5e3f1sm5525283wmp.46.2023.01.27.17.58.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 17:58:56 -0800 (PST) Content-Language: en-US In-Reply-To: <83a625g66p.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254287 Archived-At: On 26/01/2023 08:29, Eli Zaretskii wrote: > AFAIU, inlay hints provide information of the same kind as ElDoc and > in similar manner from the display and UX POV. So I think this > feature should work via ElDoc, not as a separate from-the-scratch > implementation. IIUC the "inlay hints" are about different information. Information that is not determined by the position of point. For example, annotating variable declarations with specific types in a language that infers types, here's a screenshot: https://user-images.githubusercontent.com/2771466/71774757-54269200-2fc8-11ea-8505-ac2f326761ca.png Or adding parameter types (or names) inside function calls, example: https://user-images.githubusercontent.com/2303841/35807174-43bc0c3c-0a82-11e8-8c99-591fb650e1e0.png So I don't think this fits Eldoc's protocol. You were probably thinking of signature help (that was my initial impression as well).