From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#63708: 29.0.60; rust-ts-mode not properly handling apostrophe Date: Thu, 25 May 2023 12:52:18 +0000 Message-ID: <2MdRTHLlZtWDlCx6Ky-LFtla6-aBBs4PlNgTuatIC-h4OIuKdPmsmWsIokUQ9LBMHNvH_ooIvMUlQH8F8XOjNrEUUdC9FtR1l_e6RZSy7xU=@rjt.dev> References: <83pm6pm0yz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21660"; mail-complaints-to="usenet@ciao.gmane.io" Cc: =?UTF-8?Q?=D0=99=D0=BE=D1=80=D0=B4=D0=B0=D0=BD_?= =?UTF-8?Q?=D0=9C=D0=B8=D0=BB=D0=B0=D0=B4=D0=B8=D0=BD=D0=BE=D0=B2?= , Yuan Fu , 63708@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 25 14:53:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2ASx-0005II-PW for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 25 May 2023 14:53:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2ASn-0001H2-3G; Thu, 25 May 2023 08:53:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2ASk-0001Gb-PM for bug-gnu-emacs@gnu.org; Thu, 25 May 2023 08:53:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2ASk-0003eS-GM for bug-gnu-emacs@gnu.org; Thu, 25 May 2023 08:53:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2ASk-0005Nq-0M for bug-gnu-emacs@gnu.org; Thu, 25 May 2023 08:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 25 May 2023 12:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63708 X-GNU-PR-Package: emacs Original-Received: via spool by 63708-submit@debbugs.gnu.org id=B63708.168501916520671 (code B ref 63708); Thu, 25 May 2023 12:53:01 +0000 Original-Received: (at 63708) by debbugs.gnu.org; 25 May 2023 12:52:45 +0000 Original-Received: from localhost ([127.0.0.1]:46217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2AST-0005NK-6O for submit@debbugs.gnu.org; Thu, 25 May 2023 08:52:45 -0400 Original-Received: from mail-4022.proton.ch ([185.70.40.22]:42233) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2ASQ-0005N6-6T for 63708@debbugs.gnu.org; Thu, 25 May 2023 08:52:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1685019155; x=1685278355; bh=XhZA03EQumY/pkbcmuZEmPWCiAwYMOWA8QKVrBNzdAM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=hNzbq800v+vAaMLPTOnQw2AOo/td/cEz92w6GFTUJJJUUI29FzAHqegGAt+neq+fh kSpYyNghrJcOKK71UjBEqS0cG6ru4jrVyVlrBBpJOJmNWikZZybzvrLkL/k0SKP67d OqYDK0TJ78ElT5RfNtQBiHGGo0qNxOzDwJnwfhdR+ehWz/Z6ryXExSGgCFUBxE7JxT G2ERN2G96aJUu+Mda9x4gxtRbuvfGd9p8v+mAB7+Tzk3Wo6qhZ2rSJXdpXgN4ic3IO 1z0gwKriRQV7S84mNNaGFU/XvV004hSe4CNALmQMm1Dge1H8KA2woI/CXPEHIuQP8y IAON/bTPoeiow== In-Reply-To: <83pm6pm0yz.fsf@gnu.org> Feedback-ID: 44397038:user:proton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262364 Archived-At: On Thursday, May 25th, 2023 at 01:30, Eli Zaretskii wrote: >=20 > > Date: Wed, 24 May 2023 21:40:30 +0000 >=20 > > From: yordanm--- via "Bug reports for GNU Emacs, > > the Swiss army knife of text editors" bug-gnu-emacs@gnu.org > >=20 > > In Rust (rust-ts-mode) apostrophe-doublequote-apostrophe break many > > parsing functions (scan-lists being the core one) as the apostrophe > > character is parsed as punctuation, not as a string (as it is in > > c-ts-mode for example). >=20 >=20 > Randy, can you please look into this? Thanks for the patch Yordan. Apostrophes are also used to denote lifetimes in Rust, so I'm not sure this= is the right fix. They are also used for loop labels, too. We probably need to augment rust-ts-mode--syntax-propertize where we apply = the string syntax property to any char_literal nodes. It would probably be = too late for emacs-29 though.