From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Sun, 7 Jun 2020 12:14:13 +0200 Message-ID: <2F9BF919-4E8B-4802-AEE8-4438A78B4F68@acm.org> References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> <83o8q2elja.fsf@gnu.org> <83mu5mel4o.fsf@gnu.org> <77F1DDD3-A69F-40ED-902D-74986D5E6596@acm.org> <83y2p5cumz.fsf@gnu.org> <83blm0cjlz.fsf@gnu.org> <83367ccf8w.fsf@gnu.org> <624D7FB8-A836-4A7E-8895-47E867214504@acm.org> <83o8pyc4bq.fsf@gnu.org> <55D73CA5-1EFB-4B0A-8F8B-FDA1D39F51BF@acm.org> <835zc5bsut.fsf@gnu.org> <3BBCFDD4-C14D-4628-91CB-2A0456A96FC7@acm.org> <838sh0abzz.fsf@gnu.org> <83r1us8kw6.fsf@gnu.org> <020DE875-14A8-457A-9AE4-AA0925DB8997@acm.org> <83img48ffx.fsf@gnu.org> <83bllw82xt.fsf@gnu.org> <87pnabfdr5.fsf@simenheg@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="126280"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Richard Copley , 41544@debbugs.gnu.org To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 07 12:15:31 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhsKw-000Wmd-Su for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Jun 2020 12:15:30 +0200 Original-Received: from localhost ([::1]:50052 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhsKv-0001z2-Vc for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Jun 2020 06:15:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39806) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhsKV-0001yS-AX for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 06:15:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhsKV-0003sH-1a for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 06:15:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhsKU-0005S9-UG for bug-gnu-emacs@gnu.org; Sun, 07 Jun 2020 06:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Jun 2020 10:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.159152486720889 (code B ref 41544); Sun, 07 Jun 2020 10:15:02 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 7 Jun 2020 10:14:27 +0000 Original-Received: from localhost ([127.0.0.1]:53393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhsJv-0005Qr-At for submit@debbugs.gnu.org; Sun, 07 Jun 2020 06:14:27 -0400 Original-Received: from mail1461c50.megamailservers.eu ([91.136.14.61]:37190 helo=mail267c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhsJs-0005Qb-By for 41544@debbugs.gnu.org; Sun, 07 Jun 2020 06:14:25 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1591524857; bh=zjYuVmjhXys6SkEowKSw6xzMGXpZAriCIG1Yu4VIhsY=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=AZa2+jDjpHf1ZGk7IDBeL/xL4yigsDRH/rbSOti9FdqbKW5SNoT3hQ6bAphIJ3UpT ZxthxAptRdk6lH6xmERZdHaFYDmLykxtkwBw9NBgo4vxoIP0pC/kJTD2xcneR+L99w rGDUw0PAQtWCsLQeLOIWEpWjWG73K1+up5XwcIpI= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-4e4ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.78]) (authenticated bits=0) by mail267c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 057AED6J027527; Sun, 7 Jun 2020 10:14:15 +0000 In-Reply-To: <87pnabfdr5.fsf@simenheg@gmail.com> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F1D.5EDCBD89.0029:SCFSTAT68638221, ss=1, re=-4.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: -4.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Cf92G4jl c=1 sm=1 tr=0 a=klNLuyVZdLUgl+K5Uafb2A==:117 a=klNLuyVZdLUgl+K5Uafb2A==:17 a=IkcTkHD0fZMA:10 a=M51BFTxLslgA:10 a=7DrQrguiAAAA:8 a=NCMz9fsz5WZ6VZw0lv4A:9 a=QEXdDO2ut3YA:10 a=5p0t1moz68ydotlU2Z85:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181661 Archived-At: 7 juni 2020 kl. 11.04 skrev Simen Heggest=C3=B8yl : > I can't comment on the patch overall, but this part at least seems to > address Richard Copley's complaints in bug#30295. A dark foreground is > now used for #0f0/rgba(0,255,0,0.5) and #5e5 as Richard requested, = which > indeed looks more readable to me too. Thank you, and yes, this was actually one of the motivations. > Maybe the pendulum has swung too far however. For instance, a dark > foreground is now used for #ef716e, which I think was easier to read > with the light foreground used before. Could that be fixed by tweaking > the cut-off values in color-dark-p, perhaps? Right; the current predicate should be a significant overall improvement = but there are inevitably some colours where the decision isn't quite = right. I'll see what can be done about it. It seems to be mainly those = somewhat reddish colours that need some work. Perhaps you could try list-colours-display and see if you can spot a = pattern? I'll be back with a longer reply on the principles later.