bug#11754: 24.1.50; `eval-defun' (`C-M-x') does not re-evaluate `defface'

bug#11754: 24.1.50; `eval-defun' (`C-M-x') does not re-evaluate `defface'

[Drew Adams]

emacs -Q
 
Evaluate a `defface' using `C-M-x'.  Change one of the face attributes
(e.g. `foreground') and hit `C-M-x' again.  A message says that the
face was just defined (i.e., redefined).  But the face definition was
not updated to reflect your change, as you can see using Customize or
whatever.
 
`C-M-x' should update the face definition, just like it does for
`defvar' etc.
 
(emacs) `Lisp Eval' says:
 
 In particular, this command treats `defvar' expressions specially.
 Normally, evaluating a `defvar' expression does nothing if the variable
 it defines already has a value.  But this command unconditionally resets
 the variable to the initial value specified by the `defvar'; this is
 convenient for debugging Emacs Lisp programs.  `defcustom' and `defface'
 expressions are treated similarly.  Note that the other commands
 documented in this section do not have this special feature.
 
That's just not true - `defface' is NOT treated similarly.  Yet it is
specifically called out as one of those that is treated similarly, and
contrasted with "the other commands documented in this section do not
have this special feature".

The doc is right, about what SHOULD happen.  But it doesn't.
 
In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600)
 of 2012-06-18 on MARVIN
Bzr revision: 108646 michael.albinus@gmx.de-20120617185439-jfcgwwbr97nbflkz
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include
 -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include
 -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'
 

bug#11754: 24.1.50; `eval-defun' (`C-M-x') does not re-evaluate `defface'

[Juri Linkov]

> Evaluate a `defface' using `C-M-x'.  Change one of the face attributes
> (e.g. `foreground') and hit `C-M-x' again.  A message says that the
> face was just defined (i.e., redefined).  But the face definition was
> not updated to reflect your change, as you can see using Customize or
> whatever.

This was fixed in the revision 108394.

> In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600)
>  of 2012-06-18 on MARVIN
> Bzr revision: 108646 michael.albinus@gmx.de-20120617185439-jfcgwwbr97nbflkz
                ======

Do you use a newer revision 108646 to report the bug,
but actually observe this bug in another revision older than 108394?

bug#11754: 24.1.50; `eval-defun' (`C-M-x') does not re-evaluate `defface'

[Drew Adams]

> This was fixed in the revision 108394.
> 
> > In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600)
> >  of 2012-06-18 on MARVIN
> > Bzr revision: 108646 
>                 ======
> 
> Do you use a newer revision 108646 to report the bug,
> but actually observe this bug in another revision older than 108394?

Yes, I guess I must have.  I just retested in 10846 and I do not see the bug.
Sorry for the noise.

(I sometimes have both release 24.1 and the latest binary open at the same time,
because of bugs that have been introduced since the release.  I must have
confused the two.)