From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 69709@debbugs.gnu.org, Aris Spathis <agspathis@gmail.com>
Subject: bug#69709: `sort` interface improvement and universal ordering predicate
Date: Sun, 14 Apr 2024 18:33:32 +0200 [thread overview]
Message-ID: <2E51964E-D186-4996-ACD7-B6D2051E6DB1@gmail.com> (raw)
In-Reply-To: <86cyqrnc6a.fsf@gnu.org>
14 apr. 2024 kl. 18.26 skrev Eli Zaretskii <eliz@gnu.org>:
>> Thank you for your excellent work on `sort` and related functionality!
Apparently not excellent enough!
>> Unfortunately, the new `sort` implementation occasionally crashes with a
>> segfault. The following code reproduces that in current master:
>>
>> (dotimes (i 500)
>> (sort (make-list 128 42)
>> :key (lambda (n) (make-list i n))))
>>
>> It happens for inputs of length >= `MERGESTATE_TEMP_SIZE / 2` (= 128
>> currently) along with a non-NIL `:key` function. In such cases, a
>> `Lisp_Object` array is explicitly heap-allocated to store the keys, which is
>> never marked against GC. This would not be a problem if not for the fact that
>> the `:key` function call may trigger GC.
Oh dear, what a silly mistake. Many thanks for spotting this and providing the patch, which I applied with a few minor adjustments (and a regression test).
prev parent reply other threads:[~2024-04-14 16:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 13:28 bug#69709: `sort` interface improvement and universal ordering predicate Mattias Engdegård
2024-03-10 14:09 ` Eli Zaretskii
2024-03-10 14:56 ` Mattias Engdegård
2024-03-20 19:01 ` Mattias Engdegård
2024-03-20 19:37 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-21 14:55 ` Mattias Engdegård
2024-03-21 14:54 ` Eshel Yaron via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-22 20:55 ` Dmitry Gutov
2024-03-23 14:58 ` Mattias Engdegård
2024-03-23 17:39 ` Dmitry Gutov
2024-03-23 20:09 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-23 23:19 ` Dmitry Gutov
2024-03-23 23:25 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-25 11:11 ` Mattias Engdegård
2024-03-29 10:59 ` Mattias Engdegård
2024-03-29 11:38 ` Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 11:52 ` Mattias Engdegård
2024-03-29 12:06 ` Eli Zaretskii
2024-03-29 15:02 ` Mattias Engdegård
2024-03-29 15:35 ` Eli Zaretskii
2024-03-29 16:13 ` Mattias Engdegård
2024-03-29 18:09 ` Eli Zaretskii
2024-03-10 15:48 ` Dmitry Gutov
2024-03-10 15:56 ` Mattias Engdegård
2024-03-10 16:03 ` Dmitry Gutov
2024-03-10 16:46 ` Mattias Engdegård
2024-03-10 16:55 ` Eli Zaretskii
2024-03-10 17:54 ` Dmitry Gutov
2024-03-11 7:01 ` Gerd Möllmann
2024-04-14 14:03 ` Aris Spathis
2024-04-14 16:26 ` Eli Zaretskii
2024-04-14 16:33 ` Mattias Engdegård [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2E51964E-D186-4996-ACD7-B6D2051E6DB1@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=69709@debbugs.gnu.org \
--cc=agspathis@gmail.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).