From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#59945: [PATCH] Fix empty pairs in js tree-sitter imenu alist Date: Mon, 12 Dec 2022 14:28:19 -0800 Message-ID: <2CD18C33-060B-4BC1-860E-1EB097EA7F0C@gmail.com> References: <43c6e6ed-3ddc-4ae0-a150-f86e852bd83b@app.fastmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1551"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 59945@debbugs.gnu.org To: cpbotha@vxlabs.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 23:29:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4rIP-0000Ar-6f for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 23:29:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4rIF-00084U-ID; Mon, 12 Dec 2022 17:29:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4rIE-00084I-Lf for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:29:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4rIE-00040i-E1 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4rIE-000533-9Z for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 17:29:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <43c6e6ed-3ddc-4ae0-a150-f86e852bd83b@app.fastmail.com> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 22:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59945 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59945-submit@debbugs.gnu.org id=B59945.167088411019390 (code B ref 59945); Mon, 12 Dec 2022 22:29:02 +0000 Original-Received: (at 59945) by debbugs.gnu.org; 12 Dec 2022 22:28:30 +0000 Original-Received: from localhost ([127.0.0.1]:55818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rHi-00052g-Ao for submit@debbugs.gnu.org; Mon, 12 Dec 2022 17:28:30 -0500 Original-Received: from mail-pg1-f178.google.com ([209.85.215.178]:39480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4rHf-00052Y-On for 59945@debbugs.gnu.org; Mon, 12 Dec 2022 17:28:28 -0500 Original-Received: by mail-pg1-f178.google.com with SMTP id e126so3064925pgc.6 for <59945@debbugs.gnu.org>; Mon, 12 Dec 2022 14:28:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=rYSpzlq4+xzHyV/iks3opZ5FYy51tiuRowVAHOzGI5c=; b=kofGQwPIDVnBfVBiNKbmkw+XO2n/1PJ1m43GcbXji7Pr5bngcSjAzm7HWqdjEyeo9H La7dGMh16e5HsqZGQSjBmexM2JBuNNs+ooGYsnv2+0evnqI+P0g0zcNaxjkXjfivknpP ZGQn4/QUdzFgBMFj4dHxvE9vF3Ri6zTnUdiB/yti2VFR3qPTCYgtsNLVzcCsDXneAepS 9bZ5NSaIqzs/gabLuEenYgYhn6hxCdwVdWfbfaup1JfmNOXP6Q5Yce01zvXiHGStYWc1 3qRRRMPjS9UWJy2SryXwlzevaqhbgHS7osGRhNunTxm06zr2xYkKE5l/bDDnGkqGSxHc vK3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rYSpzlq4+xzHyV/iks3opZ5FYy51tiuRowVAHOzGI5c=; b=31KfbOd6U2MqXuOeAhqIwdA/yNPos4QfzJRZguZ4EJZWCS2Csyt8aObxwP5MYnFsql 9hiLOXN4oDcWMDnPwBvHRseoGbwzvV1zgzUcTM94EhOvsEC7UiXzbFFs97btgJYEJmdP jxaq2CxbtV5k2xwuRFRviXEw8908jqnhDGx47gn4v+cGL28oOSRs6oXXkVh55tZY/f7s 4lbL0R3Cr+mk7xgeTkWxNxLiY1Srg1wRT2pPX+jqIfGvegJ7VddkmDDpkTzZS3YtE8YX N1jfB9le8vmI55SQ2YfyrV+hIfIob2as3u5tp/VNly2NwUbq7bwZkfJH6ysyvcIsKBTu q/QQ== X-Gm-Message-State: ANoB5pmP/YXlLMY3kWkD5OiUp9w8dhfq0BKcr+BlUgOVnVHU8P9S04Gu 0ZLIf8j9xs7Z2fZ0NbEOL5w= X-Google-Smtp-Source: AA0mqf6UFv63tLKWyfn8/RrWtqRaTc3vx4naMh6pBBQkSIXha6SO98VCNsnsVXhmW+Rzqd1CAuk2Rg== X-Received: by 2002:aa7:8518:0:b0:576:cda4:16c4 with SMTP id v24-20020aa78518000000b00576cda416c4mr17533731pfn.10.1670884101639; Mon, 12 Dec 2022 14:28:21 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id z13-20020aa79e4d000000b005779110635asm6300260pfq.51.2022.12.12.14.28.20 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Dec 2022 14:28:21 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250762 Archived-At: "Charl P. Botha" writes: > The current js--treesit-imenu, used by the JavaScript, TypeScript and > TSX tree-sitter modes, would return empty pairs in the imenu alist if > there were none of that type of symbol. > > This would break both the built in imenu and also packages like > consult-imenu. > > See https://github.com/minad/consult/issues/697 for the discussion > there. Thank you very much! Sorry for the inconvenience it caused. Have you signed the copyright assignment? I=E2=80=99m asking because this change = is on the verge of 15 lines. Eli, WDYT? Yuan