From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#3303: delete-frame raises old (invisible) frame Date: Fri, 15 May 2009 18:09:11 -0700 Message-ID: <2C87549A-2553-4477-BF77-6258A1CC32BE@gmail.com> Reply-To: David Reitter , 3303@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v935.3) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1242437541 9360 80.91.229.12 (16 May 2009 01:32:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 May 2009 01:32:21 +0000 (UTC) To: emacs-pretest-bug@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 16 03:32:14 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M58l3-0001e5-4A for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 May 2009 03:32:13 +0200 Original-Received: from localhost ([127.0.0.1]:52237 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M58ky-00057B-9Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 15 May 2009 21:32:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M58ku-00056w-PL for bug-gnu-emacs@gnu.org; Fri, 15 May 2009 21:32:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M58kp-00056k-Be for bug-gnu-emacs@gnu.org; Fri, 15 May 2009 21:32:03 -0400 Original-Received: from [199.232.76.173] (port=59968 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M58kp-00056h-31 for bug-gnu-emacs@gnu.org; Fri, 15 May 2009 21:31:59 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:40475) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1M58ko-0003mD-JV for bug-gnu-emacs@gnu.org; Fri, 15 May 2009 21:31:58 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4G1Vuc3006510; Fri, 15 May 2009 18:31:56 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n4G1F5iU001016; Fri, 15 May 2009 18:15:05 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: David Reitter Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sat, 16 May 2009 01:15:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 3303 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.124243616431981 (code B ref -1); Sat, 16 May 2009 01:15:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 16 May 2009 01:09:24 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n4G19LMt031975 for ; Fri, 15 May 2009 18:09:22 -0700 Original-Received: from mail.gnu.org ([199.232.76.166]:35478 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1M58Ou-0001ZZ-9r for emacs-pretest-bug@gnu.org; Fri, 15 May 2009 21:09:20 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1M58Ot-0000l7-J3 for emacs-pretest-bug@gnu.org; Fri, 15 May 2009 21:09:20 -0400 Original-Received: from mail-ew0-f210.google.com ([209.85.219.210]:52850) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M58Ot-0000l1-9X for emacs-pretest-bug@gnu.org; Fri, 15 May 2009 21:09:19 -0400 Original-Received: by ewy6 with SMTP id 6so2962912ewy.42 for ; Fri, 15 May 2009 18:09:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:from:to :content-type:content-transfer-encoding:mime-version:subject:date :x-mailer; bh=bGy1rElRbqAPiUqyAzmXl8C0rB4zN8FRBZdt97nrAPU=; b=XlY6CPSvk6zon8r98/NT/cJ9BKG055J1nV9Wrx6Iba3QQwvpfzsF4ExuP5p2fqv7sp fWjEhXzwlSo4hNg4Vx19ggh8jplq+768QHLQK6B4Xrpf1igID/fjWq2VornWD6cszwiI rWtQQrARs5io+XL+ke4ejGttnPhsxzxYMb3Fc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:from:to:content-type:content-transfer-encoding :mime-version:subject:date:x-mailer; b=s/1A+KbbshdUlL0xghrbeZ8trrrOSgvHsCyklzQS37yyglW4KPr/dtgwH/lLpWzvXC vnOhTu9clpckAVWomApxTUcgaPiMtzMzKcMR6SrcQxiTJY6TBClxf+KoiAND1exXBk8T B2R9hg67FUjSIX3r1uX0NAm7KErLbJKVWK8Ds= Original-Received: by 10.210.82.13 with SMTP id f13mr4393958ebb.72.1242436158356; Fri, 15 May 2009 18:09:18 -0700 (PDT) Original-Received: from ?192.168.250.233? ([69.26.225.190]) by mx.google.com with ESMTPS id 5sm2444837eyf.8.2009.05.15.18.09.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 15 May 2009 18:09:18 -0700 (PDT) X-Mailer: Apple Mail (2.935.3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 15 May 2009 21:32:03 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27901 gmane.emacs.pretest.bugs:24429 Archived-At: Emacs -Q under NS, then (progn (make-frame-invisible nil t) (make-frame) (delete-frame (selected-frame) t)) will unexpectedly leave one frame visible and raised. It should actually hide all frames. The code that does it come in via the NS port (75f88b1c by arobert on 2008-07-15), in do_switch_frame(): #ifdef NS_IMPL_COCOA /* term gets no other notification of this */ if (for_deletion) Fraise_frame(Qnil); #endif (do_switch_frame): When for_deletion under Cocoa, add Fraise_frame(Qnil). This seems needed in order to raise another (visible) frame - otherwise no frame gets raised (or visibly selected). The change below would address this - but is Fselect_frame() intended to make frames visible (on other platforms)? diff --git a/src/frame.c b/src/frame.c index de857af..fbef938 100644 --- a/src/frame.c +++ b/src/frame.c @@ -868,7 +868,7 @@ do_switch_frame (frame, track, for_deletion, norecord) #ifdef NS_IMPL_COCOA /* term gets no other notification of this */ - if (for_deletion) + if (for_deletion && FRAME_VISIBLE_P (XFRAME (frame))) Fraise_frame(Qnil); #endif