From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#43598: replace-in-string: finishing touches Date: Fri, 25 Sep 2020 13:22:41 +0200 Message-ID: <2C702C6F-9E36-4BB1-A8A5-6EAD29B4E616@acm.org> References: <77CD28C7-77C0-4DED-ACD0-21418489BADE@acm.org> <87blhuu3w9.fsf@gnus.org> <2CFAAACA-2FD3-44C2-B12E-E49DAA968115@acm.org> <87lfgyqffw.fsf@gnus.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35070"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 43598@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 25 13:23:13 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLlom-00092t-Nw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Sep 2020 13:23:12 +0200 Original-Received: from localhost ([::1]:54192 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLlol-0007td-Ps for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Sep 2020 07:23:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLloe-0007tW-OG for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 07:23:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kLloc-00074C-EO for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 07:23:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kLloc-0001Rx-9y for bug-gnu-emacs@gnu.org; Fri, 25 Sep 2020 07:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Sep 2020 11:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43598 X-GNU-PR-Package: emacs Original-Received: via spool by 43598-submit@debbugs.gnu.org id=B43598.16010329735541 (code B ref 43598); Fri, 25 Sep 2020 11:23:02 +0000 Original-Received: (at 43598) by debbugs.gnu.org; 25 Sep 2020 11:22:53 +0000 Original-Received: from localhost ([127.0.0.1]:42871 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLloS-0001RJ-RB for submit@debbugs.gnu.org; Fri, 25 Sep 2020 07:22:53 -0400 Original-Received: from mail1456c50.megamailservers.eu ([91.136.14.56]:45568 helo=mail266c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kLloQ-0001R0-9r for 43598@debbugs.gnu.org; Fri, 25 Sep 2020 07:22:51 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1601032963; bh=QqEPzbUbQtcSghktRdcrqw9ZdPKRCWlaK1vDoLaPvVE=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=OUPRxjlm8Geldn9xFPy12TzkyxofGqwF/qZIGubOXhvuSy0QjOyZIRmc1t0JlsejU M2R/YPBOTyKV3Y1vTimLCO2ZtpM0v2YSgZ48J2hWAgkDbTXa+igss1C37ddgNB4PRp IlCR1DI8e77yRd75BVQXm3m2OvUXT2FhTQCq2G+c= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-304ee655.032-75-73746f71.bbcust.telenor.se [85.230.78.48]) (authenticated bits=0) by mail266c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 08PBMfTc021593; Fri, 25 Sep 2020 11:22:43 +0000 In-Reply-To: <87lfgyqffw.fsf@gnus.org> X-Mailer: Apple Mail (2.3445.104.15) X-CTCH-RefID: str=0001.0A782F23.5F6DD303.007F, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=A5MSwJeG c=1 sm=1 tr=0 a=63Z2wlQ1NB3xHpgKFKE71g==:117 a=63Z2wlQ1NB3xHpgKFKE71g==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=OocQHUDgAAAA:8 a=BhJkVLQ1qYMa0PH8kg0A:9 a=CjuIK1q_8ugA:10 a=xUZTl98r3Qw_uB5NK3jt:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:188955 Archived-At: 25 sep. 2020 kl. 13.11 skrev Lars Ingebrigtsen : > It all looks good to me; please apply. Thanks, will do shortly. > Right, so if the multibyteness differs, then do another check to see > whether both strings are all-ASCII anyway, and do the comparison = without > conversion... Both strings don't need to be all-ASCII; one of them suffices. By the way, I added an argument check to replace-in-string to prevent it = from entering an infinite loop.