On 20.12.2013 11:51, Bozhidar Batsov wrote:Just a small nitpick - everything that returns a value is actually anexpression, not a statement.It can be both (see "expression statement"). This way it's notambiguous, because I'm really aligning to the statement: the containingexpression, which follows the bob or an [implicit] semicolon.In Rubocop, you've chosen to align to just the parent expression. Maybewe should find a realistic example where one would be different from theother.
Maybe `ruby-align-to-expr-keywords’ would be a more appropriate name forthe option.I was thinking rather of `ruby-align-to-statement'. A non-functionalchange that may be easier to pronounce.
Btw, I noticed this in the indent examples:zoo.lose(q, p)Shouldn’t it be:zoo.lose(q, p)Maybe, but that's harder to do. Basically, we'd want to keep theadditional indentation when and only when the parent token (.), or anyone of its siblings (in case of a chained method call) are at indentation.Checking if the parent is at indentation is easy, but finding itssiblings - not so much.