From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#7834: 24.0.50; doc of `put-image' Date: Wed, 12 Jan 2011 14:43:45 -0800 Message-ID: <2A56F0D4658C4952B1A8CA2ED7F902C2@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1294872868 17430 80.91.229.12 (12 Jan 2011 22:54:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 12 Jan 2011 22:54:28 +0000 (UTC) To: 7834@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 12 23:54:24 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pd9aB-0005P2-OM for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jan 2011 23:54:24 +0100 Original-Received: from localhost ([127.0.0.1]:55213 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pd9aB-0000cT-5X for geb-bug-gnu-emacs@m.gmane.org; Wed, 12 Jan 2011 17:54:23 -0500 Original-Received: from [140.186.70.92] (port=42748 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pd9a5-0000cL-Aj for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2011 17:54:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pd9a4-0001na-7o for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2011 17:54:17 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48532) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pd9a4-0001nT-6A for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2011 17:54:16 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Pd9NF-0000Hm-Rz; Wed, 12 Jan 2011 17:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 12 Jan 2011 22:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 7834 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Original-Received: via spool by submit@debbugs.gnu.org id=B.12948720061032 (code B ref -1); Wed, 12 Jan 2011 22:41:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 12 Jan 2011 22:40:06 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pd9ML-0000Gb-RR for submit@debbugs.gnu.org; Wed, 12 Jan 2011 17:40:06 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Pd9MJ-0000G5-H2 for submit@debbugs.gnu.org; Wed, 12 Jan 2011 17:40:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pd9Ta-0008Si-5r for submit@debbugs.gnu.org; Wed, 12 Jan 2011 17:47:34 -0500 Original-Received: from lists.gnu.org ([199.232.76.165]:50028) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pd9TT-0008Pk-8i for submit@debbugs.gnu.org; Wed, 12 Jan 2011 17:47:34 -0500 Original-Received: from [140.186.70.92] (port=41843 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pd9Rw-0005ql-3N for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2011 17:46:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pd9RV-0008EI-Ro for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2011 17:45:26 -0500 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]:22188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pd9RV-0008E9-Mg for bug-gnu-emacs@gnu.org; Wed, 12 Jan 2011 17:45:25 -0500 Original-Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.2) with ESMTP id p0CMjMFY027409 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 12 Jan 2011 22:45:24 GMT Original-Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id p0CM20xh022551 for ; Wed, 12 Jan 2011 22:45:22 GMT Original-Received: from abhmt016.oracle.com by acsmt354.oracle.com with ESMTP id 954918021294872225; Wed, 12 Jan 2011 14:43:45 -0800 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 12 Jan 2011 14:43:44 -0800 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcuyqiuaLDonjmhLShajeFAIFxmvaQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5994 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 12 Jan 2011 17:41:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:43317 Archived-At: The doc string does not tell you what you need to know. Look at the code for `image-dired-dired-toggle-marked-thumbs', for instance. You will see that it makes use of the `put-image' overlay property (to gather the right overlay(s)). That property was added by the call to function `put-image'. But there is nothing in the doc for function `put-image' that mentions that it adds property `put-image' to the overlay that it creates. In fact, the doc says nothing about this overlay, just calling it "an overlay". Well, at least it says that the overlay has a `before-string' string with a `display' property whose value is the image. 1. The doc should mention the `put-image' property, which is the only way for you to recognize such an overlay AFAICT. 2. Why not have `put-image' return the overlay itself? That would simplify code such as that of `image-dired-dired-toggle-marked-thumbs', which, just after calling `put-image', tries to examine all overlays at point just to find the right one - the one with a `put-image' property. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2011-01-03 on 3249CTO Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/imagesupport/include'