From: "Drew Adams" <drew.adams@oracle.com>
To: <emacs-pretest-bug@gnu.org>
Subject: bug#3646: 23.0.95; bookmark format upgrade is incorrect
Date: Sun, 21 Jun 2009 17:26:15 -0700 [thread overview]
Message-ID: <2A172ED84C2848FC9426043F282B4E08@us.oracle.com> (raw)
(defun bookmark-upgrade-version-0-alist (old-list)
"Upgrade a version 0 alist OLD-LIST to the current version."
(mapcar
(lambda (bookmark)
(let* ((name...))
(list
name
`((filename . ,filename)
(front-context-string . ,(or front-str ""))
(rear-context-string . ,(or rear-str ""))
(position . ,position)
(annotation . ,ann)))))
old-list))
The bookmark entry format being output by that code is this:
(NAME ((filename . FILE)
(front-context-string . FRONT-STR)
(rear-context-string . REAR-STR)
(position . POS)
(annotation . ANNOTATION)))
And that is what is called the "old deprecated" format in the doc
string of `bookmark-alist'. Upgrade should upgrade to the latest
format, not an old, deprecated one.
Further, "the old deprecated one" should be replaced by a precise
reference to the last Emacs version that _produced_ such a deprecated
format. Things are currently doubly confusing because we "upgrade"
from the bookmark version 0 format to an "old deprecated" format - and
there is yet a third format: the current format.
In GNU Emacs 23.0.95.1 (i386-mingw-nt5.1.2600)
of 2009-06-19 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'
next reply other threads:[~2009-06-22 0:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 0:26 Drew Adams [this message]
2012-10-02 23:10 ` bug#3646: "bookmark format upgrade is incorrect" Karl Fogel
2012-10-03 0:04 ` Drew Adams
2012-10-03 5:05 ` Karl Fogel
2012-10-03 5:18 ` Drew Adams
2012-10-03 12:53 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2A172ED84C2848FC9426043F282B4E08@us.oracle.com \
--to=drew.adams@oracle.com \
--cc=3646@emacsbugs.donarmstrong.com \
--cc=emacs-pretest-bug@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).