From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Maragakis via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#52067: 29.0.50; string-glyph-split halts on certain emoji strings Date: Wed, 24 Nov 2021 10:15:07 -0500 Message-ID: <29E98EEC-07C6-4270-9B23-A9734CFC9279@icloud.com> References: <829C7136-B97A-47CB-9F35-76EF73D971E5@icloud.com> <87a6huvwls.fsf_-_@gnus.org> Reply-To: Paul Maragakis Mime-Version: 1.0 (Mac OS X Mail 15.0 \(3693.20.0.1.32\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21636"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 52067@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 24 16:16:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mpu0T-0005M2-GY for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Nov 2021 16:16:21 +0100 Original-Received: from localhost ([::1]:49790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mpu0S-0001hD-7S for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Nov 2021 10:16:20 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mpu0B-0001h5-4u for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 10:16:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43175) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mpu0A-0005cS-G5 for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 10:16:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mpu0A-0002Ms-C6 for bug-gnu-emacs@gnu.org; Wed, 24 Nov 2021 10:16:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Maragakis Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Nov 2021 15:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52067 X-GNU-PR-Package: emacs Original-Received: via spool by 52067-submit@debbugs.gnu.org id=B52067.16377669219043 (code B ref 52067); Wed, 24 Nov 2021 15:16:02 +0000 Original-Received: (at 52067) by debbugs.gnu.org; 24 Nov 2021 15:15:21 +0000 Original-Received: from localhost ([127.0.0.1]:54721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mptzV-0002Ln-23 for submit@debbugs.gnu.org; Wed, 24 Nov 2021 10:15:21 -0500 Original-Received: from st43p00im-ztdg10071801.me.com ([17.58.63.171]:53750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mptzR-0002LU-OP for 52067@debbugs.gnu.org; Wed, 24 Nov 2021 10:15:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; t=1637766912; bh=KRT+zjQvS1Bm4FrQfvV45Xc7AzpgN5m2bbi+OrS+7JQ=; h=Content-Type:Mime-Version:Subject:From:Date:Message-Id:To; b=IlY2Cy2Uo5pgcAGX7hop+nsk0nKR/kiEZ0tb72ODVMNYfkRjnLNtLaHjOY45hi2By ex85lQ/tDr+R2BJBlfz4e+rm/D5euk8kjXpQD0pQYJe5ZCSadD8VyjLqutU4/DZoyq NISmMjKj1+nTe6FXNVYDoy0Vdrw49/2g/C5I5eEvSmty5mRd+DD84hmr7Ywni1kU+w QZxJsbjjLIqVkkAQSQoPKaIXpA2RvF6WhhgTbDgESsj0eRTKHNo6gHaLtJbMtFtlwq yJxe+EZ/irz+cEM3zcqPd/gqwhU5XHuc64EssaMHarzlF0YKv+h1WbwPpvZXIItHny lsb4AAg4xCQIw== Original-Received: from smtpclient.apple (unknown [160.39.47.209]) by st43p00im-ztdg10071801.me.com (Postfix) with ESMTPSA id 894125403B7; Wed, 24 Nov 2021 15:15:08 +0000 (UTC) In-Reply-To: <87a6huvwls.fsf_-_@gnus.org> X-Mailer: Apple Mail (2.3693.20.0.1.32) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425, 18.0.790 definitions=2021-11-24_04:2021-11-23, 2021-11-24 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-2009150000 definitions=main-2111240085 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:220739 Archived-At: Excellent---and thanks for the explanation! =20 I confirm that the latest Emacs 29 fixes the bug. =20 You can close this ticket. Paul > On Nov 24, 2021, at 2:30 AM, Lars Ingebrigtsen wrote: >=20 > Paul Maragakis writes: >=20 >> The logic in string-glyph-split expects the first two elements in the = result >> from find-composition-internal to give the start and end of a = multibyte grapheme >> and return nil when there is a regular character at position POS. = However, this=20 >> isn't always the case. >=20 > Yup. =20 >=20 > Paul Maragakis writes: >=20 >> The following code fixes this bug, though there might be better ways >> to fix it for someone who understands the domain. >=20 > Thanks. `find-composition' takes a the LIMIT parameter, and that'll > make it avoid searching back into the bit of the string that we've > already handled. So I did that instead in Emacs 29. >=20 > --=20 > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no