From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73768: 'read-passwd-mode' can clobber user defined mode lines Date: Thu, 17 Oct 2024 20:09:33 +0200 Message-ID: <298302a6-c037-4297-9a70-5b48a6fbb649@gmx.at> References: <1d3172d5-3704-40c6-92af-8888b0657871@gmx.at> <87v7xxsj4l.fsf@gmx.de> <87wmicqe5a.fsf@gmx.de> <877cacvv0r.fsf@gmx.de> <49fca25a-d5aa-4f14-ae09-52923eb5ce85@gmx.at> <87zfn3w48f.fsf@gmx.de> Reply-To: martin rudalics Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27194"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 73768@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 17 20:11:26 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t1Uy5-0006p1-Cu for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Oct 2024 20:11:25 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t1UxY-0007Os-0V; Thu, 17 Oct 2024 14:10:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1UxN-0007DV-Lw for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 14:10:43 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t1UxM-00061b-OD for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 14:10:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=OcJVBQ9oB0YELANbVHuZi+Q4Ot22UrrH88e85MmfXCU=; b=NqLFRpdEpZmpjZ/smgClDzOZteQ0VR2PY/mXUHGKcOjShlG4N4xYSVCIwi1v+Go8LJOubj5qpGI0IhvPgMY88ILdbvRVfASQXgO1xsfsRQtKZzjIRCuXU0qlyOkVVpxPGoxLipoVgRhS2uzdnHC/Zr955CSQjPM7GVmS0CW5pCN8myXqSEddqtvN9glhC5o4a3yhUbUQHJXN1Rf8neXe1U7mqDbje/fzAmOQAWbTa9hHJoL1djdx2W/5/Tl/swsoEZhVPzPQCqdIvJRJd2oO+VviuLwgpEEsJXz2WkB9RHX1tOd0fruM3db0ocfGCq4zQ56MNl0B7bjpa6ZHjuJAPA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t1Uxh-0004iC-Ux for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 14:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Oct 2024 18:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73768 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors" , 73768@debbugs.gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172918862917680 (code B ref -1); Thu, 17 Oct 2024 18:11:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Oct 2024 18:10:29 +0000 Original-Received: from localhost ([127.0.0.1]:35550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1Ux7-0004ay-3a for submit@debbugs.gnu.org; Thu, 17 Oct 2024 14:10:29 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:46972) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t1Ux1-0004am-PD for submit@debbugs.gnu.org; Thu, 17 Oct 2024 14:10:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1Uwg-0006uq-2e for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 14:09:58 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t1Uwe-0005hw-0j for bug-gnu-emacs@gnu.org; Thu, 17 Oct 2024 14:09:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.at; s=s31663417; t=1729188581; x=1729793381; i=rudalics@gmx.at; bh=OcJVBQ9oB0YELANbVHuZi+Q4Ot22UrrH88e85MmfXCU=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=ZEcGcXmkTlqMtxYyb9Txg2c4sNC49Hf0xu3svOeGSCd/FGMd67o5Q/Rl6Nv7htRk ydzHhF4/GbaQCkQqgcQJcyoPlR1AANb3wN3MFgnxzZWuz1duCT12V83Zo9mTaJXiC M+C0WQhbxt+kZjsaFdJksCG+5oYv//Os8uIqZw62ynqAXxO7sX3fJLaZ96+t3D090 Odzk2OEUyEF7iK4nkRTNz6zsTtPwq6vWPtjs1KsTdlDdK1mrvD+IyIrb9nNlzavC3 xd6siySFwjzsDU9eKMhxRX/l2GHj4SjSdl9ZgDX51+AjiHorHhrL6lxT1GqlRN/cO 5ofoREjKlCCfV+Gr+g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.31.113] ([212.95.5.87]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Md6Mt-1tb6fu1fal-00aBd7; Thu, 17 Oct 2024 20:09:41 +0200 Content-Language: en-US In-Reply-To: <87zfn3w48f.fsf@gmx.de> X-Provags-ID: V03:K1:xME1mBWJcmJYvL4ZO9ZB6f3WVSzzrB/pk7n4nhYGxNxnidETwSn I7T6Nkou+M0roOwucIuE2dX/+uLOCBON5LvIAp/XCXrnpptq48XxukxjzkurpqDNzWOmN9V BHKKlGdbtNAMTlcx0eev4fL8OqBMq2z3MZvDpGByGf3cWG9c7fH882j9FDsOCXxuaLpEvvj JArZnaCYVhWJef/3cBHTw== UI-OutboundReport: notjunk:1;M01:P0:g+BA9BEoESI=;107GCjQ4gGyv5a7ao76E4xbewHU pLOqZaexlLU5k41kYUZc2CVQg2Qe6U85Bg20eLOv8XT5Ah9eLXPUI8ildXk01lqGYSwulWfZR 6E58gYU9VrBoBQAfu1mcfzThVFsjQPIcMwktZqCficts6RQGQkebFNSgN6IdDfpjAiAJfH8B2 o/sU96TR9nM7WLqf7FGmZ+ad4niomIYAUcnOJRidPj4jXUgEmrr6V7XyQRIWQcBnGO0YecTNb bZfk+67R8hzKhmej5132iWj1C1b+qz5HNxJIgHfYZ+DaRla7jVDe7gXXReWCziXK1WXqS1PBw yQxXlJ5eT9pBUDi+XQfDVimAyzdGNH9sKYV5CPTFE9Ox+FXI0cg6Bz4CBz/6c7qnIc1oR9WLQ 9U+jrBXQXuZb/MlwMnkYWxgK7PkMlN+Gdc7/zQEqEpl7Xl54Ew4XtvIz/qVtPlnT3OqUcKzYI x3kGhDV1TAy2Jr1GesKCjGoWaRt8aIaxLnEuEdaordRuaSWFiNgq7FVm1ltz7XyF7v9w5Rk2T OILD6AME/EiVCo3SQJP5XoF+94qiXfC/wV7oHAypoQqn/V90z4Db99Om9VcBl8UYil7wrHQYQ qrentowCZZoqSbXqwWuP75PlofKDdoFWM0rCswAOB0npecOd+tVuLJaQG8+Cc24Lxh9Sagg3h Fs+/hmEy1RbtEGTURX7t8ZT0hXRw2rvwXsxfslN4IHNNrkDlWKJy6GC/njmI2t5iEcM/K9gzA SZDx1Sk417RIcUk1+AxabhloUy8Cy2eBPdKz16XN3RePPb7Xv0BC4ti6v03AHJEB01WOX2al Received-SPF: pass client-ip=212.227.17.21; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-1.277, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293744 Archived-At: > I haven't seen any application in the wild which offers cascaded > password input. What would be the use case for this? My feeling is, that > this is a misuse. We might not forbid it, but we might show a warning. Then why does 'read-passwd' deliberately offer it via (let ((enable-recursive-minibuffers t) If it's a misuse, it should rather bind it to nil. Another mystery: After commit de88ed8646383301f20f8340e13d43e5918310fa Author: Lars Ingebrigtsen Date: Sun Oct 13 05:15:18 2019 +0200 Hide passwords more in `read-password' * lisp/subr.el (read-password--hide-password): Factor out (bug#17127). (read-passwd): Use it in post-command-hook instead of after-change-functions to ensure that we hide the password no matter what inserts text. entering 'read-passwd' does (add-hook 'post-command-hook #'read-passwd--hide-password nil t)) while exiting still does ;; Not sure why but it seems that there might be cases where the ;; minibuffer is not always properly reset later on, so undo ;; whatever we've done here (bug#11392). (remove-hook 'after-change-functions #'read-passwd--hide-password 'local) If that fix of Bug#11392 (or Bug#11397) were really needed, then we should remove read-password--hide-password from 'post-command-hook' now. But there were no bug reports in the last four years so probably that bug was fixed by other means. In either case the current 'remove-hook' is a noop now. martin